[SRU] Update soundconverter with backported bugfixes for 2.0.4

Bug #1423709 reported by Michele Giacomoli
22
This bug affects 3 people
Affects Status Importance Assigned to Milestone
soundconverter (Ubuntu)
Fix Released
Undecided
Unassigned
Trusty
Fix Released
Undecided
Unassigned
Utopic
Fix Released
Undecided
Unassigned

Bug Description

[Impact]
The developer of soundconverter, Gautier (kassoulet), created a branch with highly recommended fixes for soundconverter 2.0.4, which fixes some annoying bugs, one of which is the inability to convert videos to audio, because every time you launch the conversion it looks for a gstreamer plugin it can't find and abort the conversion leaving an empty file in the destination dir (#1308187)

[Test Case]
Open soundconverter
Add a video (I tried with an mp4 with h264+aac codecs) to the conversion queue
Press the "Convert" button
A window appears where it looks for an h264 decoder (while I already have it installed on my system)
After some seconds it tells you he couldn't find any decoder for the job
The conversion is aborted and you will find an empty file in the destination folder (by default the same of the input one) with the same name of the input file and the extension changed

[Regression Potential]
I managed to build the patched version, the bugs are fixed and I didn't find any noticeable regression.

[Other Info]
I managed to make the debdiff, but since I feel insecure with build & packaging stuff, I'd prefer someone else to make it (maybe someone from Ubuntu Developers Team)
Link of the branch: https://github.com/kassoulet/soundconverter/tree/2.0

ProblemType: Bug
DistroRelease: Ubuntu 14.04
Package: soundconverter 2.0.4-0ubuntu1
ProcVersionSignature: Ubuntu 3.13.0-45.74-generic 3.13.11-ckt13
Uname: Linux 3.13.0-45-generic x86_64
ApportVersion: 2.14.1-0ubuntu3.6
Architecture: amd64
CurrentDesktop: Unity
Date: Thu Feb 19 22:54:31 2015
InstallationDate: Installed on 2014-10-01 (141 days ago)
InstallationMedia: Ubuntu 14.04.1 LTS "Trusty Tahr" - Release amd64 (20140722.2)
PackageArchitecture: all
SourcePackage: soundconverter
UpgradeStatus: No upgrade log present (probably fresh install)

Revision history for this message
Michele Giacomoli (michele-giacomoli) wrote :
description: updated
Revision history for this message
Launchpad Janitor (janitor) wrote :

Status changed to 'Confirmed' because the bug affects multiple users.

Changed in soundconverter (Ubuntu):
status: New → Confirmed
Revision history for this message
Michele Giacomoli (michele-giacomoli) wrote :

Sorry for the wait, busy time.
Here is my try of getting a correct debdiff

Revision history for this message
Ubuntu Foundations Team Bug Bot (crichton) wrote :

The attachment "soundconverter.debdiff" seems to be a debdiff. The ubuntu-sponsors team has been subscribed to the bug report so that they can review and hopefully sponsor the debdiff. If the attachment isn't a patch, please remove the "patch" flag from the attachment, remove the "patch" tag, and if you are member of the ~ubuntu-sponsors, unsubscribe the team.

[This is an automated message performed by a Launchpad user owned by ~brian-murray, for any issue please contact him.]

tags: added: patch
Changed in soundconverter (Ubuntu):
status: Confirmed → Fix Released
Changed in soundconverter (Ubuntu Utopic):
status: New → Fix Released
Changed in soundconverter (Ubuntu Trusty):
status: New → Triaged
assignee: nobody → Timo Jyrinki (timo-jyrinki)
Revision history for this message
Timo Jyrinki (timo-jyrinki) wrote :

Thanks for the excellent fix/debdiff, I had bumped into the bug myself too! I changed the version number to ubuntu1.1 instead of ubuntu2 like is the habit on SRU:s, and added "#" in the front of the bug numbers.

This bug will be updated by a bot when the SRU is ready for testing in the -proposed pocket. Until then it's visible in the Unapproved queue at https://launchpad.net/ubuntu/trusty/+queue?queue_state=1&queue_text=

Changed in soundconverter (Ubuntu Trusty):
status: Triaged → In Progress
Revision history for this message
Timo Jyrinki (timo-jyrinki) wrote :

(I forgot to mention, I built it for myself too and successfully now extracted audio from video unlike before the fixes)

Revision history for this message
Michele Giacomoli (michele-giacomoli) wrote :

Thank you, but the credit for the excellent debdiff goes to Javier Lopez from ubuntu-devel mailing list who hinted me all the steps.

So we just have to wait for the bot now, right?

Revision history for this message
Timo Jyrinki (timo-jyrinki) wrote :

@Michele: Yes, we wait now for the SRU team to manually process/review the queue (may take some time), after which the bug will be updated. So it's not automatic as such.

Revision history for this message
Chris J Arges (arges) wrote : Please test proposed package

Hello Michele, or anyone else affected,

Accepted soundconverter into trusty-proposed. The package will build now and be available at http://launchpad.net/ubuntu/+source/soundconverter/2.0.4-0ubuntu1.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-needed to verification-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

Changed in soundconverter (Ubuntu Trusty):
status: In Progress → Fix Committed
tags: added: verification-needed
Revision history for this message
Michele Giacomoli (michele-giacomoli) wrote :

Obviously it works for me XD

Revision history for this message
katsu (katsukatsu-deactivatedaccount) wrote :
tags: added: verification-done
removed: verification-needed
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package soundconverter - 2.0.4-0ubuntu1.1

---------------
soundconverter (2.0.4-0ubuntu1.1) trusty; urgency=low

  * New upstream stable branch bug fixes (LP: #1423709).
    - Ignore video codecs (LP: #1308187). Thanks to Thibaut
    - Empty task queue when aborting. Thanks to Michael.
    - Fix TypeError when calling show_error. Thanks to Michael
 -- Michele Giacomoli <email address hidden> Tue, 07 Apr 2015 00:45:43 +0200

Changed in soundconverter (Ubuntu Trusty):
status: Fix Committed → Fix Released
Revision history for this message
Brian Murray (brian-murray) wrote : Update Released

The verification of the Stable Release Update for soundconverter has completed successfully and the package has now been released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

Revision history for this message
Timo Jyrinki (timo-jyrinki) wrote :

Unfortunately the update has been put on hold since while it was being distributed to the first 10% of people new crashes started appearing: https://errors.ubuntu.com/problem/a6eb66f467c592b449dfc595fe290d8a1bfa971e

---
  File "/usr/lib/i386-linux-gnu/soundconverter/python/soundconverter/gstreamer.py", line 217, in on_message
    debug('ignoring video codec: ', mime_type)
UnboundLocalError: local variable 'debug' referenced before assignment
---

I did not see this during my testing and I'm not sure if it's fatal, but the upgrade can't proceed before it's investigated.

Phased updates are shown at http://people.canonical.com/~ubuntu-archive/phased-updates.html

Changed in soundconverter (Ubuntu Trusty):
assignee: Timo Jyrinki (timo-jyrinki) → nobody
status: Fix Released → Fix Committed
Revision history for this message
Michele Giacomoli (michele-giacomoli) wrote :

Unfortunately I don't have access to the link, so I can't view related data

Revision history for this message
Michele Giacomoli (michele-giacomoli) wrote :

Running soundconverter from terminal I get the same error, but the file gets converted successfully anyway. I'll investigate on it.

Revision history for this message
GautierPortet (kassoulet) wrote :

Wep, overlooked this. The debug() function is aliased by parse_error()

The fix is there : https://github.com/kassoulet/soundconverter/commit/ee70279a4daa70de2e693795c85d0276ccb0ec2d

Revision history for this message
Michele Giacomoli (michele-giacomoli) wrote :

Wow, you anticipated me, I was trying to fix in the same way. I'll soon upload the new debdiff

Revision history for this message
Michele Giacomoli (michele-giacomoli) wrote :

Here is the debdiff soundconverter_2.0.4-0ubuntu1.1 to soundconverter_2.0.4-0ubuntu1.2

Revision history for this message
Michele Giacomoli (michele-giacomoli) wrote :

@Timo
The debdiff with the fix you noticed has been uploaded, what do we have to do now?

Thank you for your patience

Revision history for this message
Timo Jyrinki (timo-jyrinki) wrote :

@Michele
Same thing as the last time. I just uploaded the debdiff and it's in https://launchpad.net/ubuntu/trusty/+queue?queue_state=1&queue_text= - I added this bug nr in the changelog so that this bug will again be updated once it's ready to be verified.

Indeed the error seems gone also in my testing by testing first 1.1 and then 1.2 with the same video file. Thanks a lot for fixing that too!

Revision history for this message
Michele Giacomoli (michele-giacomoli) wrote :

@Timo
Sorry, after I uploaded the debdiff I didn't see any activity and thought I had to do something more (like remove verification-done tag, or subscribe some team)

Thanks goes to Gautier for fixing this bug very quickly!

Revision history for this message
Chris J Arges (arges) wrote : Please test proposed package

Hello Michele, or anyone else affected,

Accepted soundconverter into trusty-proposed. The package will build now and be available at http://launchpad.net/ubuntu/+source/soundconverter/2.0.4-0ubuntu1.2 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-needed to verification-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

tags: removed: verification-done
tags: added: verification-needed
Revision history for this message
Michele Giacomoli (michele-giacomoli) wrote :

Works for me. No errors found running it from terminal

Revision history for this message
katsu (katsukatsu-deactivatedaccount) wrote :

1. running soundconverter on terminal.
2. convert mp4 to mp3.
---> no traceback message on terminal

$ LANG=C apt-cache policy soundconverter
soundconverter:
  Installed: 2.0.4-0ubuntu1.2
  Candidate: 2.0.4-0ubuntu1.2
  Version table:
 *** 2.0.4-0ubuntu1.2 0
        400 http://ftp.jaist.ac.jp/pub/Linux/ubuntu/ trusty-proposed/universe i386 Packages
        100 /var/lib/dpkg/status
     2.0.4-0ubuntu1.1 0
        500 http://ftp.jaist.ac.jp/pub/Linux/ubuntu/ trusty-updates/universe i386 Packages
     2.0.4-0ubuntu1 0
        500 http://ftp.jaist.ac.jp/pub/Linux/ubuntu/ trusty/universe i386 Packages

tags: added: verification-done
removed: amd64 apport-bug third-party-packages verification-needed
tags: added: amd64 apport-bug third-party-packages
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package soundconverter - 2.0.4-0ubuntu1.2

---------------
soundconverter (2.0.4-0ubuntu1.2) trusty; urgency=low

  * Fix debug() local aliasing. (LP: #1423709)
 -- Michele Giacomoli <email address hidden> Fri, 17 Apr 2015 14:40:37 +0200

Changed in soundconverter (Ubuntu Trusty):
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.