crash cannot find stack info on ppc64le

Bug #1429250 reported by bugproxy
16
This bug affects 1 person
Affects Status Importance Assigned to Milestone
crash (Ubuntu)
Fix Released
Medium
Chris J Arges
Trusty
Fix Released
Medium
Chris J Arges

Bug Description

SRU Justification

[Impact]
crash's sub-command cannot show stack frame of active tasks on ppc64le systems.

[Test Case]
1. capturing a vmcore by kdump on ppc64le system
2. issuing crash with this vmcore
3. run 'bt' in crash
4. no stack frame displaied

[Fix]
https://github.com/crash-utility/crash/commit/dc4ea682a21567dd9d093862ec54eb8529199c05

[Regression potential]
This is easily testable and only affects ppc64le systems. This has already been backported to vivid without issue.

--

Problem Description
=============================
crash's sub-command cannot show stack frame of active tasks on ppc64le systems. Please see

https://www.redhat.com/archives/crash-utility/2015-January/msg00033.html

for details.

Contact Information = Ping Tian <email address hidden>, Mikhail <email address hidden>

---uname output---
Linux thymelp2.isst.aus.stglabs.ibm.com 3.10.0-221.ael7b.ppc64le #1 SMP Wed Jan 7 09:27:09 EST 2015 ppc64le ppc64le ppc64le GNU/Linux

Machine Type = CHRP IBM,8247-22L lpar

Steps to Reproduce
=============================
1. capturing a vmcore by kdump on ppc64le system
2. issuing crash with this vmcore
3. run 'bt' in crash
4. no stack frame displaied

Userspace tool common name: crash
The userspace tool has the following bit modes: 64-bit
Userspace rpm: crash-7.0.9-2.ael7b.ppc64le

== Comment: #5 - Hari Krishna Bathini <email address hidden> - 2015-02-06 13:18:18 ==
For active tasks, there are two methods to get backtrace.
Firstly, using pt_note registers. If this fails,
use default stack search method to get backtrace.
In ppc64le, currently both methods seem to fail.
The below patch resolves problem in default stack search method.
https://github.com/crash-utility/crash/commit/dc4ea682a21567dd9d093862ec54eb8529199c05
This effectively resolves this bug.

But the problem with first method is still open.
I couldn't look into the problem with first method yet.
Will try to work on this next week.

Thanks
Hari

== Comment: #6 - Hari Krishna Bathini <email address hidden> - 2015-02-20 00:08:46 ==
(In reply to comment #5)
> (In reply to comment #4)
> > Any update?
>
> For active tasks, there are two methods to get backtrace.
> Firstly, using pt_note registers. If this fails,
> use default stack search method to get backtrace.
> In ppc64le, currently both methods seem to fail.
> The below patch resolves problem in default stack search method.
> https://github.com/crash-utility/crash/commit/
> dc4ea682a21567dd9d093862ec54eb8529199c05
> This effectively resolves this bug.
>
> But the problem with first method is still open.
> I couldn't look into the problem with first method yet.
> Will try to work on this next week.
>
> Thanks
> Hari

I would suggest, we close this bug as the issue reported is resolved with the below patch
https://github.com/crash-utility/crash/commit/dc4ea682a21567dd9d093862ec54eb8529199c05

We could track the problem with first method offline or in a separate bug if needed.

Thanks
Hari

== Comment: #10 - Breno Henrique Leitao <email address hidden> - 2015-03-02 15:42:05 ==
Canonical,

Can we move Crash to versin 7.1.0 that already contains this fix?

Thanks.

== Comment: #11 - Hari Krishna Bathini <email address hidden> - 2015-03-05 23:18:17 ==
(In reply to comment #6)
> (In reply to comment #5)
> > (In reply to comment #4)
> > > Any update?
> >
> > For active tasks, there are two methods to get backtrace.
> > Firstly, using pt_note registers. If this fails,
> > use default stack search method to get backtrace.
> > In ppc64le, currently both methods seem to fail.
> > The below patch resolves problem in default stack search method.
> > https://github.com/crash-utility/crash/commit/
> > dc4ea682a21567dd9d093862ec54eb8529199c05
> > This effectively resolves this bug.
> >
> > But the problem with first method is still open.
> > I couldn't look into the problem with first method yet.
> > Will try to work on this next week.
> >
> > Thanks
> > Hari
>
> I would suggest, we close this bug as the issue reported is resolved with
> the below patch
> https://github.com/crash-utility/crash/commit/
> dc4ea682a21567dd9d093862ec54eb8529199c05
>
> We could track the problem with first method offline or in a separate bug if
> needed.

Further, this is more of an alternative approach for getting backtrace.
So, the problem I mentioned here doesn't have any issues in terms of functionality
with regard to this bug or any other for that matter.
Since, there are no issues in terms of functionality, I am not sure on whether to raise a bug.
It is on my TODO list and I am thinking of chasing this offline..

Thanks
Hari

bugproxy (bugproxy)
tags: added: architecture-ppc64le bugnameltc-120594 severity-high targetmilestone-inin---
Revision history for this message
Ubuntu Foundations Team Bug Bot (crichton) wrote :

Thank you for taking the time to report this bug and helping to make Ubuntu better. It seems that your bug report is not filed about a specific source package though, rather it is just filed against Ubuntu in general. It is important that bug reports be filed about source packages so that people interested in the package can find the bugs about it. You can find some hints about determining what package your bug might be about at https://wiki.ubuntu.com/Bugs/FindRightPackage. You might also ask for help in the #ubuntu-bugs irc channel on Freenode.

To change the source package that this bug is filed about visit https://bugs.launchpad.net/ubuntu/+bug/1429250/+editstatus and add the package name in the text box next to the word Package.

[This is an automated message. I apologize if it reached you inappropriately; please just reply to this message indicating so.]

tags: added: bot-comment
affects: ubuntu → crash (Ubuntu)
bugproxy (bugproxy)
tags: added: targetmilestone-inin1504
removed: targetmilestone-inin---
Revision history for this message
bugproxy (bugproxy) wrote : Comment bridged from LTC Bugzilla

------- Comment From <email address hidden> 2015-03-30 16:01 EDT-------
Has this patch been moved upstream yet? If not, could we get a test kernel to verify this working?

Revision history for this message
bugproxy (bugproxy) wrote :

------- Comment From <email address hidden> 2015-04-07 05:55 EDT-------
This bug has been fixed in upstream with crash version 7.10. But looks like in ubuntu, only crash 7.0.8 is available. So this bug isn't fixed yet.

Chris J Arges (arges)
Changed in crash (Ubuntu):
assignee: nobody → Chris J Arges (arges)
status: New → In Progress
importance: Undecided → Medium
Revision history for this message
Chris J Arges (arges) wrote :

Uploaded patch against 7.0.8 for Vivid. Should be in 7.0.8-1ubuntu2.

Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package crash - 7.0.8-1ubuntu2

---------------
crash (7.0.8-1ubuntu2) vivid; urgency=medium

  * Fix-for-the-PPC64-bt-command-on-both-big-endian-and-.patch (LP: #1429250)
 -- Chris J Arges <email address hidden> Tue, 07 Apr 2015 13:52:16 -0500

Changed in crash (Ubuntu):
status: In Progress → Fix Released
Revision history for this message
bugproxy (bugproxy) wrote :

------- Comment From <email address hidden> 2015-04-15 09:06 EDT-------
(In reply to comment #19)
> This bug was fixed in the package crash - 7.0.8-1ubuntu2
>
> ---------------
> crash (7.0.8-1ubuntu2) vivid; urgency=medium
>
> * Fix-for-the-PPC64-bt-command-on-both-big-endian-and-.patch (LP: #1429250)
> -- Chris J Arges <email address hidden> Tue, 07 Apr 2015 13:52:16
> -0500

I can confirm that the patch has been applied in crash (7.0.8-1ubuntu2) by code reviewing. Thanks.

Revision history for this message
bugproxy (bugproxy) wrote :

------- Comment From <email address hidden> 2015-04-15 12:57 EDT-------
Closing it at IBM side as fixed.

Revision history for this message
Breno Leitão (breno-leitao) wrote :

We would like to have this fix also for 14.04 branch. We requested that in bug LP #1463653

Chris J Arges (arges)
Changed in crash (Ubuntu Trusty):
assignee: nobody → Chris J Arges (arges)
importance: Undecided → Medium
status: New → In Progress
Chris J Arges (arges)
description: updated
Revision history for this message
Brian Murray (brian-murray) wrote : Please test proposed package

Hello bugproxy, or anyone else affected,

Accepted crash into trusty-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/crash/7.0.3-3ubuntu4.3 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-needed to verification-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

Changed in crash (Ubuntu Trusty):
status: In Progress → Fix Committed
tags: added: verification-needed
bugproxy (bugproxy)
tags: added: verification-done
removed: verification-needed
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package crash - 7.0.3-3ubuntu4.3

---------------
crash (7.0.3-3ubuntu4.3) trusty; urgency=medium

  * Fix-for-the-PPC64-bt-command-on-both-big-endian-and-.patch (LP: #1429250)
  * Remove extraneous patch:
      0001-Implemented-support-for-the-ARM64-bt-l-option.patch

 -- Chris J Arges <email address hidden> Mon, 10 Aug 2015 16:44:48 -0500

Changed in crash (Ubuntu Trusty):
status: Fix Committed → Fix Released
Revision history for this message
Chris J Arges (arges) wrote : Update Released

The verification of the Stable Release Update for crash has completed successfully and the package has now been released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.