Evergreen

Content Cafe opens in a new window

Bug #1431055 reported by Liam Whalen
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Evergreen
New
Undecided
Jeff Davis
Evergreen 3.next

Bug Description

Evergreen 2.6
OpenSRF 2.4
PostgreSQL 9.1
Ubuntu 14.04

When the Reviews & More link is used in the Search Results, the Content Cafe details are opened in a new window.

This causes problems for touch screen kiosks.

This feature will add YAOUS opac.reviews_and_more_new_tab. When true a new tab will open with the Reviews & More details. When it is false, the details will open in the current window.

This feature will work in the Staff Client and the TPAC.

This code is working at Sitka. I will port it over to master here.

Revision history for this message
Liam Whalen (whalen-ld) wrote :

Here is the working branch for these changes:

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/ldw/LP1431055

tags: added: pullrequest
Liam Whalen (whalen-ld)
Changed in evergreen:
milestone: none → 2.next
Revision history for this message
Kathy Lussier (klussier) wrote :

Setting this to Won't Fix since the functionality is available in 2.7+ and 2.6 is no longer supported.

Revision history for this message
Kathy Lussier (klussier) wrote :

Ugh! Sorry. I added the comment to the wrong bug. This one still stands.

Jim Keenan (jkeenan)
Changed in evergreen:
assignee: nobody → Jim Keenan (jkeenan)
Revision history for this message
Kathy Lussier (klussier) wrote :

I loaded this code on to a Sandbox for Bug Squashing Day and added Content Cafe credentials in the Apache config to get the Reviews & More link to to display on the search results page. However, I receive an Internal Server error when retrieving search results on the Sandbox. I see the following in osrfsys.log

[2015-06-11 20:45:12] /usr/sbin/apache2 [INFO:30045:CStoreEditor.pm:139:14340650193004519] editor[0|0] request en-US open-ils.cstore.json_query.atomic {"from":["actor.org_unit_ancestor_setting","opac.reviews_and_more_new_tab",""]}
open-ils.cstore 2015-06-11 20:45:12 [INFO:29028:osrf_application.c:1059:14340650193004520] CALL: open-ils.cstore open-ils.cstore.json_query.atomic {"from":["actor.org_unit_ancestor_setting","opac.reviews_and_more_new_tab",""]}
open-ils.cstore 2015-06-11 20:45:12 [ERR :29028:oils_sql.c:5797:14340650193004520] open-ils.cstore: Error with query [SELECT * FROM actor.org_unit_ancestor_setting( 'opac.reviews_and_more_new_tab', '' ) AS "actor.org_unit_ancestor_setting" ;]: 3484946 3484946: ERROR: invalid input syntax for integer: ""
LINE 1: ...ncestor_setting( 'opac.reviews_and_more_new_tab', '' ) AS "a...

Adding the same Content Cafe credentials in the Apache config for a Sandbox running a clean master build did not result in this error.

Changed in evergreen:
assignee: Jim Keenan (jkeenan) → nobody
tags: added: needsrepatch
removed: pullrequest
Revision history for this message
Jeff Davis (jdavis-sitka) wrote :

In the original commit there was a reference in table.tt2 to a nonexistent variable, ctx.ws_ou. I've corrected that to ctx.user.ws_ou and pushed the fixed commit to a new branch based on the current master branch:

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/jeffdavis/lp1431055-content-cafe-opens-in-new-tab

tags: added: pullrequest
removed: needsrepatch
Christine Burns (christine-burns)
Changed in evergreen:
assignee: nobody → Christine Burns (christine-burns)
assignee: Christine Burns (christine-burns) → nobody
Revision history for this message
Jeff Davis (jdavis-sitka) wrote :

Looking at the commit with fresh eyes, it should work but needs a bit of cleanup before being committed to master.

tags: removed: pullrequest
Changed in evergreen:
assignee: nobody → Jeff Davis (jdavis-sitka)
Jane Sandberg (sandbergja)
tags: added: addedcontent
Stephanie Leary (stephanieleary)
tags: added: ux-links
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.