Evergreen

Closed Dates Editor does not display the "All Day" verbiage

Bug #1432753 reported by Dale Rigney
10
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Evergreen
Fix Released
Undecided
Unassigned
Evergreen 2.12-beta
2.10
Fix Released
Undecided
Unassigned
Evergreen 2.10.9
2.11
Fix Released
Undecided
Unassigned
Evergreen 2.11.2

Bug Description

The Closed Date Editor in 2.5 would show a date that was closed from 00:00 to 23:59 hours with the words "All Day" . For example in 2.5.2 a singe day closed would show as "All Day 2015-03-19" in 2.7.3 the editor will display as "From 2015-03-19 at 00:00 through 2015-03-19 at 23:59".

Terran McCanna (tmccanna)
tags: added: client wishlist
Changed in evergreen:
status: New → Confirmed
Revision history for this message
Dan Scott (denials) wrote :

This appears to be because the sh and eh variables are now showing minute granularity, but the comparison in the following line in Open-ILS/xul/staff_client/server/admin/closed_dates.js uses granularity to the second:

    if( sh == '00:00:00' && eh == '23:59:59' ) {

Revision history for this message
Dan Scott (denials) wrote :

I've created branch user/dbs/lp1432753_all_day_closed_dates at http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/dbs/lp1432753_all_day_closed_dates to address this bug.

tags: added: pullrequest
Changed in evergreen:
milestone: none → 2.next
Revision history for this message
Dan Scott (denials) wrote :

Note that this branch does not address the "off-by-one-day" error described in https://bugs.launchpad.net/evergreen/+bug/1594937 but at least we get rid of the "00:00 to 23:59" confusing bits of UI...

Revision history for this message
Chris Sharp (chrissharp123) wrote :

Dan's fix does the trick. Signoff branch here: http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/csharp/lp1432753_all_day_closed_dates

tags: added: signedoff
Revision history for this message
Dan Scott (denials) wrote :

Thanks for testing and signing off, Chris! Pushed to master, rel_2_11, and rel_2_10.

Changed in evergreen:
status: Confirmed → Fix Committed
Evergreen Bug Maintenance (bugmaster)
Changed in evergreen:
milestone: 2.next → 2.12-beta
Evergreen Bug Maintenance (bugmaster)
Changed in evergreen:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.