Mahara

Signal the AJAX block loader with a flag instead of empty block content

Bug #1444229 reported by Aaron Wells
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Fix Released
High
Aaron Wells
Mahara 15.04.0
15.04
Fix Released
High
Aaron Wells
Mahara 15.04.0
15.10
Fix Released
High
Aaron Wells
Mahara 15.10.0

Bug Description

When I implemented the AJAX block loader, I wrote it so that the AJAX block loader is used, if a block's content is empty. This is a rather hacky way to do it, though, because sometimes a block just has empty content. (See Bug 1443832)

We should instead have a specific way for the block to communicate to the template "Use the AJAX block loader". This can probably be a flag of some sort on the block object.

Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "master" branch: https://reviews.mahara.org/4621

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/4621
Committed: http://gitorious.org/mahara/mahara/commit/29053d1b096b03bf0adfc0820a2150461312f168
Submitter: Aaron Wells (<email address hidden>)
Branch: master

commit 29053d1b096b03bf0adfc0820a2150461312f168
Author: Aaron Wells <email address hidden>
Date: Wed Apr 15 14:38:22 2015 +1200

Explicitly tell the template to use the AJAX block loader

Bug 1444229: It was hacky to rely on the block content being empty
to signal the AJAX block loader. We should tell it to do so explicitly.

Change-Id: I9816c43c96ffed85282ac0d874fa5bfe1ca62e00

Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "15.04_STABLE" branch: https://reviews.mahara.org/4628

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/4628
Committed: http://gitorious.org/mahara/mahara/commit/c40435fa4ed1fd9a43c419024b8615d1c724e69b
Submitter: Robert Lyon (<email address hidden>)
Branch: 15.04_STABLE

commit c40435fa4ed1fd9a43c419024b8615d1c724e69b
Author: Aaron Wells <email address hidden>
Date: Wed Apr 15 14:38:22 2015 +1200

Explicitly tell the template to use the AJAX block loader

Bug 1444229: It was hacky to rely on the block content being empty
to signal the AJAX block loader. We should tell it to do so explicitly.

Change-Id: I9816c43c96ffed85282ac0d874fa5bfe1ca62e00

Robert Lyon (robertl-9)
Changed in mahara:
status: Fix Committed → Fix Released
Jinelle Foley-Barnes (jinelleb)
tags: added: no-behat-needed
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.