Allow the use of SVG files for the social media icons

Bug #1444453 reported by Gilles-Philippe Leblanc
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Fix Released
Medium
Robert Lyon
15.10
Fix Released
Undecided
Unassigned

Bug Description

Images called in the following file are not in the correct folder :
htdocs/theme/raw/artefact/file/blocktype/gallery/templates/supported.tpl
htdocs/artefact/file/blocktype/gallery/logos/

It may be moved in a correct folder to be called by $THEME->get_image_url() and then, be used in SVG format.

Tags: gallery
Revision history for this message
Aaron Wells (u-aaronw) wrote :

Right, so there are two things going on here.

1. The logo images in artefact.file/blocktype.gallery, should be stored as theme assets. But instead they are stored in a special "logos" directory under the blocktype.

2. While we're fixing that (which, in 15.04, we would have done by changing them to use $THEME->get_url()), we can also change it to use $THEME->get_image_url() to be compatible with the new 15.10 support for different image types.

Changed in mahara:
milestone: none → 15.10.0
importance: Undecided → Medium
status: New → Confirmed
tags: added: gallery
Changed in mahara:
assignee: nobody → Aaron Wells (u-aaronw)
Robert Lyon (robertl-9)
Changed in mahara:
status: Confirmed → In Progress
Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "master" branch: https://reviews.mahara.org/4716

Robert Lyon (robertl-9)
Changed in mahara:
assignee: Aaron Wells (u-aaronw) → Robert Lyon (robertl-9)
Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/4716
Committed: http://gitorious.org/mahara/mahara/commit/243aba12b297929ae8e75cc6b9ae74d4e3beec9f
Submitter: Son Nguyen (<email address hidden>)
Branch: master

commit 243aba12b297929ae8e75cc6b9ae74d4e3beec9f
Author: Robert Lyon <email address hidden>
Date: Wed Apr 29 15:33:13 2015 +1200

Bug 1444453: moving the gallery logos to under the theme

Change-Id: I06bebb5c455fd44514e7f6fb733e8bc0a1559181
Signed-off-by: Robert Lyon <email address hidden>

Robert Lyon (robertl-9)
Changed in mahara:
status: In Progress → Fix Committed
Robert Lyon (robertl-9)
Changed in mahara:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.