"Safe" is no longer needed as a separate CPAN package

Working branch making this change:

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/csharp/lp1444623-remove-Safe-CPAN-dependency-from-Makefiles

I have tested the changes with fresh VMs on Ubuntu 12.04 and 14.04. It all works there, including A/T Events, which is apparently where the Safe module is used in Evergreen.

It would be good to have some one look at this on Debian Wheezy before we push it to master.

https://packages.debian.org/wheezy/all/perl-modules/filelist shows Safe.pm is included in wheezy, is that enough of a confirmation for Wheezy?

I was really looking for someone to apply the branch, build on wheezy, and see that everything still works. Specifically, you'd want to make sure an event that creates and A/T entry still creates one and that a/t runner still works.

I am also willing to sign off on the branch as-is and push it, if others are OK with that. I imagine that if it works on Ubuntu, it should still work on wheezy, but knowing is better than assuming.

I've grabbed this for the purpose of testing on Wheezy. Mostly likely it's fine, but I'm not going to pass up Jason's invitation for more testing. :) I'll respond substantive by Monday.

Jason, I removed the cpan version of Safe.pm on a 2.7.4 Debian Wheezy install, recompiled and installed, started services and email notices still work for me.

Josh

Pushed to master, rel_2_8, and rel_2_7 based on the testing feedback by all involved. Cheers and thanks!