irqbalance should not run in container

Bug #1454273 reported by Scott Moser
22
This bug affects 3 people
Affects Status Importance Assigned to Milestone
Irqbalance
Fix Released
Undecided
Unassigned
irqbalance (Debian)
Fix Released
Unknown
irqbalance (Ubuntu)
Fix Released
Medium
Unassigned

Bug Description

irqbalance has no need to run in a container.
Its possible it has some value, i'm not completely sure, but it would seem just waste.

right now there is only an upstart job and sysvinit. i suspect that means we need a systemd job to fix.

ProblemType: Bug
DistroRelease: Ubuntu 15.04
Package: irqbalance 1.0.6-3ubuntu1
ProcVersionSignature: User Name 3.19.0-16.16-generic 3.19.3
Uname: Linux 3.19.0-16-generic x86_64
ApportVersion: 2.17.2-0ubuntu1
Architecture: amd64
Date: Tue May 12 14:23:05 2015
Ec2AMI: ami-00000375
Ec2AMIManifest: FIXME
Ec2AvailabilityZone: nova
Ec2InstanceType: m1.small
Ec2Kernel: aki-00000002
Ec2Ramdisk: ari-00000002
ProcEnviron:
 TERM=xterm
 PATH=(custom, no user)
 XDG_RUNTIME_DIR=<set>
 LANG=en_US.UTF-8
 SHELL=/bin/bash
SourcePackage: irqbalance
UpgradeStatus: No upgrade log present (probably fresh install)

Revision history for this message
Scott Moser (smoser) wrote :
Revision history for this message
Bryan Quigley (bryanquigley) wrote :

There is a systemd unit here - https://github.com/Irqbalance/irqbalance/tree/master/misc

In my tests it no longer shows up in systemd-analyze blame (saves 300ms - 500ms), but still runs, to try:
sudo cp misc/irqbalance.env /etc/default/irqbalance.env
sudo cp misc/irqbalance.service /lib/systemd/system/irqbalance.service
change path to env in service file
sudo systemctl enable irqbalance.service
reboot

Note, this doesn't actually do anything for a container, but I thought it's worth mentioning that a systemd unit exists upstream.

Revision history for this message
Launchpad Janitor (janitor) wrote :

Status changed to 'Confirmed' because the bug affects multiple users.

Changed in irqbalance (Ubuntu):
status: New → Confirmed
summary: - irqbalance should not run in container
+ irqbalance should not run in container - add systemd unit
tags: added: systemd-boot
tags: added: systemd
removed: systemd-boot
tags: added: systemd-boot
removed: systemd
Changed in irqbalance (Ubuntu):
importance: Undecided → Low
Revision history for this message
James Page (james-page) wrote : Re: irqbalance should not run in container - add systemd unit

irqbalancing should be done on the container host, not from within the container - I suspect that we just end up with lots of irqbalance processing doing nothing in containers esp when they are running unpriviledged.

Changed in irqbalance (Ubuntu):
status: Confirmed → Triaged
importance: Low → High
milestone: none → ubuntu-15.11
Revision history for this message
Bryan Quigley (bryanquigley) wrote :

Reported this upstream https://github.com/Irqbalance/irqbalance/issues/27 - couldn't link it so LP could track it though, don't know why.

Changed in irqbalance (Debian):
status: Unknown → New
Martin Pitt (pitti)
Changed in irqbalance (Ubuntu):
milestone: ubuntu-15.11 → none
Revision history for this message
Bryan Quigley (bryanquigley) wrote :

Upstream doesn't want to do this.

Revision history for this message
Martin Pitt (pitti) wrote :

Standard LXC images don't have irqbalance. Upstream says that in some corner cases you might want it in containers too, and as you have to explicitly install it I don't consider this high importance.

Changed in irqbalance (Ubuntu):
importance: High → Medium
tags: removed: systemd-boot
summary: - irqbalance should not run in container - add systemd unit
+ irqbalance should not run in container
Revision history for this message
Simon Déziel (sdeziel) wrote :

lxc images now use the -server flavor so they always have irqbalance running.

https://github.com/Irqbalance/irqbalance/issues/27#issuecomment-172279943 says that in rare cases, one might want to run irqbalance in a container. I _think_ those are sufficiently rare to not consider.

Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package irqbalance - 1.1.0-2ubuntu1

---------------
irqbalance (1.1.0-2ubuntu1) xenial; urgency=medium

  * Do not start when inside a container (LP: #1454273)

 -- Simon Deziel <email address hidden> Mon, 11 Apr 2016 16:22:21 +0000

Changed in irqbalance (Ubuntu):
status: Triaged → Fix Released
Changed in irqbalance (Debian):
status: New → Fix Released
Revision history for this message
Christian Ehrhardt  (paelzer) wrote :

FYI - this change for systemd has now been accepted upstream.
It is not yet in Debian, but once we merge again this likely can be dropped.
We don't (have to) care for sysv/upstart anymore in the new context and systemd is fixed then.
Current merge at bug 1712256.

Revision history for this message
Bryan Quigley (bryanquigley) wrote :
Changed in irqbalance:
status: New → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.