Mir

[regression] Lost API for creating freestyle surfaces

Bug #1457987 reported by William Hua
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mir
Fix Released
Medium
Alan Griffiths
Mir 0.14.0
mir (Ubuntu)
Fix Released
Undecided
Unassigned

Bug Description

mir_surface_set_type() is deprecated, so there's no way to create freestyle surfaces any more.

Tags: regression

Related branches

lp:~alan-griffiths/mir/fix-1457987
PS Jenkins bot (community): Approve (continuous-integration)
Alberto Aguirre (community): Approve
Chris Halse Rogers: Approve
Diff: 334 lines (+213/-3)
6 files modified
examples/server_example_canonical_window_manager.cpp (+17/-0)
include/client/mir_toolkit/mir_surface.h (+45/-0)
src/client/mir_surface_api.cpp (+33/-2)
src/client/symbols.map (+3/-0)
src/server/shell/canonical_window_manager.cpp (+17/-0)
tests/acceptance-tests/test_surface_placement.cpp (+98/-1)
lp:ubuntu/wily-proposed/mir
Alan Griffiths (alan-griffiths)
Changed in mir:
status: New → In Progress
assignee: nobody → Alan Griffiths (alan-griffiths)
Revision history for this message
Alan Griffiths (alan-griffiths) wrote :

There ought to be mir_connection_create_surface_spec_for_XXX functions covering all the surface types.

$ grep mir_connection_create_spec_for_ include/client/mir_toolkit/mir_surface.hMirSurfaceSpec* mir_connection_create_spec_for_normal_surface(MirConnection* connection,
mir_connection_create_spec_for_menu(MirConnection* connection,
mir_connection_create_spec_for_tooltip(MirConnection* connection,
mir_connection_create_spec_for_modal_dialog(MirConnection* connection,
mir_connection_create_spec_for_dialog(MirConnection* connection,
mir_connection_create_spec_for_changes(MirConnection* connection);
MirSurfaceSpec* mir_connection_create_spec_for_input_method(MirConnection* connection,

 vs

    mir_surface_type_normal, /**< AKA "regular" */
    mir_surface_type_utility, /**< AKA "floating" */
    mir_surface_type_dialog,
    mir_surface_type_overlay, /**< \deprecated Use "gloss" instead. */
    mir_surface_type_gloss = mir_surface_type_overlay,
    mir_surface_type_freestyle,
    mir_surface_type_popover, /**< \deprecated Choose "menu" or "tip" */
    mir_surface_type_menu = mir_surface_type_popover,
    mir_surface_type_inputmethod, /**< AKA "OSK" or handwriting etc. */
    mir_surface_type_satellite, /**< AKA "toolbox"/"toolbar" */
    mir_surface_type_tip, /**< AKA "tooltip" */

So we're missing

   mir_connection_create_spec_for_utility,
mir_connection_create_spec_for__gloss = mir_surface_type_overlay,
    mir_surface_type_freestyle,
    mir_surface_type_satellite,
    mir_surface_type_tip,

Revision history for this message
Alan Griffiths (alan-griffiths) wrote :

Committed that comment accidentally.

So we're missing

   mir_connection_create_spec_for_utility,
   mir_connection_create_spec_for_gloss = mir_surface_type_overlay,
   mir_connection_create_spec_for_freestyle,
   mir_connection_create_spec_for_satellite,
    mir_connection_create_spec_for_tip,

Daniel van Vugt (vanvugt)
Changed in mir:
importance: Undecided → Medium
summary: - Missing API for creating freestyle surfaces
+ [regression] No API for creating freestyle surfaces
tags: added: regression
Changed in mir:
milestone: none → 0.14.0
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote : Re: [regression] No API for creating freestyle surfaces

Fix committed into lp:mir at revision None, scheduled for release in mir, milestone 0.14.0

Changed in mir:
status: In Progress → Fix Committed
Daniel van Vugt (vanvugt)
summary: - [regression] No API for creating freestyle surfaces
+ [regression] Lost API for creating freestyle surfaces
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package mir - 0.14.0+15.10.20150722-0ubuntu1

---------------
mir (0.14.0+15.10.20150722-0ubuntu1) wily; urgency=medium

  [ Andreas Pokorny ]
  * Fix missing ABI renaming in Mirplatform
  * Bump Mirserver platform graphics to 3
  * Fix mirprotobuf ABI break

  [ CI Train Bot ]
  * New rebuild forced.

 -- CI Train Bot <email address hidden> Wed, 22 Jul 2015 18:01:49 +0000

Changed in mir (Ubuntu):
status: New → Fix Released
Daniel van Vugt (vanvugt)
Changed in mir:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.