patch - fix crash with long one-line XML documents
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| gtksourceview2 (Ubuntu) |
Fix Released
|
Undecided
|
Unassigned | ||
| Precise |
Fix Released
|
Undecided
|
Unassigned | ||
| Trusty |
Fix Released
|
Undecided
|
Unassigned | ||
| Utopic |
Fix Released
|
Undecided
|
Unassigned | ||
| Vivid |
Fix Released
|
Undecided
|
Unassigned | ||
| Wily |
Fix Released
|
Undecided
|
Unassigned | ||
Bug Description
[Impact]
When editing a long one-line document with some markup (e.g. XML) with Pluma (or any other editor using gtksourceview2), you cannot delete a selected portion of text because the editor will crash.
This has been reported upstream and fixed in [1], but the commit never made it to GTK+2 version of gtksourceview.
So, I propose fixing it in current stable Ubuntu releases with the patch which fixes the crash for good.
The debdiffs for every stable release are in the attachments below.
[Test Case]
Steps to reproduce:
1. Open a long one-line XML document (e.g. [2]) with Pluma. Any other editor using gtksourceview2 will also fit I think.
2. Select a portion of text.
3. Press Backspace (or Delete) key.
4. Pluma crashes. The full backtrace is at [3].
If you're running Pluma from the command-line, you'll notice a warning:
GtkSourceView-
That's the key. The library tries to invalidate the region when text is deleted and the engine is disabled (i.e. syntax highlighting is off).
[Regression Potential]
After several months of testing the patch in Debian Jessie, I haven't noticed any regressions.
[1] https:/
[2] http://
[3] http://
| Vlad Orlov (monsta) wrote | #1 |
| Vlad Orlov (monsta) wrote | #2 |
| Vlad Orlov (monsta) wrote | #3 |
| Vlad Orlov (monsta) wrote | #4 |
| Changed in gtksourceview2 (Debian): | |
| status: | Unknown → Confirmed |
| Ubuntu Foundations Team Bug Bot (crichton) wrote | #5 |
| tags: | added: patch |
| Changed in gtksourceview2 (Ubuntu Wily): | |
| status: | New → Fix Committed |
| Marc Deslauriers (mdeslaur) wrote | #6 |
| Changed in gtksourceview2 (Ubuntu Precise): | |
| status: | New → In Progress |
| Changed in gtksourceview2 (Ubuntu Trusty): | |
| status: | New → In Progress |
| Changed in gtksourceview2 (Ubuntu Utopic): | |
| status: | New → In Progress |
| Changed in gtksourceview2 (Ubuntu Vivid): | |
| status: | New → In Progress |
| Launchpad Janitor (janitor) wrote | #7 |
| Changed in gtksourceview2 (Ubuntu Wily): | |
| status: | Fix Committed → Fix Released |
| Chris J Arges (arges) wrote Please test proposed package | #8 |
| Changed in gtksourceview2 (Ubuntu Precise): | |
| status: | In Progress → Fix Committed |
| tags: | added: verification-needed |
| Chris J Arges (arges) wrote | #9 |
| Vlad Orlov (monsta) wrote | #10 |
| Marc Deslauriers (mdeslaur) wrote | #11 |
| Chris J Arges (arges) wrote | #12 |
| Changed in gtksourceview2 (Ubuntu Utopic): | |
| status: | In Progress → Fix Committed |
| Chris J Arges (arges) wrote | #13 |
| Changed in gtksourceview2 (Ubuntu Vivid): | |
| status: | In Progress → Fix Committed |
| Changed in gtksourceview2 (Ubuntu Trusty): | |
| status: | In Progress → Fix Committed |
| Chris J Arges (arges) wrote | #14 |
| Vlad Orlov (monsta) wrote | #15 |
| tags: |
added: verification-done removed: verification-needed |
| Brian Murray (brian-murray) wrote Update Released | #16 |
| Launchpad Janitor (janitor) wrote | #17 |
| Changed in gtksourceview2 (Ubuntu Utopic): | |
| status: | Fix Committed → Fix Released |
| Launchpad Janitor (janitor) wrote | #18 |
| Changed in gtksourceview2 (Ubuntu Trusty): | |
| status: | Fix Committed → Fix Released |
| Launchpad Janitor (janitor) wrote | #19 |
| Changed in gtksourceview2 (Ubuntu Vivid): | |
| status: | Fix Committed → Fix Released |
| Launchpad Janitor (janitor) wrote | #20 |
| Changed in gtksourceview2 (Ubuntu Precise): | |
| status: | Fix Committed → Fix Released |
| Vlad Orlov (monsta) wrote | #21 |
| no longer affects: | gtksourceview2 (Debian) |
The attachment "debdiff with the fix for Precise" seems to be a debdiff. The ubuntu-sponsors team has been subscribed to the bug report so that they can review and hopefully sponsor the debdiff. If the attachment isn't a patch, please remove the "patch" flag from the attachment, remove the "patch" tag, and if you are member of the ~ubuntu-sponsors, unsubscribe the team.
[This is an automated message performed by a Launchpad user owned by ~brian-murray, for any issue please contact him.]