PBR

PBR Ignores git://, git+ssh://, git+https:// Requirement Lines

Bug #1467683 reported by Ryan Bourgeois
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
PBR
Fix Released
Wishlist
Sachi King

Bug Description

PBR does not extract package names for requirements which begin with git://, git+ssh://, git+https:// unless they have the -e flag set. Pip is capable of handling these URL's without -e. However, with PBR omitting the -e causes the following setuptools error:

    error in setup command: 'install_requires' must be a string or list of strings containing valid project/version requirement specifiers

Some debugging indicates that the full line is being used instead of the package atom.

Changed in pbr:
assignee: nobody → Ryan Bourgeois (bluedragonx)
Changed in pbr:
status: New → In Progress
Revision history for this message
Robert Collins (lifeless) wrote :

Are you sure its the -e, and not the presence/absence of an egg name? Anyhow, assuming you're right, then yes, we should fix this - though the direction with pbr is to move to consolidating on PEP-426 expressions. We probably have some work to do to teach setuptools about that and the related URL glue stuff.

Changed in pbr:
status: In Progress → Triaged
status: Triaged → Confirmed
importance: Undecided → Wishlist
Revision history for this message
Ryan Bourgeois (bluedragonx) wrote :

It's definitely the -e. All URLs have egg names set. Furthermore I've stepped through the code. There's a PR in review that fixes the problem.

Changed in pbr:
status: Confirmed → In Progress
Changed in pbr:
assignee: Ryan Bourgeois (bluedragonx) → Sachi King (nakato)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to pbr (master)

Reviewed: https://review.openstack.org/194405
Committed: https://git.openstack.org/cgit/openstack-dev/pbr/commit/?id=31a0e97cbff495401ab7ded498b680e1f918153c
Submitter: Jenkins
Branch: master

commit 31a0e97cbff495401ab7ded498b680e1f918153c
Author: Ryan Bourgeois <email address hidden>
Date: Mon Jun 22 14:05:34 2015 -0700

    Support git://, git+ssh://, git+https:// without -e flag.

    Closes-Bug: 1467683
    Change-Id: I09163c8072ecbee5c1a24951511c75009511b6f8

Changed in pbr:
status: In Progress → Fix Committed
Revision history for this message
Davanum Srinivas (DIMS) (dims-v) wrote : Fix included in openstack-dev/pbr 1.9.0

This issue was fixed in the openstack-dev/pbr 1.9.0 release.

Sachi King (nakato)
Changed in pbr:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.