Registration form reason box not displaying on form error

Bug #1469569 reported by Robert Lyon
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Fix Released
Low
Robert Lyon
15.10
Fix Released
Undecided
Unassigned

Bug Description

On the register.php page - when you have multiple institutions that allow registration and you choose an institution the 'registration reason' box appears. But if you make a mistake in filling in the form and so get the form errors showing the registration reason field becomes hidden again. Need to alter the js so that if form loads with an institution already chosen it re shows the registration reason box (and picks the correct terms and conditions again.

Revision history for this message
Robert Lyon (robertl-9) wrote :

This becomes a problem if you alter the pieform to make that reason field required because if you don't fill in the reason field and submit the form it says you have an error but the field is hidden and you can't fill it in.

Changed in mahara:
milestone: none → 15.10.0
Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "master" branch: https://reviews.mahara.org/4904

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/4904
Committed: https://git.nzoss.org.nz/mahara/mahara/commit/7c632e6a7c6247d968a41ba9fdcce3eb90f378fb
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit 7c632e6a7c6247d968a41ba9fdcce3eb90f378fb
Author: Robert Lyon <email address hidden>
Date: Mon Jun 29 10:46:00 2015 +1200

Bug 1469569: Allow fields to show on form error page load

Change-Id: I4577eda5faae520fa022b5a926b80f9785892bc0
Signed-off-by: Robert Lyon <email address hidden>

Robert Lyon (robertl-9)
Changed in mahara:
status: In Progress → Fix Committed
Robert Lyon (robertl-9)
Changed in mahara:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.