dhcp service is unavailable if we delete dhcp port

Bug #1469615 reported by shihanzhang
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
neutron
Fix Released
Undecided
shihanzhang

Bug Description

if we delete the dhcp port, the dhcp service for corresponding network is unavailable, because dhcp port is deleted from neutron-server, but the TAP device on network node is not deleted, and the tag for this TAP is dead vlan 4095, and the dhcp service can' t be recovered.

reproduce steps:
1. create network, subnet
2. delete the dhcp port in this network

I found the TAP device on network node was not deleted, but its tag is 4095

Changed in neutron:
assignee: nobody → shihanzhang (shihanzhang)
zhaobo (zhaobo6)
description: updated
Revision history for this message
Kevin Benton (kevinbenton) wrote :

This should be a fairly simple change:

diff --git a/neutron/agent/dhcp/agent.py b/neutron/agent/dhcp/agent.py
index 6b5ac5a..1737abc 100644
--- a/neutron/agent/dhcp/agent.py
+++ b/neutron/agent/dhcp/agent.py
@@ -350,7 +350,10 @@ class DhcpAgent(manager.Manager):
         if port:
             network = self.cache.get_network_by_id(port.network_id)
             self.cache.remove_port(port)
- self.call_driver('reload_allocations', network)
+ if self._is_port_on_this_agent(port):
+ self.disable_dhcp_helper(port.network_id)
+ else:
+ self.call_driver('reload_allocations', network)

     def enable_isolated_metadata_proxy(self, network):

Revision history for this message
shihanzhang (shihanzhang) wrote :

hi kevin, your suggestion is very good, it can solve this bug, but I think we should also provide a method to recover the dhcp service, my idea is to create a port with device_id 'reserved_dhcp_port', when dhcp agent receive this creation notification, it refresh_dhcp_helper, what do you think?

Changed in neutron:
status: New → In Progress
Revision history for this message
Hirofumi Ichihara (ichihara-hirofumi) wrote :

If users want to disable dhcp service, we should provide another solution different from port-deleting.

Revision history for this message
yalei wang (yalei-wang) wrote :

agree with Ichihara.

Revision history for this message
shihanzhang (shihanzhang) wrote :

now neutron API support to delete dhcp port, if user delete dhcp port by mistake, the dhcp service for this network will be unavailable and it can't recover!

Revision history for this message
Hirofumi Ichihara (ichihara-hirofumi) wrote :

Yes. I agree with the opinion. You might want to provide the recover solution only.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on neutron (master)

Change abandoned by shihanzhang (<email address hidden>) on branch: master
Review: https://review.openstack.org/196927
Reason: I agree with Aaron Rosen, it is better to prevent to delete dhcp ports via API, please review new patch# https://review.openstack.org/#/c/198949/

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Change abandoned by shihanzhang (<email address hidden>) on branch: master
Review: https://review.openstack.org/198949
Reason: Through reviewers discussions, it is better to use this method rather than prevent deleting dhcp port via the API

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (master)

Reviewed: https://review.openstack.org/196927
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=9d800021293d8564ced1c071b6415d9a97b3ef49
Submitter: Jenkins
Branch: master

commit 9d800021293d8564ced1c071b6415d9a97b3ef49
Author: shihanzhang <email address hidden>
Date: Tue Jun 30 10:14:19 2015 +0800

    Unplug the VIF if dhcp port is deleted

    if user delete the dhcp port, dhcp-agent should unplug
    the VIF for this dhcp port, then the driver do
    'reload_allocations' will raise a exception, dhcp-agent
    resync for this network and re-create dhcp port.

    Change-Id: I40b85033d075562c43ce4d0e68296211b3241197
    Closes-bug: #1469615

Changed in neutron:
status: In Progress → Fix Committed
Changed in neutron:
milestone: none → liberty-2
status: Fix Committed → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (feature/pecan)

Fix proposed to branch: feature/pecan
Review: https://review.openstack.org/207903

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (feature/pecan)
Download full text (70.7 KiB)

Reviewed: https://review.openstack.org/207903
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=9badcd249dab2d3330f0cd608496b59c9f44499a
Submitter: Jenkins
Branch: feature/pecan

commit 991ea00e6c115343eabecc62e86072175823f81f
Author: Moshe Levi <email address hidden>
Date: Thu Jul 30 12:04:15 2015 +0300

    SR-IOV: Fix SR-IOV agent to run ip link commands as root

    Commit https://review.openstack.org/#/c/155523/
    remove the remaining root_helper args, but didn't
    update the SR-IOV agent to execute them as root.

    This patch updates the agent to execute ip link commands
    as root and pass options argument as a list in the
    self._as_root method.

    Closes-Bug: #1479694
    Change-Id: I53cafd61845a69fae3a759fb7526950d655ffa20

commit 5b3bacedf6c014815bef03c2e821b5eb8ef92dcb
Author: Saksham Varma <email address hidden>
Date: Thu Jul 23 22:46:23 2015 -0700

    Moved out cisco n1kv mech driver and db models

    Moving out Cisco N1Kv database models and the mech driver
    to the openstack/networking-cisco repo as part of the second
    phase vendor-core decomposition

    Partial-Bug: #1479123
    Partial-implements: blueprint core-vendor-decomposition

    Change-Id: I65a704b238d8cbe2951a6912fa4f1e8518c6f412

commit 65ac8cd0a80548e115b8ec1d4cfd47a94422fddf
Author: OpenStack Proposal Bot <email address hidden>
Date: Wed Jul 29 20:44:01 2015 +0000

    Updated from global requirements

    Change-Id: I3a884a73d51df0f93b5cc88b3e3250d81bb1f455

commit f0e8356d04d04600c072a1c0f0bdf274ff19ab8c
Author: sridhargaddam <email address hidden>
Date: Mon Jul 27 03:46:48 2015 +0000

    Update dhcp agent cache for network:dhcp ports

    When a network with a dhcp_enabled subnet is scheduled on a dhcp
    agent, dhcp driver creates the network:dhcp port for the subnet.
    However, the port info is not updated in dhcp agents internal cache.
    Subsequently if the user deletes the network:dhcp port, the port is
    properly deleted on the server side (i.e., in the database) and when
    the port_delete_end notification is sent to the dhcp agent, it simply
    ignores it as the port entry would be missing in the cache. This patch
    fixes this issue by updating the dhcp agents cache when dhcp driver
    creates the network:dhcp port for the subnets.

    Closes-Bug: #1478426
    Change-Id: I69f5834dd964a4320c606c4e0aa2cdba70416943

commit cb60d0bb4e0cc0cba68f59fdf5f4e89d6ec52950
Author: changzhi <email address hidden>
Date: Thu Jul 16 10:14:16 2015 +0800

    Keep dns nameserver order consistency

    Currently, there is no dns servers prioritization for subnets
    for Neutron.

    Generally speaking, it is useful to keep the order of dns
    nameservers consistent. Add a new column named 'order' in table
    'dnsnameservers' and add nameserver into DB one by one.

    Closes-Bug: #1218629
    Implements: blueprint keep-dns-nameserver-orderconsistency
    Change-Id: Id937aea411397d39370368a4eb45be26c4eefa9e

commit b39e1469e824bc8bc79e1ecafa98825a94811c0b
Author: Salvatore Orlando <email address hidden>
Date: Tue Jun 23 04:54:2...

tags: added: in-feature-pecan
Thierry Carrez (ttx)
Changed in neutron:
milestone: liberty-2 → 7.0.0
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.