Ubuntu
mousepad package

Mousepad crashes when setting tab width > 32

Bug #1472690 reported by Alistair Buxton on 2015-07-08

This bug affects 3 people

Affects		Status	Importance	Assigned to	Milestone
	Mousepad	Fix Released	Medium	xfce-bugs #12055
	mousepad (Ubuntu)	Fix Released	Medium	SYEDFAYAZ MUJAWAR

Bug Description

The reproduce:

1. Open mousepad
2. Open settings
3. Go to "editor" section
4. Set tab width to 33
5. Close settings

Mousepad will now crash with an assertion error.

This is caused due to a mismatch between the gschema and the glade UI file. The schema specifies a maximum tab width of 32 but the UI specifies a maximum of 128. These should be brought into alignment.

http://git.xfce.org/apps/mousepad/tree/mousepad/org.xfce.mousepad.gschema.xml#n108

http://git.xfce.org/apps/mousepad/tree/mousepad/mousepad-prefs-dialog.glade#n46

In addition mousepad should probably not crash if there is a settings mismatch like this.

ProblemType: Crash
DistroRelease: Ubuntu 15.04
Package: mousepad 0.4.0-0ubuntu1
ProcVersionSignature: Ubuntu 3.19.0-22.22-generic 3.19.8-ckt1
Uname: Linux 3.19.0-22-generic i686
ApportVersion: 2.17.2-0ubuntu1.1
Architecture: i386
CurrentDesktop: XFCE
Date: Wed Jul 8 16:56:57 2015
ExecutablePath: /usr/bin/mousepad
InstallationDate: Installed on 2015-03-03 (127 days ago)
InstallationMedia: Xubuntu 15.04 "Vivid Vervet" - Alpha i386 (20150303)
ProcCmdline: mousepad
Signal: 6
SourcePackage: mousepad
UpgradeStatus: No upgrade log present (probably fresh install)
UserGroups: adm cdrom dip lpadmin plugdev sambashare sudo

Tags:

Revision history for this message

Alistair Buxton (a-j-buxton) wrote on 2015-07-08:

Dependencies.txt Edit (6.3 KiB, text/plain; charset="utf-8")
Disassembly.txt Edit (532 bytes, text/plain; charset="utf-8")
JournalErrors.txt Edit (6.9 KiB, text/plain; charset="utf-8")
ProcEnviron.txt Edit (106 bytes, text/plain; charset="utf-8")
ProcMaps.txt Edit (28.7 KiB, text/plain; charset="utf-8")
ProcStatus.txt Edit (814 bytes, text/plain; charset="utf-8")
Registers.txt Edit (19.8 KiB, text/plain; charset="utf-8")
ThreadStacktrace.txt Edit (23.4 KiB, text/plain; charset="utf-8")

information type:	Private → Public
tags:	removed: need-i386-retrace

Revision history for this message

Launchpad Janitor (janitor) wrote on 2015-07-08:

Status changed to 'Confirmed' because the bug affects multiple users.

Changed in mousepad (Ubuntu):
status:	New → Confirmed

Revision history for this message

In Xfce Bugzilla #12055, Alistair Buxton (a-j-buxton) wrote on 2015-07-08:

Created attachment 6378
Patch to fix the mismatch

Due to a mismatch between gsettings schema and UI glade.

(mousepad:27389): GLib-GIO-CRITICAL **: GObject property 'value' on a 'GtkSpinButton' object is out of schema-specified range for key 'tab-width' of 'org.xfce.mousepad.preferences.view': 33
**
GLib-GIO:ERROR:/build/buildd/glib2.0-2.40.2/./gio/gsettings.c:2389:g_settings_binding_free: assertion failed: (!binding->running)

Downstream bug https://bugs.launchpad.net/ubuntu/+source/mousepad/+bug/1472690

Patch attached.

Should mousepad really crash on errors like this? Shouldn't it be a warning, rather than an assert/exit?

Bug Watch Updater (bug-watch-updater) on 2015-07-08

Changed in mousepad:
importance:	Unknown → Medium
status:	Unknown → Confirmed

Revision history for this message

In Xfce Bugzilla #12055, G-matt-8 (g-matt-8) wrote on 2015-07-08:

Thanks for reporting and fixing.

See: http://git.xfce.org/apps/mousepad/commit/?id=15f4e5a47bd85d2cd831f65d6a66e548ad4d5708

Bug Watch Updater (bug-watch-updater) on 2015-07-10

Changed in mousepad:
status:	Confirmed → Fix Released

Alberto Salvia Novella (es20490446e) on 2015-07-21

Changed in mousepad (Ubuntu):
importance:	Undecided → Medium

Revision history for this message

Jackson Doak (noskcaj) wrote on 2015-10-29:

debdiff with patch Edit (7.3 KiB, text/plain)

debdiff adding the fix to this, as well as merging from debian, attached.

Revision history for this message

Sebastien Bacher (seb128) wrote on 2015-11-10:

thanks

Changed in mousepad (Ubuntu):
status:	Confirmed → Fix Committed

Revision history for this message

Jackson Doak (noskcaj) wrote on 2015-11-11:

It appears that this is only half the fix, the .ui file needs regenerating

Changed in mousepad (Ubuntu):
status:	Fix Committed → Triaged

SYEDFAYAZ MUJAWAR (syedfayaz28) on 2015-11-22

Changed in mousepad (Ubuntu):
assignee:	nobody → SYEDFAYAZ MUJAWAR (syedfayaz28)

SYEDFAYAZ MUJAWAR (syedfayaz28) on 2015-11-26

Changed in mousepad (Ubuntu):
status:	Triaged → Confirmed

Revision history for this message

Jackson Doak (noskcaj) wrote on 2015-11-26:

Can you please add a reason if you're going to change this from triaged to only confirmed?

Changed in mousepad (Ubuntu):
status:	Confirmed → Triaged

Revision history for this message

Launchpad Janitor (janitor) wrote on 2016-06-30:

This bug was fixed in the package mousepad - 0.4.0-4ubuntu1

---------------
mousepad (0.4.0-4ubuntu1) devel; urgency=medium

  * Merge from Debian unstable. Remaining changes:
    - debian/control, debian/rules:
      + Switch to gtk3.
    - git-width-mismatch.patch: stop a tab width related crash. LP: #1472690
  * d/p/git-width-mismatch.patch:
    - Update to patch the generated .h file rather than upstream glade file.

-- Unit 193 <email address hidden> Mon, 13 Jun 2016 05:45:59 +0000