Mir

[regression] Mir is holding buffers much longer than it used to.

Bug #1480164 reported by Daniel van Vugt
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mir
Fix Released
Medium
Daniel van Vugt
mir (Ubuntu)
Fix Released
Medium
Unassigned

Bug Description

Mir is holding buffers much longer than it used to. You can see from this bespoke logging that it's now holding each buffer from the client for a full frame even though the compositor itself only holds it for less than a millisecond (the render time):

[1438332770.923332] mirserver: 0x7f66bc0030b0: compositor acquired 0x7f66bc0039f0
[1438332770.923444] mirserver: 0x7f66bc0030b0: compositor release1 0x7f66bc0039f0
[1438332770.923454] mirserver: 0x7f66bc0030b0: compositor release2 0x7f66bc0039f0
[1438332770.939927] mirserver: 0x7f66bc0030b0: compositor release3 0x7f66bc0039f0
[1438332770.939966] mirserver: 0x7f66bc0030b0: compositor release4 0x7f66bc0039f0
[1438332770.940011] mirserver: 0x7f66bc0030b0: compositor acquired 0x7f66bc006990
[1438332770.940117] mirserver: 0x7f66bc0030b0: compositor release1 0x7f66bc006990
[1438332770.940127] mirserver: 0x7f66bc0030b0: compositor release2 0x7f66bc006990
[1438332770.956487] mirserver: 0x7f66bc0030b0: compositor release3 0x7f66bc006990
[1438332770.956507] mirserver: 0x7f66bc0030b0: compositor release4 0x7f66bc006990

The issue appears to have been introduced in:
------------------------------------------------------------
revno: 2323 [merge]
author: Daniel van Vugt <email address hidden>
committer: Tarmac
branch nick: development-branch
timestamp: Tue 2015-02-17 08:19:29 +0000
message:
  Fix the multi-monitor frame sync logic to support high speed
  compositors (tm) which only need to hold buffers very briefly
  (introduced in r2183). (LP: #1420678)

  Both the multi-monitor frame sync logic and the optimization of r2183
  behave correctly independently. It's only when combined that they start
  to interfere with each other. But we'd very much like to keep both. Fixes: https://bugs.launchpad.net/bugs/1420678.

  Approved by Chris Halse Rogers, PS Jenkins bot, Alan Griffiths.
------------------------------------------------------------

Related branches

Revision history for this message
Daniel van Vugt (vanvugt) wrote :

Where the logging was inserted.

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

Fix committed into lp:mir at revision 2862, scheduled for release in mir, milestone 0.16.0

Changed in mir:
status: In Progress → Fix Committed
Revision history for this message
Daniel van Vugt (vanvugt) wrote :

Fix reverted in r2868 due to bug 1487197

Changed in mir:
status: Fix Committed → In Progress
Changed in mir:
status: In Progress → Fix Committed
Changed in mir:
status: Fix Committed → Fix Released
Revision history for this message
Daniel van Vugt (vanvugt) wrote :

mir (0.16.0+15.10.20150921.1-0ubuntu1) wily; urgency=medium

Changed in mir (Ubuntu):
importance: Undecided → Medium
status: New → Fix Released
Revision history for this message
Mir CI Bot (mir-ci-bot) wrote :

Fix committed into lp:mir at revision None, scheduled for release in mir, milestone 0.21.0

Changed in mir:
status: Fix Released → Fix Committed
Changed in mir:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.