Ubuntu
catfish package

Catfish will lock up if 'locate' is not installed

Bug #1482919 reported by apport hater on 2015-08-08

This bug affects 1 person

Affects		Status	Importance	Assigned to	Milestone
	Catfish	Fix Released	Undecided	Sean Davis	Catfish 1.3.1
	catfish (Ubuntu)	Fix Released	Undecided	Unassigned

Bug Description

When catfish is installed without locate it does not work.
Instead it prints a backtrace about not being able to start locate and locks up.

If I edit locate out of the backend list, it proceeds to use the "walk" backend which works correctly.
catfish/CatfishSearchEngine.py:72 - just deleted 'locate' from the default backed list.

Somehow the exception from self.process = subprocess.Popen locks up the catfish "engine"
into thinking the backed is still not finished running.

Tags:

Revision history for this message

apport hater (g112) wrote on 2015-08-08:

Would it be enough to add a try-catch around the subprocess.Popen call in
CatfishSearchMethodExternal:run(self, keywords, path, regex=False) ?

And just "return false" from the error?

Revision history for this message

apport hater (g112) wrote on 2015-08-08:

untested addition of try-catch Edit (1.1 KiB, text/plain)

Revision history for this message

Ubuntu Foundations Team Bug Bot (crichton) wrote on 2015-08-09:

The attachment "untested addition of try-catch" seems to be a patch. If it isn't, please remove the "patch" flag from the attachment, remove the "patch" tag, and if you are a member of the ~ubuntu-reviewers, unsubscribe the team.

[This is an automated message performed by a Launchpad user owned by ~brian-murray, for any issues please contact him.]

tags:

added: patch

Revision history for this message

Sean Davis (bluesabre) wrote on 2015-09-08:

Fixed with revision https://bazaar.launchpad.net/~catfish-search/catfish-search/trunk/revision/385

Instead of try/catch, disable the locate engine if the binary cannot be found.

Changed in catfish-search:
status:	New → Fix Committed

Sean Davis (bluesabre) on 2015-09-08

Changed in catfish-search:
milestone:	none → 1.3.1
assignee:	nobody → Sean Davis (bluesabre)

Sean Davis (bluesabre) on 2015-09-09

Changed in catfish-search:
status:	Fix Committed → Fix Released

Revision history for this message

Launchpad Janitor (janitor) wrote on 2015-09-09:

This bug was fixed in the package catfish - 1.3.1-0ubuntu1

---------------
catfish (1.3.1-0ubuntu1) wily; urgency=medium

  * New upstream bugfix release
    - Fix: authentication in livesession accepts any
      value as password (LP: #1395720)
    - Fix: Catfish will lock up if 'locate' is not
      installed (LP: #1482919)
    - Fix: Catfish does not find files whose size
      exceeds 2GB (LP: #1442559)

-- Sean Davis <email address hidden> Tue, 08 Sep 2015 20:54:13 -0400