Wrong comment is deleted

Looking further into this:

The $_POST data has the correct comment id but the $values data being passed to delete_comment_submit() contains the value for the first delete button - so need to find out why the submitted value ($_POST) is not being assigned to the element on post submission

Looking even further into this problem - in 15.10 for some reason when you go to delete a comment it passes the $data to pieform process containing the first deletable comment rather than the one you are wanting to delete

Patch for "master" branch: https://reviews.mahara.org/5228

This also needs to be tested with nested comments turned on.

To replicate:

1. Create a page
2. View page in display mode
3. Place comment on page with text "Comment 1"
4. Place comment on page with text "Comment 2"
5. Click delete button for "Comment 2"

Expected result: Comment 2 gets deleted
Actual result: Comment 1 gets deleted

It happens the same with nested replies turned on. (In this case, for step 4, make "Comment 2" be a reply to "Comment 1").

Reviewed: https://reviews.mahara.org/5228
Committed: https://git.nzoss.org.nz/mahara/mahara/commit/6da147c195499b7a7538929dc712086ae51c74cf
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit 6da147c195499b7a7538929dc712086ae51c74cf
Author: Robert Lyon <email address hidden>
Date: Mon Sep 7 13:51:47 2015 +1200

Bug 1486763: Now deleting correct comment

Was a problem with the old delete button being an image and so passed
the _x value, which was then checked for.

Changed it so it checks that the submit param exists, which is more
robust

behatnotneeded : problem of finding the row that you just deleted as
all deleted rows have the same 'Comment removed by the author' text

Change-Id: Iea379badd2d364112d107977b8f53a62ac272428
Signed-off-by: Robert Lyon <email address hidden>

Patch for "master" branch: https://reviews.mahara.org/5302

Reviewed: https://reviews.mahara.org/5302
Committed: https://git.nzoss.org.nz/mahara/mahara/commit/131b9ef839f2778ccdfcccc3970609d85521f073
Submitter: Aaron Wells (<email address hidden>)
Branch: master

commit 131b9ef839f2778ccdfcccc3970609d85521f073
Author: Aaron Wells <email address hidden>
Date: Thu Sep 17 11:46:40 2015 +1200

Bug 1486763: Behat test for adding/deleting comments

Change-Id: I11d959451400c8e5e5b0e67dd397fff171df0126

Patch for "15.04_STABLE" branch: https://reviews.mahara.org/5304

Patch for "master" branch: https://reviews.mahara.org/8257

Reviewed: https://reviews.mahara.org/8257
Committed: https://git.mahara.org/mahara/mahara/commit/9f98b2d7542be8714ba60aa2f1e0e6c4402ff821
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit 9f98b2d7542be8714ba60aa2f1e0e6c4402ff821
Author: Cecilia Vela Gurovic <email address hidden>
Date: Mon Nov 6 16:04:47 2017 +1300

Bug 1729423: publish correct private comment in the list

similar to bug 1486763

behatnotneeded

Change-Id: Iaa6e337434996303208a0445099825797e65ae3e

Patch for "17.10_STABLE" branch: https://reviews.mahara.org/8269

Patch for "17.04_STABLE" branch: https://reviews.mahara.org/8270

Reviewed: https://reviews.mahara.org/8269
Committed: https://git.mahara.org/mahara/mahara/commit/4cafb30114036df3a6702f2285feff972b8bdea6
Submitter: Robert Lyon (<email address hidden>)
Branch: 17.10_STABLE

commit 4cafb30114036df3a6702f2285feff972b8bdea6
Author: Cecilia Vela Gurovic <email address hidden>
Date: Mon Nov 6 16:04:47 2017 +1300

Bug 1729423: publish correct private comment in the list

similar to bug 1486763

behatnotneeded

Change-Id: Iaa6e337434996303208a0445099825797e65ae3e
(cherry picked from commit 9f98b2d7542be8714ba60aa2f1e0e6c4402ff821)

Reviewed: https://reviews.mahara.org/8270
Committed: https://git.mahara.org/mahara/mahara/commit/79147d255633079970babc9293321d99cf347f42
Submitter: Robert Lyon (<email address hidden>)
Branch: 17.04_STABLE

commit 79147d255633079970babc9293321d99cf347f42
Author: Cecilia Vela Gurovic <email address hidden>
Date: Mon Nov 6 16:04:47 2017 +1300

Bug 1729423: publish correct private comment in the list

similar to bug 1486763

behatnotneeded

Change-Id: Iaa6e337434996303208a0445099825797e65ae3e
(cherry picked from commit 9f98b2d7542be8714ba60aa2f1e0e6c4402ff821)