gate-heat-templates-dsvm failed at validate-templates

Bug #1492942 reported by Hidekazu Nakamura
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Heat Templates
In Progress
High
Pavlo Shchelokovskyy

Bug Description

validate-templates error in gate-heat-templates-dsvm:

2015-09-07 01:14:58.203 | 2015-09-07 01:14:58.204 | + python /opt/stack/new/heat-templates/tools/validate-templates /opt/stack/new/heat-templates
2015-09-07 01:14:58.205 | 2015-09-07 01:14:58.205 | ERROR: Service nova does not have required endpoint in service catalog for the resource type AWS::EC2::Instance
2015-09-07 01:14:58.206 | 2015-09-07 01:14:58.207 | Got error validating WordPress_NoKey.yaml
2015-09-07 01:14:58.207 | 2015-09-07 01:14:58.208 | ERROR: Service nova does not have required endpoint in service catalog for the resource type AWS::EC2::Instance
2015-09-07 01:14:58.209 | 2015-09-07 01:14:58.209 | Got error validating WordPress_Single_Instance.template
2015-09-07 01:14:58.210 | 2015-09-07 01:14:58.211 | ERROR: Service nova does not have required endpoint in service catalog for the resource type AWS::EC2::EIPAssociation
2015-09-07 01:14:58.213 | 2015-09-07 01:14:58.213 | Got error validating MultiNode_DevStack.yaml
2015-09-07 01:14:58.214 | 2015-09-07 01:14:58.214 | ERROR: Service nova does not have required endpoint in service catalog for the resource type AWS::EC2::Instance
2015-09-07 01:14:58.215 | 2015-09-07 01:14:58.216 | Got error validating WordPress_Single_Instance_deb.template
2015-09-07 01:14:58.217 | 2015-09-07 01:14:58.217 | ERROR: Service nova does not have required endpoint in service catalog for the resource type AWS::EC2::Instance
........

complete messages:

http://logs.openstack.org/54/219554/2/check/gate-heat-templates-dsvm/0ff0063/console.html

Revision history for this message
Pavlo Shchelokovskyy (pshchelo) wrote :

This is due to implementation of service-based resource discovery spec, validation of templates that contain resources for OpenStack services not actually available in the cloud now fails.

Not sure what we can do here apart from registering some fake endpoints in the Keystone before starting the tests.

Changed in heat-templates:
assignee: nobody → Pavlo Shchelokovskyy (pshchelo)
Revision history for this message
Steven Hardy (shardy) wrote :

Pavlo: would an alternative to dummy endpoints be to have a global environment which replaces all resources with OS::Heat::None?

I guess that would reduce the value of the validation somewhat as we won't validate against the actual resource schema.

The alternative I guess would be a heat.conf boolean which globally disables the service availability validation?

Steven Hardy (shardy)
Changed in heat-templates:
status: New → In Progress
importance: Undecided → High
Revision history for this message
Pavlo Shchelokovskyy (pshchelo) wrote :

Steven,

I conducted a small test and it seems that after all we better have the fake endpoints.

for example, if I have no Barbican installed, and validate the following template

$cat order.yaml
heat_template_version: 2015-10-15
resources:
  order:
    type: OS::Barbican::Order
    properties:
      type: key
      wrong: spurious

using an environment that maps OS::Barbican::Order to OS::Heat::None, validation is still passing despite a wrong property is used.

IMO we should rather catch such errors/typos on the heat-template gate.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to heat-templates (master)

Fix proposed to branch: master
Review: https://review.openstack.org/252515

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Fix proposed to branch: master
Review: https://review.openstack.org/252516

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to heat-templates (master)

Reviewed: https://review.openstack.org/252515
Committed: https://git.openstack.org/cgit/openstack/heat-templates/commit/?id=6cec32ca4a7e508929ed0eab6effb54411e09313
Submitter: Jenkins
Branch: master

commit 6cec32ca4a7e508929ed0eab6effb54411e09313
Author: Pavlo Shchelokovskyy <email address hidden>
Date: Wed Dec 2 16:31:03 2015 +0000

    Create own script for running the dsvm gate

    In order to fix the gate properly we need some control over the way
    we setup the environment.

    This patch creates a `tools\post_test_hook.sh` file that for now mirrors
    the one stated in openstack-infra/project-config.

    Later the project-config will be modified to use it. After that we can
    start configuring the environment to our needs.

    Change-Id: Ib9388e7f5001d7efa35f6f16421251c9a59ad396
    Partial-Bug: #1492942

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on heat-templates (master)

Change abandoned by Pavlo Shchelokovskyy (<email address hidden>) on branch: master
Review: https://review.openstack.org/252516
Reason: not needed anymore, another implementation is inplace

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.