Mahara

Insert image with editor in full screen mode - 15.04

Bug #1494834 reported by Stéphane
10
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Mahara
Fix Released
Medium
Robert Lyon
Mahara 15.04.4

Bug Description

While editing a blog post in full screen mode, if you want to insert an image, the window that appears is bigger than screen height and there is no way to scroll down to access the image list and formattng options.

There should be a scroll bar somewhere to allow user to access the other part of the window.

Tags: fullscreen
Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "master" branch: https://reviews.mahara.org/5272

Revision history for this message
Robert Lyon (robertl-9) wrote :

The above problem looks to be for 15.04 only.

The problem here is the image browser popup doesn't "know" how high the page is when tinymce is full screen mode and so the popup just centers vertically on the viewport.

There is a slightly different problem for 15.10 (see bug #1495353)

summary: - Insert image with editor in full screen mode
+ Insert image with editor in full screen mode - 15.04
Changed in mahara:
status: New → Confirmed
milestone: none → 15.04.4
importance: Undecided → Medium
Robert Lyon (robertl-9)
Changed in mahara:
status: Confirmed → In Progress
assignee: nobody → Robert Lyon (robertl-9)
Revision history for this message
Mahara Bot (dev-mahara) wrote :

Patch for "15.04_STABLE" branch: https://reviews.mahara.org/5273

Revision history for this message
Robert Lyon (robertl-9) wrote :

Patch https://reviews.mahara.org/5272 is the wrong fix for this bug report, the one we want here is https://reviews.mahara.org/5273

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/5273
Committed: https://git.nzoss.org.nz/mahara/mahara/commit/6ecc37cc189502c7e35943dde6734031404276ea
Submitter: Son Nguyen (<email address hidden>)
Branch: 15.04_STABLE

commit 6ecc37cc189502c7e35943dde6734031404276ea
Author: Robert Lyon <email address hidden>
Date: Mon Sep 14 15:32:56 2015 +1200

Bug 1494834: image browser not scrollable in tinymce full screen mode

behatnotneeded

This is a fix for 15.04 only

Change-Id: Id8238684469e8e4b4312aecb5debc349809cb129
Signed-off-by: Robert Lyon <email address hidden>

Robert Lyon (robertl-9)
Changed in mahara:
status: In Progress → Fix Committed
Robert Lyon (robertl-9)
Changed in mahara:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.