Modules should use *::kestone::auth default values for service names from Keystone's default catalog

Bug #1506061 reported by Martin Mágr
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
puppet-cinder
Fix Released
High
Emilien Macchi
puppet-glance
Fix Released
High
Emilien Macchi
puppet-keystone
Invalid
High
Unassigned
puppet-nova
Fix Released
High
Martin Mágr

Bug Description

Modules should use *::kestone::auth default values for service names from Keystone's default catalog, so that default values of classes of other OpenStack services (one example is $nova_catalog.*_info of cinder::api [2]) would work out of the box.

[1] https://github.com/openstack/keystone/blob/master/etc/default_catalog.templates
[2] https://github.com/openstack/puppet-cinder/blob/master/manifests/api.pp#L164

Changed in puppet-nova:
assignee: nobody → Martin Mágr (mmagr)
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to puppet-cinder (master)

Fix proposed to branch: master
Review: https://review.openstack.org/234790

Changed in puppet-cinder:
assignee: nobody → Martin Mágr (mmagr)
status: New → In Progress
Changed in puppet-glance:
assignee: nobody → Martin Mágr (mmagr)
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to puppet-glance (master)

Fix proposed to branch: master
Review: https://review.openstack.org/234791

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to puppet-keystone (master)

Fix proposed to branch: master
Review: https://review.openstack.org/234798

Changed in puppet-keystone:
assignee: nobody → Martin Mágr (mmagr)
status: New → In Progress
no longer affects: puppet-openstack
Changed in puppet-cinder:
importance: Undecided → Medium
Changed in puppet-glance:
importance: Undecided → Medium
Changed in puppet-keystone:
importance: Undecided → Medium
Changed in puppet-nova:
importance: Undecided → Medium
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to puppet-cinder (master)

Reviewed: https://review.openstack.org/234790
Committed: https://git.openstack.org/cgit/openstack/puppet-cinder/commit/?id=9f811a71179d56024f4cc876743aa9510e4f6fb7
Submitter: Jenkins
Branch: master

commit 9f811a71179d56024f4cc876743aa9510e4f6fb7
Author: Martin Mágr <email address hidden>
Date: Wed Oct 14 15:35:21 2015 +0200

    Preparation for default endpoint names rename

    This patch prepares for changes of default endpoint names,
    so that they match default_catalog name [1].

    Such change is required because recent patch [2] used correct
    default values, but currently endpoint names are still created
    using invalid names by defaut. This means that using just default
    values of puppet-openstack modules some functionality could not
    work correctly (currently migration due to Cinder will look for
    'Compute Service' endpoint, but instead 'nova' endpoint is present
    in DB).

    Also it seems that OpenStack components moved to naming according
    to default catalog long time ago [3].

    [1] https://github.com/openstack/keystone/blob/master/etc/default_catalog.templates
    [2] https://review.openstack.org/#/c/219284/
    [3] https://review.openstack.org/#/c/141727/

    Change-Id: I2a4dea90a159f1049efd1f37ef026921241f51cf
    Partial-bug: #1506061

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to puppet-glance (master)

Reviewed: https://review.openstack.org/234791
Committed: https://git.openstack.org/cgit/openstack/puppet-glance/commit/?id=144622fd30eaf8c65036d14ee333423ef6af4522
Submitter: Jenkins
Branch: master

commit 144622fd30eaf8c65036d14ee333423ef6af4522
Author: Martin Mágr <email address hidden>
Date: Wed Oct 14 15:39:13 2015 +0200

    Preparation for default endpoint names rename

    This patch prepares for changes of default endpoint names,
    so that they match default_catalog name [1]

    [1] https://github.com/openstack/keystone/blob/master/etc/default_catalog.templates

    Change-Id: I0aa0be260f119f461a37199fb608a9bd0ba2263f
    Partial-bug: #1506061

Revision history for this message
Emilien Macchi (emilienm) wrote :

Just a note:

When you change the service_name parameter on an existing environment, the next Puppet apply will take care of creating new service & update endpoint, but won't take care of deleting old service.

Which means the change in Mitaka will require some manual intervention to delete the old service.
The warning was in Liberty so we consider people aware of that change in Mitaka but before changing the interface to use the new default parameter, we need to gather feedback from operators.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to puppet-glance (master)

Fix proposed to branch: master
Review: https://review.openstack.org/261317

Changed in puppet-glance:
assignee: Martin Mágr (mmagr) → Emilien Macchi (emilienm)
Changed in puppet-cinder:
importance: Medium → High
Changed in puppet-glance:
importance: Medium → High
Changed in puppet-keystone:
importance: Medium → High
Changed in puppet-nova:
importance: Medium → High
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to puppet-glance (master)

Reviewed: https://review.openstack.org/261317
Committed: https://git.openstack.org/cgit/openstack/puppet-glance/commit/?id=80faf9a017dd7f4169867fbdae021866e4e3d5b6
Submitter: Jenkins
Branch: master

commit 80faf9a017dd7f4169867fbdae021866e4e3d5b6
Author: Emilien Macchi <email address hidden>
Date: Thu Dec 24 14:22:25 2015 +0100

    Default service_name to 'Image Service'

    In Liberty, we sent a warning if service_name was not set (and auth_name
    was configured as the service name), with the goal to define the correct
    default value during Mitaka.

    This patch set the service_name parameter to 'Image Service' by default
    to match with Keystone's default catalog.

    Note: if you already run OpenStack, when you'll run Puppet after this
    change, the old service will still be present and you'll have to drop it
    manually. Though the Glance endpoint will be updated with the new
    service.

    Change-Id: I740a9ad32361e6a78277ea0667fba7f631eb64af
    Closes-bug: #1506061

Changed in puppet-glance:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to puppet-cinder (master)

Fix proposed to branch: master
Review: https://review.openstack.org/264399

Changed in puppet-cinder:
assignee: Martin Mágr (mmagr) → Emilien Macchi (emilienm)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to puppet-cinder (master)

Reviewed: https://review.openstack.org/264399
Committed: https://git.openstack.org/cgit/openstack/puppet-cinder/commit/?id=9125857f423212b008a158942e9ce9c36f6aef9d
Submitter: Jenkins
Branch: master

commit 9125857f423212b008a158942e9ce9c36f6aef9d
Author: Emilien Macchi <email address hidden>
Date: Wed Jan 6 17:59:04 2016 -0500

    Default service_name to 'Volume Service'

    In Liberty, we sent a warning if service_name was not set (and auth_name
    was configured as the service name), with the goal to define the correct
    default value during Mitaka.
    This patch set the service_name parameter to 'Volume Service' by default
    to match with Keystone's default catalog. Note: if you already run
    OpenStack, when you'll run Puppet after this change, the old service
    will still be present and you'll have to drop it manually. Though the
    Cinder endpoint will be updated with the new service.

    Change-Id: I3bfed1b91f99f4da5ba19d2b1f847346fa19beec
    Closes-bug: #1506061

Changed in puppet-cinder:
status: In Progress → Fix Released
Revision history for this message
Emilien Macchi (emilienm) wrote :

The patch in puppet-cinder broke boot from volume.
See https://review.openstack.org/#/c/266024/ - we plan to revert it.

Changed in puppet-cinder:
status: Fix Released → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to puppet-nova (master)

Reviewed: https://review.openstack.org/222120
Committed: https://git.openstack.org/cgit/openstack/puppet-nova/commit/?id=865ac0fdccff4c243e9e6d2c933d80dc1b8d3b40
Submitter: Jenkins
Branch: master

commit 865ac0fdccff4c243e9e6d2c933d80dc1b8d3b40
Author: Martin Mágr <email address hidden>
Date: Wed Oct 14 13:51:57 2015 +0200

    Preparation for default endpoint names rename

    This patch prepares for changes of default endpoint names,
    so that they match default_catalog name [1]

    [1] https://github.com/openstack/keystone/blob/master/etc/default_catalog.templates

    Partial-bug: #1506061
    Change-Id: Ie05f4ea6ed02db3d6386e2d945f806b5c6ae1566

Changed in puppet-keystone:
assignee: Martin Mágr (mmagr) → Alex Schultz (alex-schultz)
Changed in puppet-cinder:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on puppet-keystone (master)

Change abandoned by Martin Mágr (<email address hidden>) on branch: master
Review: https://review.openstack.org/234798
Reason: This seems to me like outdated patch. Let me know in case I'm wrong and should reopen it.

Revision history for this message
Tobias Urdin (tobias-urdin) wrote :

Abandoned upstream

Changed in puppet-keystone:
assignee: Alex Schultz (alex-schultz) → nobody
status: In Progress → Invalid
Changed in puppet-nova:
status: In Progress → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.