Mahara

Messages in dashboard inbox block have special chars escaped twice

Bug #1507432 reported by Robert Lyon
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Fix Released
High
Robert Lyon
Mahara 15.10.0
15.10
Fix Released
Undecided
Unassigned

Bug Description

The inbox runs the messages through the format_whitespace function, which contains a function to escape html special chars - but if you are using multirecipientnotifications plugin it also runs the messages through the format_whitespace function so things get double escaped.

Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "master" branch: https://reviews.mahara.org/5551

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/5551
Committed: https://git.nzoss.org.nz/mahara/mahara/commit/6a057322ef868e34dabfa15187aed291862c833e
Submitter: Son Nguyen (<email address hidden>)
Branch: master

commit 6a057322ef868e34dabfa15187aed291862c833e
Author: Robert Lyon <email address hidden>
Date: Mon Oct 19 16:23:50 2015 +1300

Bug 1507432: Avoid double escaping of messages

behatnotneeded

Change-Id: I2d0d838b1bb578bfc9f8ff2b778badfb09045d45
Signed-off-by: Robert Lyon <email address hidden>

Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "15.10_STABLE" branch: https://reviews.mahara.org/5564

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/5564
Committed: https://git.nzoss.org.nz/mahara/mahara/commit/fb2ecd3b70ff3defe3b95b5077ef18814ed3c5e9
Submitter: Robert Lyon (<email address hidden>)
Branch: 15.10_STABLE

commit fb2ecd3b70ff3defe3b95b5077ef18814ed3c5e9
Author: Robert Lyon <email address hidden>
Date: Mon Oct 19 16:23:50 2015 +1300

Bug 1507432: Avoid double escaping of messages

behatnotneeded

Change-Id: I2d0d838b1bb578bfc9f8ff2b778badfb09045d45
Signed-off-by: Robert Lyon <email address hidden>
(cherry picked from commit 6a057322ef868e34dabfa15187aed291862c833e)

Robert Lyon (robertl-9)
Changed in mahara:
status: In Progress → Fix Committed
Robert Lyon (robertl-9)
Changed in mahara:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.