Ubuntu
metacity package

can no longer alt-drag firefox/thunderbird windows above top of screen

Bug #1509031 reported by Andrew Skalski
10
This bug affects 1 person
Affects Status Importance Assigned to Milestone
metacity (Ubuntu)
Fix Released
Undecided
Unassigned
Xenial
Fix Released
Undecided
Unassigned
Yakkety
Fix Released
Undecided
Unassigned

Bug Description

[General information about the SRU]
* It includes fix for bug 1582687 which was already backported.
* It fixes bug 1509031, bug 1592953 and bug 1596574.
* Other commits are minor bugfixes, the full log can be seen here:
  https://git.gnome.org/browse/metacity/log/?h=3.18.5
* There is also a NEWS file, here:
  https://git.gnome.org/browse/metacity/tree/NEWS?h=3.18.5

[Impact]
Windows can not be moved above the top of screen because the coordinates system used is wrong.

[Test Case]
* Launch a non-CSD application, such as Firefox or Thunderbird;
* Try Alt-dragging it above the top of the screen.

[Regression Potential]
The fix is changing the coordinates system to the right one and should not cause any regressions.

-----------------------------------------------------------------------------

After upgrading to 15.10, I can no longer Alt-drag Firefox and Thunderbird windows above the top of the screen. When I attempt to do so, the window snaps downward along the y-axis so that the titlebar aligns with top of screen. Other applications such as gnome-terminal do not seem to be affected.

I ran git-bisect on metacity, and narrowed the regression down to this commit:

https://github.com/GNOME/metacity/commit/90b36abebdf69be0abaec4015d01e46296f6f5d6

commit 90b36abebdf69be0abaec4015d01e46296f6f5d6
Author: Alberts Muktupāvels <email address hidden>
Date: Fri Apr 3 23:30:20 2015 +0300

    window: add a meta_window_get_titlebar_rect

    Based on mutter commits:
    https://git.gnome.org/browse/mutter/commit/?id=3a0af0faaebb1af75925c70ad98e73c61e57639b
    https://git.gnome.org/browse/mutter/commit/?id=ac099343dab7b5048ce242958c454c55d1924902

ProblemType: Bug
DistroRelease: Ubuntu 15.10
Package: metacity 1:3.17.2-4ubuntu1
ProcVersionSignature: Ubuntu 4.2.0-16.19-generic 4.2.3
Uname: Linux 4.2.0-16-generic x86_64
ApportVersion: 2.19.1-0ubuntu3
Architecture: amd64
CurrentDesktop: GNOME-Flashback:Unity
Date: Thu Oct 22 13:35:02 2015
InstallationDate: Installed on 2014-09-22 (394 days ago)
InstallationMedia: Ubuntu 14.04.1 LTS "Trusty Tahr" - Release amd64 (20140722.2)
SourcePackage: metacity
UpgradeStatus: Upgraded to wily on 2015-10-22 (0 days ago)

See original description
Revision history for this message
Andrew Skalski (askalski) wrote :
Revision history for this message
Alberts Muktupāvels (muktupavels) wrote :

https://git.gnome.org/browse/metacity/commit/?id=967eebdd5bdf378e220f3856756745ea39f7415b
Can you verify that this commit fixes regression and does not introduce new regressions?

Revision history for this message
Andrew Skalski (askalski) wrote :

I tested by applying the patch against the current Ubuntu Xenial release version of the metacity package (metacity_3.18.4-0ubuntu0.3). I can confirm the patch fixes the regression (it allows me to drag my Firefox and Thunderbird windows above the top of the screen.) So far, I have encountered no new regressions.

I also tried building metacity git master, but ran into several unmet dependencies (newer versions of gtk+/glib than what I have installed), so I was unable to complete that test.

Thanks for looking into this!

Revision history for this message
Alberts Muktupāvels (muktupavels) wrote :

Testing with 3.18.4 is enough. Thanks!

Revision history for this message
Alberts Muktupāvels (muktupavels) wrote :

Dmitry, this is fixed also in gnome-3-18 branch:
https://git.gnome.org/browse/metacity/commit/?h=gnome-3-18&id=48245ac807d24194cd531d8c42d507c3173ef6e7

Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package metacity - 1:3.18.4-3ubuntu3

---------------
metacity (1:3.18.4-3ubuntu3) yakkety; urgency=medium

  * Add a patch from upstream to return titlebar rectangle in screen
    coordinates (fix_get_titlebar_rect.diff, LP: #1509031)

 -- Dmitry Shachnev <email address hidden> Thu, 23 Jun 2016 20:45:38 +0300

Changed in metacity (Ubuntu):
status: New → Fix Released
Dmitry Shachnev (mitya57)
description: updated
Dmitry Shachnev (mitya57)
description: updated
Revision history for this message
Chris J Arges (arges) wrote : Please test proposed package

Hello Andrew, or anyone else affected,

Accepted metacity into xenial-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/metacity/1:3.18.5-0ubuntu0.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-needed to verification-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

Changed in metacity (Ubuntu Xenial):
status: New → Fix Committed
tags: added: verification-needed
Revision history for this message
Andrew Skalski (askalski) wrote :

I tested metacity version 1:3.18.5-0ubuntu0.1 from xenial-proposed, and confirmed the fix works correctly and with no regressions. Firefox and Thunderbird windows can now be dragged above the top of the screen.

tags: added: verification-done
removed: verification-needed
Revision history for this message
Martin Pitt (pitti) wrote : Update Released

The verification of the Stable Release Update for metacity has completed successfully and the package has now been released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package metacity - 1:3.18.5-0ubuntu0.1

---------------
metacity (1:3.18.5-0ubuntu0.1) xenial; urgency=medium

  * New upstream bugfix release.
    - Fixes issues with windows not being destroyed after drag and drop
      (LP: #1592953).
    - Fixes issues with moving windows above top of screen (LP: #1509031).
  * Drop fix_xerror_in_free_win.diff, applied upstream.
  * Add a patch from upstream to restore window resize using titlebar
    (titlebar_resize.diff, LP: #1596574).

 -- Dmitry Shachnev <email address hidden> Tue, 28 Jun 2016 15:32:39 +0300

Changed in metacity (Ubuntu Xenial):
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.