Opt-in user setting Boolean value incorrectly saved with quotation marks
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Evergreen |
Invalid
|
Undecided
|
Unassigned |
Bug Description
Evergreen 2.8.1
OpenSRF 2.4
In our system, we have action triggers for circulation notice emails that use the following opt-in setting:
name: opac.default_
label: Receive Overdue and Courtesy Emails
datatype: bool
reg_default: true
When registering a patron in the staff client, the registration interface automatically includes a checkbox "Receive Overdue and Courtesy Emails" which is checked by default. This is the desired behavior. However, when saving a new patron record, the value for that user setting is saved in the database as '"true"' (with double quotes), instead of 'true' (no quotes). Subsequently, when OpenILS:
The solution would be to (1) save the user's opt-in setting value without double quotes, since it's a Boolean value, and/or (2) ignore quotes when checking the value during event generation.
tags: | added: cleanup patron |
I was recently looking at how the user settings were handled in the patron registration/edit form, and I'm wondering if this is still a problem?
We make use of several bool opt-in settings as described, and in the web client they are correctly stored without the quotes in 3.3.
Josh