Theme switches to default on creating an institution

Hi Sergei,

Thanks for the bug report! I was able to reproduce this same problem.

To replicate:

1. Clean install of Mahara
2. Go to "Configure Site -> "Site Options"
3. Under the "Site Settings" section, set "Theme" to something other than "Default". (It'll start off in "Raw", on a clean install.)
4. Go to "Institutions"
5. Click on "Add institution"
6. Create a new institution (it doesn't matter what settings you use)
7. Save the new institution.

Expected result: The new institution is created and nothing else on the site changes
Actual result: The new institution is created, and the site theme changes to "Default", and you see these messages in status boxes on the top of the page:

The theme "sitedefault" is missing. The theme has been set to the default theme.

Institution added successfully

The theme "" is missing. The theme has been set to the default theme.

When I say "the site theme changes to "Default"", I mean if you go back to "Administration -> Configure Site -> Site options -> Site settings -> Theme", the selection there will have changed to "Default"!

I suspect this was caused by a bug in the code we adding for migrating institutions that had themes that no longer exist, in the 15.10 upgrade. I do not know why it's changing the site theme setting, though.

Cheers,
Aaron

Patch for "master" branch: https://reviews.mahara.org/5719

Patch for "15.10_STABLE" branch: https://reviews.mahara.org/5790

Reviewed: https://reviews.mahara.org/5790
Committed: https://git.mahara.org/mahara/mahara/commit/eada86a2a6a943cc06fe5c12aefbbe98e9a948f0
Submitter: Aaron Wells (<email address hidden>)
Branch: 15.10_STABLE

commit eada86a2a6a943cc06fe5c12aefbbe98e9a948f0
Author: Robert Lyon <email address hidden>
Date: Mon Nov 16 12:15:35 2015 +1300

Bug 1514799: Ignoring theme check for new institutions

Stopping 'The theme "" is missing' message

behatnotneeded - only an info alert when not in production mode

Change-Id: Iacff81b2fd3d6ed264ca608ab00d3dcbf325231b
Signed-off-by: Robert Lyon <email address hidden>

Reviewed: https://reviews.mahara.org/5719
Committed: https://git.mahara.org/mahara/mahara/commit/adcddb41b1a9e02c20873e74a24b138e08310014
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit adcddb41b1a9e02c20873e74a24b138e08310014
Author: Robert Lyon <email address hidden>
Date: Mon Nov 16 12:15:35 2015 +1300

Bug 1514799: Ignoring theme check for new institutions

Stopping 'The theme "" is missing' message

behatnotneeded - only an info alert when not in production mode

Change-Id: Iacff81b2fd3d6ed264ca608ab00d3dcbf325231b
Signed-off-by: Robert Lyon <email address hidden>