webclient: Transfer title holds issues

Adding one more point in favor of removing the "Transfer All Title Holds" options altogether from the web client. During the xul discussion, the argument in favor of keeping the option, for those who used it, was that it provided an easy way to transfer the holds, without the additional step of going to the view holds screen.

In the web client, the transfer all holds option is only available on the View Holds interface, so there is no longer an advantage of doing the whole process from the OPAC view screen. If users want to transfer all the holds, they can easily click the select all button from this view and then select the option to transfer selected holds.

I will happily work on the branch to remove this button if we can get a general consensus to do so.

The BC Libraries Cooperative (Sitka) is in favour of removing the "Transfer All Title Holds" button from the web client. We currently have this option disabled in the xul client to prevent accidental transferring of all title holds.

Following up in question 2 of my original comment, I'll add a +1 to moving the "Mark as a Transfer Title Hold Destination" option to the Mark For button in favor of consistency. For reference, you can see a screenshot of this interface and the options currently available under the "Mark For" button at https://www.screencast.com/t/bWcH0czXHq.

 Hid "Transfer All Titles" button from the View Holds tab of the bib record

    Moved the "Mark as Title Hold Transfer Destination" button to the
    "Mark For:" dropdown to make it more consistent with other "mark" actions.

    To test
    -------
    [1] Place a hold on a title.

    [2] Choose another title. Under "Mark For" click
        "Mark as Title Hold Transfer Destination"

    [3] Return to original title on hold. Under "Actions"
        click "Transfer To Marked Title"

    [4] Confirm that hold is transferred.

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/vlewis/LP1522644-transfer-title-holds-issues

I have tested this code and consent to signing off on it with my name, Terran McCanna, and my email address, <email address hidden>.

Thank you Victoria and Terran! This looks good.

I thought there were a couple of things we could do to make this mark option more consistent with the other options available in the 'Mark For' menu. I signed off on Victoria's code, and added a commit that does the following:

1) Changes the label from "Mark As Title Hold Transfer Destination" to "Title
Hold Transfer." The 'Mark" piece is already implied in the "Mark For" button
label, and the long text was pushing the menu off the screen for some displays.

2) Makes the option behave as other Mark options. If a record is already marked,
it displays the marked Record ID in the menu. The mark is also removed when the
"Reset Record Marks" option is clicked.

3) Pushes the reset option down to the bottom of the menu and alphabetizes the
other Mark options above it.

Test Plan:
- Follow the steps outlined in Victoria's test plan.
- After marking the record for Title Hold Transfer, return to the mark menu and note that the record ID of the just-marked record displays.
- Click the 'Reset Record Marks' option. The record ID should now be removed from the Title Hold Transfer option.

Working branch at http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/kmlussier/LP1522644-transfer-title-holds-issues

Reviewed and tested. Looks good. Merged to master. Thanks all around!