[SRU] ScaleIO driver could attach wrong volume to the VM

Bug #1524989 reported by Xing Yang
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Ubuntu Cloud Archive
Fix Released
Undecided
Unassigned
Liberty
Fix Released
Undecided
Edward Hope-Morley
os-brick
Fix Released
Undecided
Xing Yang
python-os-brick (Ubuntu)
Fix Released
Medium
Unassigned
Wily
Fix Released
Medium
Edward Hope-Morley

Bug Description

When running multiple attach volume operations with multiple volumes and multiple VMs, a wrong volume could end up being attached to a VM. To fix this, connect_volume and disconnect_volume should be locked.

[Impact]

 * Backport to Ubuntu Wily/Liberty to safeguard against race conditions when performing concurrent attach/detach requests.

[Test Case]

 * Deploy Openstack Liberty
 * Boot > 1 instances and run https://gist.github.com/dosaboy/ea66eaeae945c6ed07e285b17602bb87

[Regression Potential]

 * Nothing expected

Xing Yang (xing-yang)
Changed in os-brick:
assignee: nobody → Xing Yang (xing-yang)
status: New → In Progress
description: updated
tags: added: connector emc scaleio
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to os-brick (master)

Fix proposed to branch: master
Review: https://review.openstack.org/256106

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to os-brick (master)

Reviewed: https://review.openstack.org/256106
Committed: https://git.openstack.org/cgit/openstack/os-brick/commit/?id=e6d94fe0b01eef35434cbb9ee9259c536257f6ce
Submitter: Jenkins
Branch: master

commit e6d94fe0b01eef35434cbb9ee9259c536257f6ce
Author: Xing Yang <email address hidden>
Date: Thu Dec 10 16:42:14 2015 -0500

    ScaleIO could connect wrong volume to VM

    When running multiple attach volume operations with multiple
    volumes and multiple VMs, a wrong volume could end up being
    attached to a VM. To fix this, connect_volume and disconnect_volume
    should be locked.

    Change-Id: I47e94a945938123a913aee9d52d36f8ee088955a
    Closes-Bug: #1524989

Changed in os-brick:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to os-brick (stable/liberty)

Fix proposed to branch: stable/liberty
Review: https://review.openstack.org/260729

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to os-brick (stable/liberty)

Reviewed: https://review.openstack.org/260729
Committed: https://git.openstack.org/cgit/openstack/os-brick/commit/?id=75a53354aa421bd37ee0caceaa9a3e11c58dc294
Submitter: Jenkins
Branch: stable/liberty

commit 75a53354aa421bd37ee0caceaa9a3e11c58dc294
Author: Xing Yang <email address hidden>
Date: Thu Dec 10 16:42:14 2015 -0500

    ScaleIO could connect wrong volume to VM

    When running multiple attach volume operations with multiple
    volumes and multiple VMs, a wrong volume could end up being
    attached to a VM. To fix this, connect_volume and disconnect_volume
    should be locked.

    Change-Id: I47e94a945938123a913aee9d52d36f8ee088955a
    Closes-Bug: #1524989
    (cherry picked from commit e6d94fe0b01eef35434cbb9ee9259c536257f6ce)

tags: added: in-stable-liberty
Revision history for this message
Davanum Srinivas (DIMS) (dims-v) wrote : Fix included in openstack/os-brick 0.8.0

This issue was fixed in the openstack/os-brick 0.8.0 release.

Revision history for this message
Edward Hope-Morley (hopem) wrote :
description: updated
summary: - ScaleIO driver could attach wrong volume to the VM
+ [SRU] ScaleIO driver could attach wrong volume to the VM
tags: added: sts-sru
Changed in python-os-brick (Ubuntu Wily):
assignee: nobody → Edward Hope-Morley (hopem)
Changed in python-os-brick (Ubuntu):
status: New → Invalid
Changed in cloud-archive:
status: New → Invalid
Mathew Hodson (mhodson)
Changed in python-os-brick (Ubuntu):
importance: Undecided → Medium
Changed in python-os-brick (Ubuntu Wily):
importance: Undecided → Medium
Revision history for this message
Brian Murray (brian-murray) wrote : Please test proposed package

Hello Xing, or anyone else affected,

Accepted python-os-brick into wily-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/python-os-brick/0.5.0-0ubuntu3 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-needed to verification-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

Changed in python-os-brick (Ubuntu Wily):
status: New → Fix Committed
tags: added: verification-needed
description: updated
tags: added: verification-done
removed: verification-needed
Revision history for this message
Ryan Beisner (1chb1n) wrote :

Hello Xing, or anyone else affected,

Accepted python-os-brick into liberty-proposed. The package will build now and be available in the Ubuntu Cloud Archive in a few hours, and then in the -proposed repository.

Please help us by testing this new package. To enable the -proposed repository:

  sudo add-apt-repository cloud-archive:liberty-proposed
  sudo apt-get update

Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-liberty-needed to verification-liberty-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-liberty-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

tags: added: verification-liberty-needed
tags: added: verification-liberty-done
removed: verification-liberty-needed
Changed in python-os-brick (Ubuntu):
status: Invalid → Fix Released
Changed in cloud-archive:
status: Invalid → Fix Released
Revision history for this message
Edward Hope-Morley (hopem) wrote :

I have verified that the wily-proposed package works as expected and have also verified that the trusty-liberty-proposed package works as well.

Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package python-os-brick - 0.5.0-0ubuntu3

---------------
python-os-brick (0.5.0-0ubuntu3) wily; urgency=medium

  * Backport fix for ScaleIO could connect wrong volume to VM (LP: #1524989)
    - d/p/scaleio-could-connect-wrong-volume-to-vm.patch

 -- Edward Hope-Morley <email address hidden> Fri, 27 May 2016 16:41:51 +0100

Changed in python-os-brick (Ubuntu Wily):
status: Fix Committed → Fix Released
Revision history for this message
Brian Murray (brian-murray) wrote : Update Released

The verification of the Stable Release Update for python-os-brick has completed successfully and the package has now been released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

Revision history for this message
Ryan Beisner (1chb1n) wrote :

The verification of the Stable Release Update for python-os-brick has completed successfully and the package has now been released to -updates. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

Revision history for this message
Ryan Beisner (1chb1n) wrote :

This bug was fixed in the package python-os-brick - 0.5.0-0ubuntu3~cloud0
---------------

 python-os-brick (0.5.0-0ubuntu3~cloud0) trusty-liberty; urgency=medium
 .
   * New update for the Ubuntu Cloud Archive.
 .
 python-os-brick (0.5.0-0ubuntu3) wily; urgency=medium
 .
   * Backport fix for ScaleIO could connect wrong volume to VM (LP: #1524989)
     - d/p/scaleio-could-connect-wrong-volume-to-vm.patch

Louis Bouchard (louis)
tags: removed: sts-sru
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.