atlantean mines failing to extract all resources

an update: i made another mine, this one directly on top of the coal, and that mine worked. so either the atlantean mine fails to work to its full radius, or it fails to work fully on its more periferic tiles. it could even be intended, but in that case it should be specified.

The responsible code is here: http://bazaar.launchpad.net/~widelands-dev/widelands/trunk/view/head:/src/logic/production_program.cc#L1239

A penalty for empty or nearly-empty fields is added, so I guess the chance of extracting the very last bit of resources is very low. I do not know if this has to do something with the peripheric position (I don't think so), it might have been luck that the second mine digged out the resource immediately.

ah, that's why i also noticed that nnearly depleted mines sometimes fail to operate. I was going to report a bug for it too, but now I learn it's supposed to be that way.

So, two fixes should be made:

1) in the help text, it should specify that when a mine is almost empty, it will sometimes fail to work.

2) It should not give an empty messsage until there is really nothing left.

I think that the second way is better.

Also there should be a change of text over the mine while not mining the resource. "Produce no coal, because it is ALMOST depleted". Empty mine text should not contain "almost".

I prepared the fix - but only for the main problem - not mining all resources.

The problem is mathematical. There was a corner case when digged_percentage=100 and at the same time there were few unmined resources left. The fix is to change the rounding, so that if there are some resources left, the digged_percentage will never be 100.

But I am not able to do the other suggestions about text over, I dont understand fully how that stuff works in code.

Should be fixed in rev. 7703 - at least in the scope of bug description

Fixed in build19-rc1.