senlin

Bug happened when attaching policy

Bug #1525811 reported by Yanyan Hu
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
senlin
Fix Released
High
Qiming Teng

Bug Description

The following error happened when attaching policy:

2015-12-14 07:55:05.432 25541 ERROR senlin.engine.actions.base [req-f97f2c5a-aeb4-4762-9465-542921d2dd6e 9be46f28bd414e978b16a4791233368e 89edc66fe6734ad59bffc10f86d62e58 - - -] Unexpected exception occurred during action CLUSTER_ATTACH_POLICY (ea3aba9a-a9e7-42e2-80ca-071c303655b2) execution: pop() takes exactly 2 arguments (3 given)
2015-12-14 07:55:05.432 25541 ERROR senlin.engine.actions.base Traceback (most recent call last):
2015-12-14 07:55:05.432 25541 ERROR senlin.engine.actions.base File "/opt/stack/new/senlin/senlin/engine/actions/base.py", line 490, in ActionProc
2015-12-14 07:55:05.432 25541 ERROR senlin.engine.actions.base result, reason = action.execute()
2015-12-14 07:55:05.432 25541 ERROR senlin.engine.actions.base File "/opt/stack/new/senlin/senlin/engine/actions/cluster_action.py", line 689, in execute
2015-12-14 07:55:05.432 25541 ERROR senlin.engine.actions.base res, reason = self._execute(**kwargs)
2015-12-14 07:55:05.432 25541 ERROR senlin.engine.actions.base File "/opt/stack/new/senlin/senlin/engine/actions/cluster_action.py", line 657, in _execute
2015-12-14 07:55:05.432 25541 ERROR senlin.engine.actions.base result, reason = method()
2015-12-14 07:55:05.432 25541 ERROR senlin.engine.actions.base File "/opt/stack/new/senlin/senlin/engine/actions/cluster_action.py", line 596, in do_attach_policy
2015-12-14 07:55:05.432 25541 ERROR senlin.engine.actions.base policy_id = self.inputs.pop('policy_id', None)
2015-12-14 07:55:05.432 25541 ERROR senlin.engine.actions.base TypeError: pop() takes exactly 2 arguments (3 given)
2015-12-14 07:55:05.432 25541 ERROR senlin.engine.actions.base
2015-12-14 07:55:05.453 25541 ERROR senlin.engine.event [req-f97f2c5a-aeb4-4762-9465-542921d2dd6e 9be46f28bd414e978b16a4791233368e 89edc66fe6734ad59bffc10f86d62e58 - - -] attach_policy_ccf1b62a [ea3aba9a] CLUSTER_ATTACH_POLICY - FAILED: pop() takes exactly 2 arguments (3 given)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix proposed to senlin (master)

Related fix proposed to branch: master
Review: https://review.openstack.org/257223

Revision history for this message
Qiming Teng (tengqim) wrote :

looks like the inputs field was incorrectly parsed as a list?

  A dict.pop() takes a 'key' and an optional 'default' parameter. A list pop() is different.

Revision history for this message
Yanyan Hu (yanyanhu) wrote :

Yes, I guess that is the reason.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix merged to senlin (master)

Reviewed: https://review.openstack.org/257223
Committed: https://git.openstack.org/cgit/openstack/senlin/commit/?id=e419117080f6d47fb1e56fc4291632c058fe3fe5
Submitter: Jenkins
Branch: master

commit e419117080f6d47fb1e56fc4291632c058fe3fe5
Author: tengqm <email address hidden>
Date: Mon Dec 14 03:50:06 2015 -0500

    Fix list data type implementation

    In previous patch, we were possibly doing things wrong regarding data
    type coercing. We are forcing a conversion to MutableList for some
    fields. This is an attempt to fix it.

    Change-Id: I603249119ac1996f4626e3ee076ea64ff895bad7
    related-bug: #1525811

Qiming Teng (tengqim)
Changed in senlin:
importance: Undecided → High
status: New → Fix Released
assignee: nobody → Qiming Teng (tengqim)
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.