Mahara

Remove remnants to accessconf column as we've moved away from this

Bug #1527456 reported by Robert Lyon
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Fix Released
Medium
Robert Lyon
Mahara 16.10.0

Bug Description

In 2010 a accessconf column was added to the view table to clump together views with same access configuration to help with the view/access.php page

But since 15.10 we've done the view access page slightly differently and have already removed some of this functionality.

As there is nothing else using it we might as well remove the rest of it.

Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "master" branch: https://reviews.mahara.org/5861

Kristina Hoeppner (kris-hoeppner)
Changed in mahara:
status: New → In Progress
importance: Undecided → Medium
assignee: nobody → Robert Lyon (robertl-9)
milestone: none → 16.04.0
Aaron Wells (u-aaronw)
Changed in mahara:
milestone: 16.04.0 → 16.10.0
Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/5861
Committed: https://git.mahara.org/mahara/mahara/commit/2816ade18f3327d8edaf11039c4ebef26fb67b94
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit 2816ade18f3327d8edaf11039c4ebef26fb67b94
Author: Robert Lyon <email address hidden>
Date: Fri Dec 18 17:54:10 2015 +1300

Bug 1527456: removing the last remnants of the accessconf stuff

This got added in 2010 via
commit 87a2c5f2609859cd1f9dc2cab8a51494d1cfc04d

but we don't need it now, and will end up complicating the ability to
do views in multiple collections, so will remove

behatnotneeded - existing tests should cover

Change-Id: Ie39a72442cae10727bf9f26ed86050e66e7df4bd
Signed-off-by: Robert Lyon <email address hidden>
Signed-off-by: Aaron Wells <email address hidden>

Robert Lyon (robertl-9)
Changed in mahara:
status: In Progress → Fix Committed
Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "master" branch: https://reviews.mahara.org/6771

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/6771
Committed: https://git.mahara.org/mahara/mahara/commit/e50d16136d2947ed22d2c35bd866a6b1789cac09
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit e50d16136d2947ed22d2c35bd866a6b1789cac09
Author: Robert Lyon <email address hidden>
Date: Tue Aug 2 09:33:28 2016 +1200

Bug 1527456: Fixing up db/upgrade.php

Two patches got merged with the same version update number so might as
well have the upgrade steps in the same 'if' statement

behatnotneeded

Change-Id: I2d9e24fc967a491d5a1d3d76e1f45bc8545ff4ab
Signed-off-by: Robert Lyon <email address hidden>

Robert Lyon (robertl-9)
Changed in mahara:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.