Mahara

Anonymous comment area needs a label for the "Comment" text field

Bug #1529718 reported by Kristina Hoeppner
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Fix Released
Medium
Pramith Dayananda
Mahara 17.04.0

Bug Description

Mahara 15.10+

When you add a comment as anonymous user, i.e. someone who is not logged in, you need to provide your name first and then see a comment text field (see screenshot). That text field doesn't have a label, but I think it should have one so it's clear what it is for.

It is also a required field. Thus marking it as "Comment*" would be good.

Revision history for this message
Kristina Hoeppner (kris-hoeppner) wrote :
Robert Lyon (robertl-9)
Changed in mahara:
milestone: 16.04.0 → 16.10.0
Robert Lyon (robertl-9)
Changed in mahara:
milestone: 16.10.0 → 16.10.1
Robert Lyon (robertl-9)
Changed in mahara:
milestone: 16.10.1 → 17.04.0
Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "16.10_STABLE" branch: https://reviews.mahara.org/7496

Pramith Dayananda (pramithkm)
Changed in mahara:
assignee: nobody → Pramith Dayananda (pramithkm)
Revision history for this message
Mahara Bot (dev-mahara) wrote :

Patch for "master" branch: https://reviews.mahara.org/7500

Revision history for this message
Mahara Bot (dev-mahara) wrote :

Patch for "master" branch: https://reviews.mahara.org/7502

Pramith Dayananda (pramithkm)
Changed in mahara:
status: Confirmed → Fix Committed
Revision history for this message
Mahara Bot (dev-mahara) wrote :

Patch for "master" branch: https://reviews.mahara.org/7512

Revision history for this message
Niranjan (niranjan528) wrote :

Test failed

Revision history for this message
Pramith Dayananda (pramithkm) wrote :

Hi Niranjan,

I did fetch the change locally using following git command, and I can see the label as "Message".
git fetch git://reviews.mahara.org/git/mahara refs/changes/02/7502/2 && git checkout FETCH_HEAD

Not aware of how you do the testing, so please let me know if I missed anything here.

Cheers,
Pramith.

Kristina Hoeppner (kris-hoeppner)
Changed in mahara:
status: Fix Committed → In Progress
Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/7512
Committed: https://git.mahara.org/mahara/mahara/commit/7bbd4282914200cfb84bed41df3677247e1980c6
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit 7bbd4282914200cfb84bed41df3677247e1980c6
Author: Pramith Dayananda <email address hidden>
Date: Thu Mar 9 11:18:53 2017 +1300

Bug 1529718: Behat tests

Change-Id: I148fa1ec0053b2488ee7e1f12b39113feb24ca4b

Revision history for this message
Mahara Bot (dev-mahara) wrote :

Reviewed: https://reviews.mahara.org/7502
Committed: https://git.mahara.org/mahara/mahara/commit/7535e2e64cec7482aadeb637df0c97fab572cfdb
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit 7535e2e64cec7482aadeb637df0c97fab572cfdb
Author: Pramith Dayananda <email address hidden>
Date: Thu Mar 2 17:10:30 2017 +1300

Bug 1529718: Anonymous comment area, show label for Message textarea

behatnotneeded

Anonymous comment area needs a label
for the "Comment" text field
Changes proposed in review

Change-Id: Ia0d61bb7bc14fe36694e25abd4d420efe9b2e509

Robert Lyon (robertl-9)
Changed in mahara:
status: In Progress → Fix Committed
Robert Lyon (robertl-9)
Changed in mahara:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.