Launchpad itself

Product:+configure-code always shows +editsshkeys link

Bug #1534159 reported by Colin Watson
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Launchpad itself
Fix Released
High
Colin Watson

Bug Description

Product:+configure-code shows "To authenticate with the Launchpad branch upload service, you need to register an SSH key" regardless of whether you have any SSH keys registered, which isn't intended.

I think that <div metal:define-macro="..." condition="..."> may not quite do what's required here; perhaps the condition needs to be in an interior element.

Related branches

lp:~cjwatson/launchpad/stray-editsshkeys-link
William Grant: Approve (code)
Diff: 61 lines (+24/-2)
2 files modified
lib/lp/code/templates/configure-code-macros.pt (+1/-1)
lib/lp/registry/browser/tests/test_product_views.py (+23/-1)
Revision history for this message
Colin Watson (cjwatson) wrote :

Ah, of course, it needs to be tal:condition.

Changed in launchpad:
assignee: nobody → Colin Watson (cjwatson)
status: Triaged → In Progress
Revision history for this message
Launchpad QA Bot (lpqabot) wrote :

Fixed in stable r17890 <http://bazaar.launchpad.net/~launchpad-pqm/launchpad/stable/revision/17890>.

tags: added: qa-needstesting
Changed in launchpad:
status: In Progress → Fix Committed
Colin Watson (cjwatson)
tags: added: qa-ok
removed: qa-needstesting
Colin Watson (cjwatson)
Changed in launchpad:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.