Backport upstream fix for memleak

Bug #1545308 reported by Trent Nelson
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
glib2.0 (Ubuntu)
Fix Released
High
Unassigned
Wily
Fix Released
High
Iain Lane

Bug Description

https://bugzilla.gnome.org/show_bug.cgi?id=758641

Please consider taking this memleak fix from upstream. I've built the package with it locally and confirmed that it fixes the leak in xfce4-power-manager, which is mentioned in the upstream report. It also fixes a similarly sized (hundreds of MB after a few days up time) leak that I have observed in the NetworkManager service.

[Impact]
Hundreds of MB memory leak in certain dbus applications, including default services like xfce4-power-manager and NetworkManager with default configurations.

[Test Case]
Clean install of lubuntu 15.10 on a notebook with working battery. Observe xfce4-power-manager and NetworkManager* in "top" over 48-72hrs of normal use (web browsing, text editing, shell, etc). Both will be taking on several tens of MB per day of additional RES.

*NetworkManager may require buggy wifi to reproduce. rtl8723be in my case.

[Regression Potential]
I'm no authority on the glib code base, but the upstream patch looks very safe to me.

Let me know if you need any further details.

ProblemType: Bug
DistroRelease: Ubuntu 15.10
Package: libglib2.0-0 2.46.1-1
ProcVersionSignature: Ubuntu 4.2.0-25.30-generic 4.2.6
Uname: Linux 4.2.0-25-generic x86_64
ApportVersion: 2.19.1-0ubuntu5
Architecture: amd64
CurrentDesktop: LXDE
Date: Sat Feb 13 09:58:03 2016
EcryptfsInUse: Yes
InstallationDate: Installed on 2015-12-25 (49 days ago)
InstallationMedia: Lubuntu 15.10 "Wily Werewolf" - Release amd64 (20151021)
SourcePackage: glib2.0
UpgradeStatus: No upgrade log present (probably fresh install)

Revision history for this message
Trent Nelson (trent-a-b-nelson) wrote :
Revision history for this message
Sebastien Bacher (seb128) wrote :
Changed in glib2.0 (Ubuntu):
importance: Undecided → High
Revision history for this message
Sebastien Bacher (seb128) wrote :

Iain said he could have a look, assigning to him, thanks!

Changed in glib2.0 (Ubuntu):
assignee: nobody → Iain Lane (laney)
status: New → Triaged
Revision history for this message
Iain Lane (laney) wrote :

I uploaded it, sorry for the delay!

It would be good if you could update the bug with the information from <https://wiki.ubuntu.com/StableReleaseUpdates#Procedure>, otherwise the SRU team might delay accepting the upload (hopefully not).

Changed in glib2.0 (Ubuntu Wily):
status: New → In Progress
Changed in glib2.0 (Ubuntu):
status: Triaged → Fix Released
Changed in glib2.0 (Ubuntu Wily):
assignee: nobody → Iain Lane (laney)
Changed in glib2.0 (Ubuntu):
assignee: Iain Lane (laney) → nobody
Revision history for this message
Trent Nelson (trent-a-b-nelson) wrote :

Thanks fellas!

Iain,

Was the SRU comment directed at me or Sebastien? I would be happy to update what I can later this evening, but some of the information requested there seems like it would better come from someone more familiar with the glib code base (potential regressions, etc).

Revision history for this message
Iain Lane (laney) wrote : Re: [Bug 1545308] Re: Backport upstream fix for memleak

On Tue, Mar 01, 2016 at 04:25:02PM -0000, Trent Nelson wrote:
> Thanks fellas!
>
> Iain,
>
> Was the SRU comment directed at me or Sebastien? I would be happy to
> update what I can later this evening, but some of the information
> requested there seems like it would better come from someone more
> familiar with the glib code base (potential regressions, etc).

It was you. I think the mainly interesting one is a clear list of steps
for reproducing the bug, so we can be sure that it is fixed. The
description is already decent, but if it were a step by step list it
would be even easier. :)

--
Iain Lane [ <email address hidden> ]
Debian Developer [ <email address hidden> ]
Ubuntu Developer [ <email address hidden> ]

Revision history for this message
Trent Nelson (trent-a-b-nelson) wrote :

Sorry, I spaced this. Description updated. :)

description: updated
Revision history for this message
Brian Murray (brian-murray) wrote : Please test proposed package

Hello Trent, or anyone else affected,

Accepted glib2.0 into wily-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/glib2.0/2.46.2-1ubuntu2 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-needed to verification-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

Changed in glib2.0 (Ubuntu Wily):
status: In Progress → Fix Committed
tags: added: verification-needed
Revision history for this message
Trent Nelson (trent-a-b-nelson) wrote :

I finally got around to enabling the package from proposed. I'll report back in a few days with results.

Revision history for this message
Trent Nelson (trent-a-b-nelson) wrote :

Hey Brian,

I was going to let this run longer, but I think we're safe. I've observed RSS of both xfce4-power-manager and NetworkManager grow by over 1.5MB from usage at start up and have now dropped back to more than 1MB below usage at start up. These observations were made with swap disabled, so they should be accurate. Without the patch, both would be ~50MB over start up usage by now.

tags: added: verification-done
removed: verification-needed
Mathew Hodson (mhodson)
Changed in glib2.0 (Ubuntu Wily):
importance: Undecided → High
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package glib2.0 - 2.46.2-1ubuntu2

---------------
glib2.0 (2.46.2-1ubuntu2) wily; urgency=medium

  * d/p/0001-GDBusProxy-Fix-a-memory-leak-during-initialization.patch:
    Cherry-pick upstream patch to fix a memleak in GDBusProxy (LP: #1545308)

 -- Iain Lane <email address hidden> Tue, 01 Mar 2016 13:05:30 +0000

Changed in glib2.0 (Ubuntu Wily):
status: Fix Committed → Fix Released
Revision history for this message
Martin Pitt (pitti) wrote : Update Released

The verification of the Stable Release Update for glib2.0 has completed successfully and the package has now been released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.