Mahara

Profile pictures displayed incorrectly for staff on user search when no access list access

Bug #1545380 reported by Kristina Hoeppner on 2016-02-14

This bug affects 1 person

Affects		Status	Importance	Assigned to	Milestone
	Mahara	Fix Released	High	Robert Lyon	Mahara 16.04.0
	15.10	Fix Released	High	Unassigned	Mahara 15.10.2

Bug Description

Mahara 15.10+

When you are a staff member and don't have access to the access list (in Administration -> Configure site -> Site options -> User settings -> "Staff report access" set to "No", the user search page doesn't display the profile pictures correctly, but all next to each other (see attachment).

It is fine when the setting is "yes" because then the "All/None" column is there.

See original description

Tags:

Revision history for this message

Kristina Hoeppner (kris-hoeppner) wrote on 2016-02-14:

staff_user_search_page.png Edit (39.1 KiB, image/png)

description:

updated

Revision history for this message

Kristina Hoeppner (kris-hoeppner) wrote on 2016-02-14:

Also, the right side of the button "Get reports for selected users" is missing because there is no second button.

tags:

added: usermanualupdate

Revision history for this message

Mahara Bot (dev-mahara) wrote on 2016-02-15: A patch has been submitted for review

Patch for "master" branch: https://reviews.mahara.org/6060

Robert Lyon (robertl-9) on 2016-02-15

Changed in mahara:
assignee:	nobody → Robert Lyon (robertl-9)
status:	Confirmed → In Progress

Revision history for this message

Mahara Bot (dev-mahara) wrote on 2016-03-16: A change has been merged

Reviewed: https://reviews.mahara.org/6060
Committed: https://git.mahara.org/mahara/mahara/commit/b5bf4d5da0febd4916dc0b8d2eb71470760f0671
Submitter: Aaron Wells (<email address hidden>)
Branch: master

commit b5bf4d5da0febd4916dc0b8d2eb71470760f0671
Author: Robert Lyon <email address hidden>
Date: Mon Feb 15 13:49:23 2016 +1300

Bug 1545380: Profile images on user list broken for staff

When 'Staff report access' is set to 'no'. This is due to the column
being built from both the 'select' and 'icon' part of the $cols array.

So need to pass in a mostly blank 'select' column info rather than
unset it.

Also fixed up the missing right side line on button when viewing page as
staff with 'Staff report access' set to 'yes'

behatnotneeded

Change-Id: I97d77f0dc136967efa16945114bcd990e49754d0
Signed-off-by: Robert Lyon <email address hidden>

Kristina Hoeppner (kris-hoeppner) on 2016-03-16

Changed in mahara:
status:	In Progress → Fix Committed

Revision history for this message

Mahara Bot (dev-mahara) wrote on 2016-03-16: A patch has been submitted for review

Patch for "15.10_STABLE" branch: https://reviews.mahara.org/6150

Revision history for this message

Mahara Bot (dev-mahara) wrote on 2016-03-17: A change has been merged

Reviewed: https://reviews.mahara.org/6150
Committed: https://git.mahara.org/mahara/mahara/commit/c2b7e9203a6216be9edffe97bd138b55683468dd
Submitter: Robert Lyon (<email address hidden>)
Branch: 15.10_STABLE

commit c2b7e9203a6216be9edffe97bd138b55683468dd
Author: Robert Lyon <email address hidden>
Date: Mon Feb 15 13:49:23 2016 +1300

Bug 1545380: Profile images on user list broken for staff

When 'Staff report access' is set to 'no'. This is due to the column
being built from both the 'select' and 'icon' part of the $cols array.

So need to pass in a mostly blank 'select' column info rather than
unset it.

Also fixed up the missing right side line on button when viewing page as
staff with 'Staff report access' set to 'yes'

behatnotneeded

Change-Id: I97d77f0dc136967efa16945114bcd990e49754d0
Signed-off-by: Robert Lyon <email address hidden>
(cherry picked from commit b5bf4d5da0febd4916dc0b8d2eb71470760f0671)

Kristina Hoeppner (kris-hoeppner) on 2016-04-29