Evergreen

Incorrect datatype for Default Record Match Set org setting

Bug #1552861 reported by Jeff Davis
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Evergreen
Fix Released
Low
Unassigned
Evergreen 2.12.2
2.11
Fix Released
Low
Unassigned
Evergreen 2.11.5

Bug Description

This bug affects Evergreen 2.4.0 through master.

Bug 1067087 introduced a new org setting, Default Record Match Set (vandelay.default_match_set). The upgrade script for the new setting uses datatype "link" with fm_class "vms". However, the corresponding change in 950.data.seed-values.sql uses a datatype of "string" for the same setting.

It's easy enough to fix this in 950.data.seed-values.sql. We probably also want a separate upgrade script to convert any existing vandelay.default_match_set values from strings to vandelay.match_set id's, although the setting doesn't actually work unless the value is an id.

Revision history for this message
Jeff Davis (jdavis-sitka) wrote :

Pushed a schema fix to working branch user/jeffdavis/lp1552861-default-match-set-datatype:

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=commitdiff;h=23ad642

I'm not sure how to go about protecting existing values. If they correspond to existing vandelay.match_set.id values, then all is well, but what if they don't? Do we give a warning and wipe invalid values, try to match on vandelay.match_set.name, or...? (As noted above, invalid values already don't work.)

Jeff Davis (jdavis-sitka)
Changed in evergreen:
milestone: none → 2.next
tags: added: pullrequest vandelay
Revision history for this message
Galen Charlton (gmc) wrote :

Tested and signed off, with an addition: user/gmcharlt/lp1552861_signoff

During testing, I noted that if that setting was set to an invalid value, it broke the library settings editor. Consequently, the add-on patch arranges during the database update to report, then remove, any instances of the vandelay.default_match_set setting that don't correspond to a vms row.

Changed in evergreen:
status: New → Confirmed
milestone: 3.next → 2.12.2
importance: Undecided → Low
tags: added: signedoff
Revision history for this message
Jeff Davis (jdavis-sitka) wrote :

Upgrade script works for me. Signed off (with a minor typofix): user/jeffdavis/lp1552861_signoff

Revision history for this message
Galen Charlton (gmc) wrote :

Pushed to master, rel_2_12, and rel_2_11. Thanks, Jeff!

Changed in evergreen:
status: Confirmed → Fix Committed
Evergreen Bug Maintenance (bugmaster)
Changed in evergreen:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.