please merge remmina from debian

Bug #1556383 reported by Gianfranco Costamagna
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
remmina (Ubuntu)
Fix Released
Wishlist
Unassigned

Bug Description

.

Tags: patch
Revision history for this message
Gianfranco Costamagna (costamagnagianfranco) wrote :

debdiff

Revision history for this message
Gianfranco Costamagna (costamagnagianfranco) wrote :
tags: added: patch
Revision history for this message
Marc Deslauriers (mdeslaur) wrote :

Hi, thanks for this merge debdiff. I have a few comments though:

1- Please remove the unused indicator_set_title.patch
2- The translations.patch file adds two "Actions=" entries for the remmina.desktop.in file
3- The new keywords in the translations.patch file need to be added to remmina.desktop.in also.
4- Why do you remove the debian/docs file?

Thanks!

Changed in remmina (Ubuntu):
status: New → Incomplete
Revision history for this message
Gianfranco Costamagna (costamagnagianfranco) wrote :

Hi!

1- Please remove the unused indicator_set_title.patch

done

2- The translations.patch file adds two "Actions=" entries for the remmina.desktop.in file

done

3- The new keywords in the translations.patch file need to be added to remmina.desktop.in also.

my mistake, done

4- Why do you remove the debian/docs file?

I don't remove it anymore.

1-2-4 were already there in the previous upload, so I didn't change them.
3 is a fault I fixed now.

I changed all of them, but I don't know if the points above were mistakes from previous uploads or not.
debdiff updated :)

a new build is on my ppa

thanks!

Mathew Hodson (mhodson)
Changed in remmina (Ubuntu):
importance: Undecided → Wishlist
status: Incomplete → New
Revision history for this message
Robert Ancell (robert-ancell) wrote :

Sponsored - thanks for the work!

Changed in remmina (Ubuntu):
status: New → Fix Committed
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package remmina - 1.1.2-3ubuntu1

---------------
remmina (1.1.2-3ubuntu1) xenial; urgency=low

  * Merge from Debian unstable (LP: #1556383). Remaining changes:
    - Switch build depends from transitional libgnutsl28-dev to libgnutls-dev
    + debian/control:
      - Build-depend on libappindicator3-dev, intltool
    + debian/rules:
      - Build with libappindicator
      - Call intltool-update on build
    + debian/patches/translations.patch,
      - Make translatable and add keywords.
      - disable 0005-desktop.patch included in translations.patch

 -- Gianfranco Costamagna <email address hidden> Sat, 12 Mar 2016 09:05:49 +0100

Changed in remmina (Ubuntu):
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.