Mahara

Remove tinymce imagebrowser height setting

Bug #1568659 reported by Robert Lyon
14
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Mahara
Fix Released
Medium
Robert Lyon
Mahara 16.04.0
16.10
Fix Released
Medium
Unassigned
Mahara 16.10.0

Bug Description

As we are using flexible layout we don't need the height / constraint settings in tinymce browser as we want the images to be able to look ok on small / mobile browsers

Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "master" branch: https://reviews.mahara.org/6321

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/6321
Committed: https://git.mahara.org/mahara/mahara/commit/c5d61fcb14f9a5906cc1d60ba1a3752cec6a6413
Submitter: Aaron Wells (<email address hidden>)
Branch: master

commit c5d61fcb14f9a5906cc1d60ba1a3752cec6a6413
Author: Robert Lyon <email address hidden>
Date: Mon Apr 11 15:16:55 2016 +1200

Bug 1568659: Allow the tinymce to not record height

And not record the constraint also

behatnotneeded - existing tests will do

Change-Id: Ia0ec5c9d6c99d2560bb5186b905e98ec47f04407
Signed-off-by: Robert Lyon <email address hidden>

Kristina Hoeppner (kris-hoeppner)
Changed in mahara:
status: In Progress → Fix Committed
Robert Lyon (robertl-9)
Changed in mahara:
milestone: 16.04.0 → 16.10.0
Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "16.04_STABLE" branch: https://reviews.mahara.org/6341

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/6341
Committed: https://git.mahara.org/mahara/mahara/commit/b22a2bf7a4c23c38785cd9796ec0a9901045bb39
Submitter: Robert Lyon (<email address hidden>)
Branch: 16.04_STABLE

commit b22a2bf7a4c23c38785cd9796ec0a9901045bb39
Author: Robert Lyon <email address hidden>
Date: Mon Apr 11 15:16:55 2016 +1200

Bug 1568659: Allow the tinymce to not record height

And not record the constraint also

behatnotneeded - existing tests will do

Change-Id: Ia0ec5c9d6c99d2560bb5186b905e98ec47f04407
Signed-off-by: Robert Lyon <email address hidden>
(cherry picked from commit c5d61fcb14f9a5906cc1d60ba1a3752cec6a6413)

Kristina Hoeppner (kris-hoeppner)
tags: added: usermanualupdate
Robert Lyon (robertl-9)
Changed in mahara:
status: Fix Committed → Fix Released
Kristina Hoeppner (kris-hoeppner)
no longer affects: mahara/16.04
Kristina Hoeppner (kris-hoeppner)
tags: added: nominatedfeature
removed: usermanualupdate
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.