multipath-tools update introduced syslog messages about partx

Bug #1570093 reported by Matt Schulte
20
This bug affects 2 people
Affects Status Importance Assigned to Milestone
multipath-tools (Debian)
Fix Released
Unknown
multipath-tools (Ubuntu)
Fix Released
Low
Dragan S.
Xenial
Fix Released
Low
Unassigned

Bug Description

[Impact]

 * During "service multipath-tools start" /sbin/multipath is
   called on dm- devices that are filtered but due to a condition
   conf->dev_type == DEV_DEVNODE in filtering code multipath
   binary wasn't dropping out when hitting a dm- device. This
   was due to the fact that in this case conf->dev_type is
   set to DEV_UEVENT. It also happens during a fail-over event.

   This is causing the logs to be filled with following
   messages:

   multipath: dm-6: failed to get udev uid: Invalid argument
   multipath: dm-6: failed to get sysfs uid: Invalid argument
   multipath: dm-6: failed to get sgio uid: No such file or directory

 * Fix should be backported to xenial to avoid more support
   issues being filed.

 * This change alows the filtering to happen.

[Test Case]

 * install multipath-tools, create a basic multipath.conf with
   dm- filtering rule. Run: "service multipath-tools start"
   and check the log

[Regression Potential]

 * There should be no regression potential with this change, the filtering
   only allows the code to not traverse the error path.

[Original Description]

During a path loss event, the syslog is showing these messages where prior to the recent upgrade to multipath-tools I didn't see anything like this. To me this seems like either a problem or it seems like a print message that should go into a different log file.

Apr 13 11:21:00 ICTM1618S01H4 systemd-udevd[14861]: Process '/usr/bin/partx -d --nr 1-1024 /dev/sdam' failed with exit code 1.
...
Apr 13 11:21:00 ICTM1618S01H4 multipath: dm-15: failed to get udev uid: Invalid argument
Apr 13 11:21:00 ICTM1618S01H4 multipath: dm-15: failed to get sysfs uid: Invalid argument
Apr 13 11:21:00 ICTM1618S01H4 multipath: dm-15: failed to get sgio uid: No such file or directory

ProblemType: Bug
DistroRelease: Ubuntu 16.04
Package: multipath-tools 0.5.0+git1.656f8865-5ubuntu2
ProcVersionSignature: Ubuntu 4.4.0-18.34-generic 4.4.6
Uname: Linux 4.4.0-18-generic x86_64
ApportVersion: 2.20.1-0ubuntu1
Architecture: amd64
Date: Wed Apr 13 15:29:36 2016
SourcePackage: multipath-tools
UpgradeStatus: No upgrade log present (probably fresh install)

Revision history for this message
Matt Schulte (gimpyestrada) wrote :
Revision history for this message
Launchpad Janitor (janitor) wrote :

Status changed to 'Confirmed' because the bug affects multiple users.

Changed in multipath-tools (Ubuntu):
status: New → Confirmed
Changed in multipath-tools (Ubuntu):
assignee: nobody → Rafael David Tinoco (inaddy)
Dragan S. (dragan-s)
Changed in multipath-tools (Ubuntu):
assignee: Rafael David Tinoco (inaddy) → Dragan S. (dragan-s)
Revision history for this message
Rafael David Tinoco (rafaeldtinoco) wrote :

Hello Matt,

Are there any other error messages available when this happens ?

I'm looking specifically for Illegal SCSI requests similar to this one:

[ 1923.361604] sd 7:0:0:0: [sdb] tag#0 FAILED Result: hostbyte=DID_OK driverbyte=DRIVER_SENSE
[ 1923.361621] sd 7:0:0:0: [sdb] tag#0 Sense Key : Illegal Request [current]
[ 1923.361628] sd 7:0:0:0: [sdb] tag#0 Add. Sense: Invalid field in cdb
[ 1923.361635] sd 7:0:0:0: [sdb] tag#0 CDB: Write same(16) 93 08 00 00 00 00 00 00 29 10 00 00 0f f8 00 00
[ 1923.361641] blk_update_request: critical target error, dev sdb, sector 10512
[ 1923.362078] blk_update_request: critical target error, dev dm-2, sector 10512
[ 1923.363433] blk_cloned_rq_check_limits: over max size limit.

Revision history for this message
Matt Schulte (gimpyestrada) wrote :

Here is an example of a bunch of failover events from a rebooted storage controller. You can see that there are others similar to what you mentioned above.

Changed in multipath-tools (Ubuntu):
status: Confirmed → In Progress
importance: Undecided → Low
Revision history for this message
Dragan S. (dragan-s) wrote :

Hi Matt-

do you mind posting your "/etc/multipath.conf" from the host you provided the last syslog.

And also if you can provide the output of "sudo multipath -ll" from the same host.

Thank you

Revision history for this message
Matt Schulte (gimpyestrada) wrote :

I have no multipath.conf, we just use the defaults that are built in for our storage.

multipath -ll for that particular host is not going to look good right now as I'm having an issue with an Emulex device. Until I get my hardware issue resolved I don't want to send you an output that will be confusing as I only have one path right now :)

Revision history for this message
Matt Schulte (gimpyestrada) wrote :

This is the output of multipathd show config, which is the effective multipath.conf file.

Revision history for this message
Dragan S. (dragan-s) wrote :

Thanks for the info Matt. I am looking into the case.

If you replace:
uid_attribute "ID_SERIAL"

with:
getuid_callout "/lib/udev/scsi_id --whitelisted --device=/dev/%n"

in your multipath.conf and restart your multipathd those messages should go away.

The line should be in your "defaults" section of the config.

Revision history for this message
Dragan S. (dragan-s) wrote :

Hi Matt-

just wanted to give you a quick update on the issue. We've isolated the problem and are now working with upstream developer to push the patch.

Revision history for this message
Dragan S. (dragan-s) wrote :

Patch has been submitted upstream on:

1. Thu, 23 Jun 2016 16:06:24 -0500
[dm-devel] Subject: [PATCH 1/1] multipath-tools: fix dm- device filtering
https://www.redhat.com/archives/dm-devel/2016-June/msg00359.html

2. Tue, 5 Jul 2016 15:46:57 -0500
[dm-devel] [PATCH 1/1] multipath-tools: fix dm- device filtering
https://www.redhat.com/archives/dm-devel/2016-July/msg00086.html

I has been accepted upstream on:
Fri, 8 Jul 2016 09:42:43 +0200
https://www.redhat.com/archives/dm-devel/2016-July/msg00159.html

Revision history for this message
Dragan S. (dragan-s) wrote :

Here is the debdiff for the fix. Working on up-streaming this fix to debian.

Revision history for this message
Ubuntu Foundations Team Bug Bot (crichton) wrote :

The attachment "Fix debdiff" seems to be a debdiff. The ubuntu-sponsors team has been subscribed to the bug report so that they can review and hopefully sponsor the debdiff. If the attachment isn't a patch, please remove the "patch" flag from the attachment, remove the "patch" tag, and if you are member of the ~ubuntu-sponsors, unsubscribe the team.

[This is an automated message performed by a Launchpad user owned by ~brian-murray, for any issue please contact him.]

tags: added: patch
Revision history for this message
Matt Schulte (gimpyestrada) wrote :

Do I have to rebuild the package with this debdiff before it can be accepted?

Revision history for this message
Dragan S. (dragan-s) wrote :

Hi Mike,

I already built the PPA for this change. You can get it by running following commands:

add-apt-repository ppa:dragan-s/lp1570093
apt update
apt install multipath-tools

With this fix the errors like the ones below should be gone:
Apr 13 11:21:00 ICTM1618S01H4 multipath: dm-15: failed to get udev uid: Invalid argument
Apr 13 11:21:00 ICTM1618S01H4 multipath: dm-15: failed to get sysfs uid: Invalid argument
Apr 13 11:21:00 ICTM1618S01H4 multipath: dm-15: failed to get sgio uid: No such file or directory

Revision history for this message
Dragan S. (dragan-s) wrote :

Err... -ENONAME sorry meant to type Matt

Revision history for this message
Dragan S. (dragan-s) wrote :

Fix has been submitted upstream into Debian:

Tue, 12 Jul 2016 11:30:15 -0500
https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=830882

Mathew Hodson (mhodson)
Changed in multipath-tools (Ubuntu Xenial):
importance: Undecided → Low
Revision history for this message
Matt Schulte (gimpyestrada) wrote :

I can confirm that the messages seem to be cleaned up with your fix.

Revision history for this message
Dragan S. (dragan-s) wrote :

Great, thank you Matt. Independent verification of the fix will now allow it to move upstream.

Changed in multipath-tools (Debian):
status: Unknown → New
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package multipath-tools - 0.5.0+git1.656f8865-5ubuntu4

---------------
multipath-tools (0.5.0+git1.656f8865-5ubuntu4) yakkety; urgency=medium

  [ Dragan Stancevic ]
  * multipath-tools: fix dm- device filtering
   - Allow filtering of DEV_UEVENT dev_type
   - Resolves LP: #1570093

 -- Louis Bouchard <email address hidden> Mon, 18 Jul 2016 12:37:04 +0200

Changed in multipath-tools (Ubuntu):
status: In Progress → Fix Released
Revision history for this message
Robie Basak (racb) wrote :

This bug needs SRU information before the fix can be uploaded to Xenial please. Some dep3 headers in the patch would be nice too.

Changed in multipath-tools (Ubuntu Xenial):
status: New → Incomplete
Revision history for this message
Louis Bouchard (louis) wrote :

rbasak: the uploader is to blame on this one :-/

For some reason, I uploaded the package with only a changelog entry ! I'll respin the upload while dragan-s completes the SRU template.

Dragan S. (dragan-s)
description: updated
Changed in multipath-tools (Debian):
status: New → Fix Released
Revision history for this message
Brian Murray (brian-murray) wrote : Please test proposed package

Hello Matt, or anyone else affected,

Accepted multipath-tools into xenial-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/multipath-tools/0.5.0+git1.656f8865-5ubuntu2.2 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-needed to verification-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

Changed in multipath-tools (Ubuntu Xenial):
status: Incomplete → Fix Committed
tags: added: verification-needed
Revision history for this message
Dragan S. (dragan-s) wrote :

Hi Brian-

I can confirm that after:
apt-get install multipath-tools/xenial-proposed

the messages below went away:

Aug 16 15:05:08 ubuntu-SRV-16-04-lp1570093 systemd[1]: Started Device-Mapper Multipath Device Controller.
Aug 16 15:05:08 ubuntu-SRV-16-04-lp1570093 multipath: dm-3: failed to get udev uid: Invalid argument
Aug 16 15:05:08 ubuntu-SRV-16-04-lp1570093 multipath: dm-3: failed to get sysfs uid: Invalid argument
Aug 16 15:05:08 ubuntu-SRV-16-04-lp1570093 multipath: dm-3: failed to get sgio uid: No such file or directory
Aug 16 15:05:08 ubuntu-SRV-16-04-lp1570093 multipath: dm-4: failed to get udev uid: Invalid argument
Aug 16 15:05:08 ubuntu-SRV-16-04-lp1570093 multipath: dm-4: failed to get sysfs uid: Invalid argument
Aug 16 15:05:08 ubuntu-SRV-16-04-lp1570093 multipath: dm-4: failed to get sgio uid: No such file or directory
Aug 16 15:05:08 ubuntu-SRV-16-04-lp1570093 multipath: dm-5: failed to get udev uid: Invalid argument
Aug 16 15:05:08 ubuntu-SRV-16-04-lp1570093 multipath: dm-5: failed to get sysfs uid: Invalid argument
Aug 16 15:05:08 ubuntu-SRV-16-04-lp1570093 multipath: dm-5: failed to get sgio uid: No such file or directory

Revision history for this message
Dragan S. (dragan-s) wrote :

Package version tested:

ubuntu-SRV-16-04-lp1570093:~$ apt-cache policy multipath-tools
multipath-tools:
  Installed: 0.5.0+git1.656f8865-5ubuntu2.2
  Candidate: 0.5.0+git1.656f8865-5ubuntu2.2
  Version table:
 *** 0.5.0+git1.656f8865-5ubuntu2.2 400
        400 http://archive.ubuntu.com/ubuntu xenial-proposed/main amd64 Packages
        100 /var/lib/dpkg/status
     0.5.0+git1.656f8865-5ubuntu2.1 500
        500 http://us.archive.ubuntu.com/ubuntu xenial-updates/main amd64 Packages
     0.5.0+git1.656f8865-5ubuntu2 500
        500 http://us.archive.ubuntu.com/ubuntu xenial/main amd64 Packages

tags: added: verification-done
removed: verification-needed
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package multipath-tools - 0.5.0+git1.656f8865-5ubuntu2.2

---------------
multipath-tools (0.5.0+git1.656f8865-5ubuntu2.2) xenial; urgency=medium

  * multipath-tools: fix dm- device filtering
   - Allow filtering of DEV_UEVENT dev_type
   - Resolves LP: #1570093

 -- Dragan Stancevic <email address hidden> Thu, 21 Jul 2016 11:16:44 +0200

Changed in multipath-tools (Ubuntu Xenial):
status: Fix Committed → Fix Released
Revision history for this message
Brian Murray (brian-murray) wrote : Update Released

The verification of the Stable Release Update for multipath-tools has completed successfully and the package has now been released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

Revision history for this message
Dragan S. (dragan-s) wrote :

test, ignore

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.