voki externalmedia embed code changed

Re-categorizing it as "high" as it's existing functionality that doesn't work anymore.

The link in this bug:
http://www.voki.com/site/pickup?scid=12647331&width=575&height=323&chsm=8c148a281882347e6b50d4d6c97b12fd

is seen as valid by Mahara - but the user would have got the error because they have a line return after the ? part of the URL.

On saying that there has been a change at Voki. The use of embeded links is now only available to paid subscribers.

A valid embed url should start with 'http://vhss.oddcast.com/' which is not part of the embed detection syntax in Mahara.

So we will need a correct embed code source example to try with to be able to fix this up

I was not able to find a valid URL example that starts with 'http://vhss.oddcast.com/' to test changes in the embed detection syntax.

I clicked on the "share" link on that URL that Robert posted. But it looks like the "embed" option for Voki is only available for paid subscribers. http://www.voki.com/site/create?VkId=12647331&chsm=8c148a281882347e6b50d4d6c97b12fd&share=sharing

Do we know anyone with a paid account we can use for testing?

Hm, or maybe we could email Voki tech support and ask them for a demo embed code?

Cecilia sent a mail, but hasn't had a reply yet.

Patch for "master" branch: https://reviews.mahara.org/7254

New embed voki code for testing:

<script language="JavaScript" type="text/javascript" src="//vhss-d.oddcast.com/voki_embed_functions.php"></script><script language="JavaScript" type="text/javascript">AC_Voki_Embed(400, 225,"229214fafa6be8368fd1c22a84ebdafe",13290141, 1, "", 0, 1);</script>

Old voki code for testing:

<script language="JavaScript" type="text/javascript" src="http://vhss-d.oddcast.com/voki_embed_functions.php"></script><script language="JavaScript" type="text/javascript">AC_Voki_Embed(300,400,"d6a26a6ac40f311927e1e42dfd0e5d34",2516612, 1, "", 0);</script>

Reviewed: https://reviews.mahara.org/7254
Committed: https://git.mahara.org/mahara/mahara/commit/207889a5e469f3f1ad9e78867855ca628cb57b44
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit 207889a5e469f3f1ad9e78867855ca628cb57b44
Author: Cecilia Vela Gurovic <email address hidden>
Date: Wed Nov 16 10:47:48 2016 +1300

Bug 1572825: added Voki html filter for embed code

Added new html custom filter to allow
voki embed code with javascript tags.

issue with the creation/edition of blocks:

Voki embed code its a javascript code that loads
js functions from a remote file and makes a call to a
AC_Voki_Embed() function

parameters:

function AC_Voki_Embed (width, height, chsm, sc,
transparent, bgcolor, returnFlag, playerType)

The number of parameter makes the difference between
old and new voki code. The old one will have only 7,
the new one will have one more.

The new embed code will have playerType = 1
The function uses an XMLHttpRequest to obtain the
new embed code. When we are loading the page,
there is no problem. But when we are editing or
creating the block, the the connection with the object
gets lost and the embed code is never loaded.
Solution found: reload the page after editing or adding
a block with new voki code.

The old voki code can have
returnFlag = 1 will return a string with the code
returnFlag = 0 will load the embed code in the page (by default)
In this last case, after the function creates the embed code,
it will call document.write('embed code')
if we are loading a page with the embed code, we have no problem
but if we have the page already loaded and we are editing the block
or creating it, the document.write will replace all the html
with the embed code.
Solution found: change parameter of the function so it returns
the code instead, then manually add it in the correct place
of the html.

behatnotneeded

Change-Id: Ieed00b6c6887715b707b8123082a1312f3db1d9c

Patch for "17.10_STABLE" branch: https://reviews.mahara.org/8310

Reviewed: https://reviews.mahara.org/8310
Committed: https://git.mahara.org/mahara/mahara/commit/4e4f4871d36a36325711ef8b24f6fa7e4ad4a954
Submitter: Robert Lyon (<email address hidden>)
Branch: 17.10_STABLE

commit 4e4f4871d36a36325711ef8b24f6fa7e4ad4a954
Author: Cecilia Vela Gurovic <email address hidden>
Date: Wed Nov 16 10:47:48 2016 +1300

Bug 1572825: added Voki html filter for embed code

Added new html custom filter to allow
voki embed code with javascript tags.

issue with the creation/edition of blocks:

Voki embed code its a javascript code that loads
js functions from a remote file and makes a call to a
AC_Voki_Embed() function

parameters:

function AC_Voki_Embed (width, height, chsm, sc,
transparent, bgcolor, returnFlag, playerType)

The number of parameter makes the difference between
old and new voki code. The old one will have only 7,
the new one will have one more.

The new embed code will have playerType = 1
The function uses an XMLHttpRequest to obtain the
new embed code. When we are loading the page,
there is no problem. But when we are editing or
creating the block, the the connection with the object
gets lost and the embed code is never loaded.
Solution found: reload the page after editing or adding
a block with new voki code.

The old voki code can have
returnFlag = 1 will return a string with the code
returnFlag = 0 will load the embed code in the page (by default)
In this last case, after the function creates the embed code,
it will call document.write('embed code')
if we are loading a page with the embed code, we have no problem
but if we have the page already loaded and we are editing the block
or creating it, the document.write will replace all the html
with the embed code.
Solution found: change parameter of the function so it returns
the code instead, then manually add it in the correct place
of the html.

behatnotneeded

Change-Id: Ieed00b6c6887715b707b8123082a1312f3db1d9c