Apt's bash completion is incomplete

Bug #1573547 reported by Svyatoslav Gryaznov
30
This bug affects 4 people
Affects Status Importance Assigned to Milestone
apt (Ubuntu)
Fix Released
Low
Unassigned
Xenial
Fix Released
Low
Unassigned

Bug Description

*** Original bug report ***

"build-dep" and "clean" apt options are missing in /usr/share/bash-completion/completions/apt file. Patch attached.

ProblemType: Bug
DistroRelease: Ubuntu 16.04
Package: apt 1.2.10ubuntu1
ProcVersionSignature: Ubuntu 4.4.0-21.37-generic 4.4.6
Uname: Linux 4.4.0-21-generic x86_64
ApportVersion: 2.20.1-0ubuntu2
Architecture: amd64
CurrentDesktop: Unity
Date: Fri Apr 22 14:25:54 2016
InstallationDate: Installed on 2016-04-21 (0 days ago)
InstallationMedia: Ubuntu 16.04 LTS "Xenial Xerus" - Release amd64 (20160420.1)
SourcePackage: apt
UpgradeStatus: No upgrade log present (probably fresh install)

*** SRU part ***

[Test case]
Check that options like build-dep and clean work.

Revision history for this message
Svyatoslav Gryaznov (nightuser) wrote :
Revision history for this message
Ubuntu Foundations Team Bug Bot (crichton) wrote :

The attachment "fix_apt_build-dep_clean.diff" seems to be a patch. If it isn't, please remove the "patch" flag from the attachment, remove the "patch" tag, and if you are a member of the ~ubuntu-reviewers, unsubscribe the team.

[This is an automated message performed by a Launchpad user owned by ~brian-murray, for any issues please contact him.]

tags: added: patch
Changed in apt (Ubuntu):
status: New → Triaged
importance: Undecided → Low
Revision history for this message
Mathew Hodson (mhodson) wrote :

/usr/share/bash-completion/completions/apt is provided by bash-completion in Trusty. Has this changed in Xenial? It doesn't look like bash-completion has changed at all, so is there a conflict where the two packages are trying to provide the same file?

Revision history for this message
Svyatoslav Gryaznov (nightuser) wrote :

Mathew Hodson (mathew-hodson), files in both packages don't have build-dep and clean completion, so this inconsistency is probably another bug.

Revision history for this message
Martin Pitt (pitti) wrote :

> /usr/share/bash-completion/completions/apt is provided by bash-completion in Trusty. Has this changed in Xenial?

$ dpkg -S /usr/share/bash-completion/completions/apt
apt: /usr/share/bash-completion/completions/apt

Apparently so.

I pinged Julian, I suppose we want to apply this straight in Debian's git, to avoid getting out of sync again (and this equally applies to Debian).

Revision history for this message
Julian Andres Klode (juliank) wrote :

Thanks for the patch, it was slightly incomplete though -- build-dep did not complete to source packages and a lot of other stuff was still missing.

I worked further on the whole thing, and as of
  https://anonscm.debian.org/cgit/apt/apt.git/commit/?id=5aba189
it seems to be reasonably complete, except that build-dep does not yet complete to directory names containing a debian/control file.

Revision history for this message
Martin Pitt (pitti) wrote :

Julian did a much more complete completion (SCNR) in https://anonscm.debian.org/cgit/apt/apt.git/commit/?id=5aba189 .

Thus unsubscribing sponsors.

Changed in apt (Ubuntu):
status: Triaged → Fix Committed
Revision history for this message
Julian Andres Klode (juliank) wrote :

This is now in 1.2.13 which is the next upstream micro release to be uploaded to xenial.

Revision history for this message
Julian Andres Klode (juliank) wrote :

And in 1.3~exp2 which will hit yakkety soon.

description: updated
Revision history for this message
Julian Andres Klode (juliank) wrote :

See bug 1592171 for the yakkety sync request.

Revision history for this message
Julian Andres Klode (juliank) wrote :

We should skip 1.2.12 due to a regression in the proxy auto detection command. 1.2.13 should follow shortly.

Revision history for this message
Julian Andres Klode (juliank) wrote :

Sorry, we skip 1.2.13, and wait for 1.2.14. Coming soon!

Revision history for this message
Julian Andres Klode (juliank) wrote :

Moving the rest of the SRU to bug 1595177

description: updated
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package apt - 1.3~pre2ubuntu4

---------------
apt (1.3~pre2ubuntu4) yakkety; urgency=medium

  * Cherry-pick the following commits from rebased branch:
    - gpgv: Unlink the correct temp file in error case
    - Allow to specify - as APT_CONFIG for stdin
    - gpgv: Pass current config to apt-key on a file-based stdin
   [This partially reverts ubuntu3]
   (LP: #1607283)

 -- Julian Andres Klode <email address hidden> Wed, 03 Aug 2016 14:52:04 +0000

Changed in apt (Ubuntu):
status: Fix Committed → Fix Released
Mathew Hodson (mhodson)
Changed in apt (Ubuntu Xenial):
importance: Undecided → Low
Mathew Hodson (mhodson)
Changed in apt (Ubuntu Xenial):
status: New → Fix Committed
Revision history for this message
Launchpad Janitor (janitor) wrote :
Download full text (3.1 KiB)

This bug was fixed in the package apt - 1.2.15

---------------
apt (1.2.15) xenial; urgency=medium

  New micro release with bug fixes up to (and including) 1.3.1 (LP: #1638021)

  [ Julian Andres Klode ]
  * methods/ftp: Cope with weird PASV responses.
    Thanks to Lukasz Stelmach for the initial patch (Closes: #420940)
  * Fix buffer overflow in debListParser::VersionHash() (Closes: #828812)
  * cache: Bump minor version to 6
  * indextargets: Check that cache could be built before using it
    (Closes: #829651)
  * gpgv: Unlink the correct temp file in error case
  * fileutl: empty file support: Avoid fstat() on -1 fd and check result
  * Ignore SIGINT and SIGQUIT for Pre-Install hooks
  * install-progress: Call the real ::fork() in our fork() method
  * Accept --autoremove as alias for --auto-remove
  * apt-inst: debfile: Pass comp. Name to ExtractTar, not Binary
  * changelog: Respect Dir setting for local changelog getting
  * Fix segfault and out-of-bounds read in Binary fields
  * Merge translations from 1.3~rc3
  * TagFile: Fix off-by-one errors in comment stripping
  * Base256ToNum: Fix uninitialized value
  * VersionHash: Do not skip too long dependency lines
  * Do not read stderr from proxy autodetection scripts

  [ Nicolas Le Cam ]
  * Use the ConditionACPower feature of systemd in the apt-daily service
    (Closes: #827930)

  [ David Kalnischkies ]
  * close server if parsing of header field failed
  * don't do atomic overrides with failed files (Closes: 828908)
  * if reading of autobit state failed, let write fail
  * write auto-bits before calling dpkg & again after if needed
  * factor out Pkg/DepIterator prettyprinters into own header
  * protect only the latest same-source providers from autoremove
  * reinstalling local deb file is no downgrade
  * do not treat same-version local debs as downgrade
  * avoid 416 response teardown binding to null pointer
  * don't change owner/perms/times through file:// symlinks
  * report all instead of first error up the acquire chain
  * keep trying with next if connection to a SRV host failed
  * call flush on the wrapped writebuffered FileFd
  * verify hash of input file in rred
  * use proper warning for automatic pipeline disable
  * rred: truncate result file before writing to it (Closes: #831762)
  * if the FileFd failed already following calls should fail, too
  * pass --force-remove-essential to dpkg only if needed
  * allow user@host (aka: no password) in URI parsing
  * drop incorrect const attribute from DirectoryExists (LP: 1473674)
  * http(s): allow empty values for header fields (Closes: 834048)
  * don't try pipelining if server closes connections (Closes: #832113)
  * don't loop on pinning pkgs from absolute debs by regex (Closes: 835818)
  * try not to call memcpy with length 0 in hash calculations
  * abort connection on '.' target replies in SRV

  [ Andrew Patterson ]
  * Add kernels with "+" in the package name to APT::NeverAutoRemove
    (Closes: #830159)

  [ Mert Dirik ]
  * Turkish program translation update (Closes: 832039)

  [ Zhou Mo ]
  * zh_CN.po: update simplified chinese translation

 -- Julian Andres Klode <email address hidden> Mon, 31 Oct 2016 15...

Read more...

Changed in apt (Ubuntu Xenial):
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.