Ubuntu
xorg package

Superfluous Xsession.d script: 60x11-common_localhost

Bug #1576454 reported by Forest
20
This bug affects 2 people
Affects Status Importance Assigned to Milestone
xorg (Ubuntu)
Fix Released
Low
Unassigned

Bug Description

Both of these scripts do the same thing, and both are installed by x11-common:

/etc/X11/Xsession.d/35x11-common_xhost-local
/etc/X11/Xsession.d/60x11-common_localhost

35x11-common_xhost-local is present in debian, while 60x11-common_localhost is not. I suspect the latter should be removed.

Tags: focal patch
Forest (foresto)
summary: - Duplicate Xsession.d script: 60x11-common_localhost
+ Superfluous Xsession.d script: 60x11-common_localhost
Daniel van Vugt (vanvugt)
tags: added: focal
Revision history for this message
Launchpad Janitor (janitor) wrote :

Status changed to 'Confirmed' because the bug affects multiple users.

Changed in xorg (Ubuntu):
status: New → Confirmed
Daniel van Vugt (vanvugt)
Changed in xorg (Ubuntu):
importance: Undecided → Low
Revision history for this message
Stefan Puiu (stefanpuiuro) wrote :

I think both files come from Debian. I did an 'apt-get source x11-common' and I see that debian/x11-common.install installs stuff from debian/local/Xsession.d. I see both files there:

stefan@spuiu-vm:~/src/ubuntu/xorg-7.7+19ubuntu14$ grep -rn xhost debian/local/Xsession.d/
debian/local/Xsession.d/35x11-common_xhost-local:3:# If xhost (from x11-xserver-utils) is installed, use it to give access
debian/local/Xsession.d/35x11-common_xhost-local:5:# Unlike other uses of xhost, this is safe since the kernel can check
debian/local/Xsession.d/35x11-common_xhost-local:8:if type xhost >/dev/null 2>&1; then
debian/local/Xsession.d/35x11-common_xhost-local:9: xhost +si:localuser:$(id -un) || :
debian/local/Xsession.d/60x11-common_localhost:3:[ -x /usr/bin/xhost ] && [ -x /usr/bin/id ] &&
debian/local/Xsession.d/60x11-common_localhost:4: xhost +si:localuser:`id -un` > /dev/null

Revision history for this message
Stefan Puiu (stefanpuiuro) wrote :

... or maybe not, since I don't see the file in the Debian git repo (from the Vcs-Git field in from debian/control from the Ubuntu source):

https://salsa.debian.org/xorg-team/xorg/-/tree/debian-unstable/debian/local/Xsession.d

Revision history for this message
Stefan Puiu (stefanpuiuro) wrote :

Attached a patch against https://salsa.debian.org/xorg-team/xorg/-/tree/ubuntu; not sure if this is the right repo, but it does have the offending change/file.

Revision history for this message
Ubuntu Foundations Team Bug Bot (crichton) wrote :

The attachment "0001-Revert-Seems-when-this-was-renamed-it-fell-out-of-gi.patch" seems to be a patch. If it isn't, please remove the "patch" flag from the attachment, remove the "patch" tag, and if you are a member of the ~ubuntu-reviewers, unsubscribe the team.

[This is an automated message performed by a Launchpad user owned by ~brian-murray, for any issues please contact him.]

tags: added: patch
Revision history for this message
Timo Aaltonen (tjaalton) wrote :

fixed in git now

Changed in xorg (Ubuntu):
status: Confirmed → In Progress
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package xorg - 1:7.7+19ubuntu15

---------------
xorg (1:7.7+19ubuntu15) groovy; urgency=medium

  * debian/local/Xsession.d/60x11-common_localhost: Dropped, it's
    provided by 35x11-common_xhost-local now. (LP: #1576454)

 -- Timo Aaltonen <email address hidden> Fri, 09 Oct 2020 11:17:12 +0300

Changed in xorg (Ubuntu):
status: In Progress → Fix Released
Revision history for this message
Stefan Puiu (stefanpuiuro) wrote :

Thanks for fixing this!

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.