[SRU] nm-applet crash with assertion failed for some users

StacktraceTop:
 g_assertion_message () from /tmp/apport_sandbox_pQFGFj/lib/x86_64-linux-gnu/libglib-2.0.so.0
 g_assertion_message_expr () from /tmp/apport_sandbox_pQFGFj/lib/x86_64-linux-gnu/libglib-2.0.so.0
 applet_get_first_active_vpn_connection (applet=applet@entry=0xdb83b0, out_state=out_state@entry=0x7ffed302fd74) at applet.c:1108
 applet_update_icon (user_data=<optimized out>) at applet.c:2838
 g_main_context_dispatch () from /tmp/apport_sandbox_pQFGFj/lib/x86_64-linux-gnu/libglib-2.0.so.0

Thank you for taking the time to report this bug and helping to make Ubuntu better. The issue you are reporting is an upstream one and it would be nice if somebody having it could send the bug to the developers of the software by following the instructions at https://wiki.ubuntu.com/Bugs/Upstream/GNOME. If you have done so, please tell us the number of the upstream bug (or the link), so we can add a bugwatch that will inform us about its status. Thanks in advance.

I hvae reported this bug here, where I am adding information in response to questions:

https://bugzilla.gnome.org/show_bug.cgi?id=765830

Upstream indicated that it should be fixed since 1.1.92 which is in the version in xenial ... do you still get the issue?

https://errors.ubuntu.com/problem/fbb9b6d4d62fefcb267876cca8cd69bda2fbb598 suggests it's not fixed, upstream did more changes and removed the assert since though so that might be better

It is not fixed for me. I have proposed-updates and the network-manager version is 1.2.0-0ubuntu0.16.04.2

Please upload the fix to yakkety too.

Hello Tim, or anyone else affected,

Accepted network-manager-applet into xenial-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/network-manager-applet/1.2.0-0ubuntu0.16.04.2 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-needed to verification-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

The bug is fixed. No more assertion, no more crash.
A message informs me that the wired connection is now established.
Then the next message says that the "ethernet" connection is disconnected. Despite that final message, the change from VPN to normal wired connection now works fine.

Thanks, the error dialog could be worth a new bug

Hello Tim, or anyone else affected,

Accepted network-manager-applet into xenial-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/network-manager-applet/1.2.0-0ubuntu0.16.04.3 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-needed to verification-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

This is good for me, setting tag to verification-done.

This bug was fixed in the package network-manager-applet - 1.2.0-0ubuntu0.16.04.3

---------------
network-manager-applet (1.2.0-0ubuntu0.16.04.3) xenial; urgency=medium

  * debian/patches/apple-set-out_icon_name-for-WWAN-connections-for-ind.patch:
    use available gsm-3g-* icons so that the icon for mobile is different than
    that used for wifi; to avoid confusing people. (LP: #1571574)

network-manager-applet (1.2.0-0ubuntu0.16.04.2) xenial; urgency=medium

  * cherry-pick upstream patches from post 1.2.2:
    - wireless-security-fix-failed-assertion-in-default_fi.patch:
      Fix TLS cert authentication (LP: #1575614)
    - wireless-security-return-error-on-eap_method_validat.patch:
      Return error on eap_method_validate_filepicker() failure
    - applet-remove-assert-s_con-from-applet_get_active_vp.patch
      Remove the assert which lead to many false assertions (LP: #1578962)
    - apple-set-out_icon_name-for-WWAN-connections-for-ind.patch
      WWAN icon should appear when the connection is activated (LP: #1571574)

 -- Mathieu Trudel-Lapierre <email address hidden> Wed, 01 Jun 2016 15:15:49 -0400

The verification of the Stable Release Update for network-manager-applet has completed successfully and the package has now been released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

Added to Trello: https://trello.com/c/dejtgyOs/11-bug-1578962-sru-nm-applet-crash-with-assertion-failed-for-some-users

This bug was fixed in the package network-manager-applet - 1.2.2-0ubuntu1

---------------
network-manager-applet (1.2.2-0ubuntu1) yakkety; urgency=medium

  * Rebase to upstream stable point release (LP: #1578962)
  * Use git-pq to manage patches.
  * Patches updated:
    - Make-sure-the-behavior-for-policykit-restricted-acti.patch
    - Implement-support-for-hiding-rather-than-desensitizi.patch
  * cherry-pick from upstream post release
    - wireless-security-fix-failed-assertion-in-default_fi.patch
    - wireless-security-return-error-on-eap_method_validat.patch
    - applet-remove-assert-s_con-from-applet_get_active_vp.patch
    - apple-set-out_icon_name-for-WWAN-connections-for-ind.patch
  * Patches dropped:
    - tests-run-tests-on-make-check.patch: merged upstream

 -- Aron Xu <email address hidden> Fri, 20 May 2016 18:09:18 +0800