octavia

Incorrect exception raise in HAproxy driver

Bug #1583558 reported by Aviv
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
octavia
Fix Released
Medium
Aviv

Bug Description

File - octavia/amphorae/drivers/haproxy/rest_api_driver.py
Class AmphoraAPIClient
Method - request

exception driver_except.TimeOutException() is unreachable due to incorrect condition statement:
   a >= CONF.haproxy_amphora.connection_max_retries
   ("a" var never reaches connection_max_retries)

Aviv (avivle)
Changed in octavia:
assignee: nobody → Aviv (avivle)
Aviv (avivle)
Changed in octavia:
status: New → In Progress
Michael Johnson (johnsom)
Changed in octavia:
importance: Undecided → Medium
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to octavia (master)

Reviewed: https://review.openstack.org/319644
Committed: https://git.openstack.org/cgit/openstack/octavia/commit/?id=8474c60e85114a2df87658afb440b868c3eaecbc
Submitter: Jenkins
Branch: master

commit 8474c60e85114a2df87658afb440b868c3eaecbc
Author: Aviv <email address hidden>
Date: Thu May 19 16:59:59 2016 +0300

    Fix unreachable TimeOutException bug in amphora driver

    Faulty logic in the amphora REST API driver prevented a TimeOutException from being thrown when appropriate.
    This commit fixes this bug and adds a unit test to ensure proper behavior.

    Closes-Bug: 1583558

    Change-Id: I8b8ddbf8ac93c51ad15b4c5d107138913be25bbf

Changed in octavia:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to octavia (stable/mitaka)

Fix proposed to branch: stable/mitaka
Review: https://review.openstack.org/350381

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to octavia (stable/liberty)

Fix proposed to branch: stable/liberty
Review: https://review.openstack.org/351015

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to octavia (stable/mitaka)

Reviewed: https://review.openstack.org/350381
Committed: https://git.openstack.org/cgit/openstack/octavia/commit/?id=d1f067b83e6c419d22881f78315ce7076cb6f7f9
Submitter: Jenkins
Branch: stable/mitaka

commit d1f067b83e6c419d22881f78315ce7076cb6f7f9
Author: Aviv <email address hidden>
Date: Thu May 19 16:59:59 2016 +0300

    Fix unreachable TimeOutException bug in amphora driver

    Faulty logic in the amphora REST API driver prevented a TimeOutException from being thrown when appropriate.
    This commit fixes this bug and adds a unit test to ensure proper behavior.

    Closes-Bug: 1583558

    Change-Id: I8b8ddbf8ac93c51ad15b4c5d107138913be25bbf
    (cherry picked from commit 8474c60e85114a2df87658afb440b868c3eaecbc)

tags: added: in-stable-mitaka
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to octavia (stable/liberty)

Reviewed: https://review.openstack.org/351015
Committed: https://git.openstack.org/cgit/openstack/octavia/commit/?id=cedfd3db831554d7dd4d5665cdb3c5b0db366db7
Submitter: Jenkins
Branch: stable/liberty

commit cedfd3db831554d7dd4d5665cdb3c5b0db366db7
Author: Aviv <email address hidden>
Date: Thu May 19 16:59:59 2016 +0300

    Fix unreachable TimeOutException bug in amphora driver

    Faulty logic in the amphora REST API driver prevented a TimeOutException from being thrown when appropriate.
    This commit fixes this bug and adds a unit test to ensure proper behavior.

    Closes-Bug: 1583558

    Change-Id: I8b8ddbf8ac93c51ad15b4c5d107138913be25bbf
    (cherry picked from commit 8474c60e85114a2df87658afb440b868c3eaecbc)

tags: added: in-stable-liberty
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/octavia 0.9.0

This issue was fixed in the openstack/octavia 0.9.0 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/octavia 0.8.1

This issue was fixed in the openstack/octavia 0.8.1 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.