ipmi sel time set is setting 30 mins less than given time in OOB, and 30 mins more than given time in in-band method (ipmitool)

Bug #1586048 reported by bugproxy
14
This bug affects 1 person
Affects Status Importance Assigned to Milestone
ipmitool (Ubuntu)
Fix Released
Undecided
Mathieu Trudel-Lapierre
Xenial
Fix Released
Undecided
Mathieu Trudel-Lapierre

Bug Description

[Impact]
Setting time via ipmi (inband or out of band) between systems that aren't on the same timezone where the timezone is stepped by the minute (as opposed to the typical stepping by hour in many timezones).

[Test Case]
See below: '---Steps to Reproduce---'.

[Regression potential]
Minimal, this adds comparing the minutes as well as hour for timezone differences. If timezone data was inconsistent or broken where the timezone should be stepped by the hour and actually includes a minute difference; it may be seen that the time value set as a result of the 'ipmitool sel time' commands would differ from the value passed to the command.

---

== Comment: #0 - Mukesh K. Ojha <email address hidden> - 2016-05-09 13:50:48 ==
---Problem Description---
ipmi sel time set is setting 30 mins less than given time in OOB, and 30 mins more than given time in in-band method (ipmitool)

---uname output---
Ubuntu 16.04

Machine Type = All Power System

---Debugger---
A debugger is not configured

---Steps to Reproduce---
  Install a Open Power Firmware(OP810) on BMC machine and try to set sel time using ipmitool.

ipmi sel time set is setting 30 mins less than given time in Out-of-band(OOB), and 30 mins more than given time in in-band method.

Here there are two problems
1. sel time set function setting time incorrectly.
2. same ipmi command behaves differently in in-band and out-of-band.

[pridhiviraj@localhost sl_ga]$ ipmitool -I lanplus -H 9.3.23.199 -U ADMIN -P admin sel time get
03/02/2016 11:43:07
[pridhiviraj@localhost sl_ga]$ ipmitool -I lanplus -H 9.3.23.199 -U ADMIN -P admin sel time set "03/02/2016 11:43:07"
03/02/2016 11:13:07
[pridhiviraj@localhost sl_ga]$
[pridhiviraj@localhost sl_ga]$ ipmitool -I lanplus -H 9.3.23.199 -U ADMIN -P admin sel time get
03/02/2016 11:15:20

Here we can observe in OOB method sel time set is setting 30 minutes less than given time.

This is tried on a machine which is having custom firmware for SL GA2 testing.

Tried on another machine having OP810 firmware, same problem appears.
[pridhiviraj@localhost sl_ga]$ ipmitool -I lanplus -H 9.47.70.200 -U ADMIN -P admin sel time get
02/20/2014 23:51:35
[pridhiviraj@localhost sl_ga]$ ipmitool -I lanplus -H 9.47.70.200 -U ADMIN -P admin sel time set "02/20/2014 23:51:35"
02/20/2014 23:21:35
[pridhiviraj@localhost sl_ga]$

Try to set sel time using in-band method:
[root@ite037 ~]# ipmitool sel time get
03/02/2016 11:06:55
[root@ite037 ~]# ipmitool sel time set "03/02/2016 11:06:55"
03/02/2016 11:36:55
[root@ite037 ~]#
[root@ite037 ~]#
[root@ite037 ~]# ipmitool sel time get
03/02/2016 11:37:17
[root@ite037 ~]#

Contact Information = <email address hidden>

Userspace tool common name: ipmitool

The userspace tool has the following bit modes: both

Userspace package: ipmitool

Userspace tool obtained from project website: na

*Additional Instructions for <email address hidden>:
-Attach ltrace and strace of userspace application.

== Comment: #7 - Breno Henrique Leitao <email address hidden> - 2016-05-25 14:55:13 ==
Canonical,

The solution for this problem is a fix already accepted upstream on commit:

 * c7169bc27ee407206e768dece2c3f026e02aee02

git://git.code.sf.net/p/ipmitool/source

bugproxy (bugproxy)
tags: added: architecture-ppc64le bugnameltc-141165 severity-high targetmilestone-inin16041
Changed in ubuntu:
assignee: nobody → Taco Screen team (taco-screen-team)
affects: ubuntu → ipmitool (Ubuntu)
Steve Langasek (vorlon)
Changed in ipmitool (Ubuntu Xenial):
status: New → Triaged
Changed in ipmitool (Ubuntu):
assignee: Taco Screen team (taco-screen-team) → Mathieu Trudel-Lapierre (cyphermox)
Changed in ipmitool (Ubuntu Xenial):
assignee: nobody → Mathieu Trudel-Lapierre (cyphermox)
Changed in ipmitool (Ubuntu):
status: New → Triaged
Revision history for this message
Mathieu Trudel-Lapierre (cyphermox) wrote :

This is already fixed in yakkety.

Changed in ipmitool (Ubuntu):
status: Triaged → Fix Released
Changed in ipmitool (Ubuntu Xenial):
status: Triaged → In Progress
description: updated
Revision history for this message
bugproxy (bugproxy) wrote : Comment bridged from LTC Bugzilla

------- Comment From <email address hidden> 2016-05-27 02:27 EDT-------
(In reply to comment #10)
> This is already fixed in yakkety.

Thanks! Can you pull this changes to 16.04 LTS release as well?

-Vasant

tags: added: targetmilestone-inin1610
removed: targetmilestone-inin16041
Revision history for this message
Timo Aaltonen (tjaalton) wrote : Please test proposed package

Hello bugproxy, or anyone else affected,

Accepted ipmitool into xenial-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/ipmitool/1.8.16-3ubuntu0.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-needed to verification-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

Changed in ipmitool (Ubuntu Xenial):
status: In Progress → Fix Committed
tags: added: verification-needed
Revision history for this message
bugproxy (bugproxy) wrote : Comment bridged from LTC Bugzilla

------- Comment From <email address hidden> 2016-05-30 13:02 EDT-------
*** Bug 141725 has been marked as a duplicate of this bug. ***

Revision history for this message
Mathieu Trudel-Lapierre (cyphermox) wrote :

Vasant,

Can you do the necessary testing for the update? The last comment from Timo here explains how to do it; you'll need to enable the -proposed repository on the system to get the new package.

Revision history for this message
bugproxy (bugproxy) wrote :
Download full text (6.3 KiB)

------- Comment From <email address hidden> 2016-06-01 04:16 EDT-------
(In reply to comment #12)
> Hello bugproxy, or anyone else affected,
>
> Accepted ipmitool into xenial-proposed. The package will build now and be
> available at https://launchpad.net/ubuntu/+source/ipmitool/1.8.16-3ubuntu0.1
> in a few hours, and then in the -proposed repository.
>
> Please help us by testing this new package. See
> https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to
> enable and use -proposed. Your feedback will aid us getting this update out
> to other Ubuntu users.
>
> If this package fixes the bug for you, please add a comment to this bug,
> mentioning the version of the package you tested, and change the tag from
> verification-needed to verification-done. If it does not fix the bug for
> you, please add a comment stating that, and change the tag to
> verification-failed. In either case, details of your testing will help us
> make a better decision.
>
> Further information regarding the verification process can be found at
> https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in
> advance!

Hi tjaalton,

Please find the detail below verification steps.

mukesh@ubuntu:~$ ipmitool -V
The program 'ipmitool' is currently not installed. You can install it by typing:
sudo apt install ipmitool

mukesh@ubuntu:~$ sudo apt-get install ipmitool/xenial-proposed
Reading package lists... Done
Building dependency tree
Reading state information... Done
Selected version '1.8.16-3ubuntu0.1' (Ubuntu:16.04/xenial-proposed [ppc64el]) for 'ipmitool'
The following additional packages will be installed:
freeipmi-common libfreeipmi16 libopenipmi0 libsensors4 libsnmp-base
libsnmp30 libwrap0 openipmi tcpd
Suggested packages:
freeipmi-tools lm-sensors snmp-mibs-downloader
The following NEW packages will be installed:
freeipmi-common ipmitool libfreeipmi16 libopenipmi0 libsensors4 libsnmp-base
libsnmp30 libwrap0 openipmi tcpd
0 upgraded, 10 newly installed, 0 to remove and 56 not upgraded.
Need to get 2,839 kB of archives.
After this operation, 15.8 MB of additional disk space will be used.
Do you want to continue? [Y/n] y
Get:1 http://ports.ubuntu.com/ubuntu-ports xenial-proposed/universe ppc64el ipmitool ppc64el 1.8.16-3ubuntu0.1 [375 kB]
Get:2 http://in.ports.ubuntu.com/ubuntu-ports xenial/main ppc64el libwrap0 ppc64el 7.6.q-25 [47.1 kB]
Get:3 http://in.ports.ubuntu.com/ubuntu-ports xenial/main ppc64el freeipmi-common all 1.4.11-1ubuntu1 [175 kB]
Get:4 http://in.ports.ubuntu.com/ubuntu-ports xenial/main ppc64el libfreeipmi16 ppc64el 1.4.11-1ubuntu1 [771 kB]
Get:5 http://in.ports.ubuntu.com/ubuntu-ports xenial/main ppc64el libopenipmi0 ppc64el 2.0.18-0ubuntu11 [386 kB]
Get:6 http://in.ports.ubuntu.com/ubuntu-ports xenial/main ppc64el libsensors4 ppc64el 1:3.4.0-2 [28.9 kB]
Get:7 http://in.ports.ubuntu.com/ubuntu-ports xenial/main ppc64el libsnmp-base all 5.7.3+dfsg-1ubuntu4 [224 kB]
Get:8 http://in.ports.ubuntu.com/ubuntu-ports xenial/main ppc64el libsnmp30 ppc64el 5.7.3+dfsg-1ubuntu4 [692 kB]
Get:9 http://in.ports.ubuntu.com/ubuntu-ports xenial/main ppc64el openipmi ppc64el 2.0.18-0ubuntu11 [119 kB]
Get:10 http://in.ports.ubuntu.com/ubun...

Read more...

tags: added: verification-done
removed: verification-needed
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package ipmitool - 1.8.16-3ubuntu0.1

---------------
ipmitool (1.8.16-3ubuntu0.1) xenial; urgency=medium

  * debian/patches/fix_set_time_set_c7169bc2.patch: take into account minute
    differences between timezones (for those timezones that don't go just by
    an hour, but also specify a delta of :15 or :30 minutes, for instance).
    (LP: #1586048)

 -- Mathieu Trudel-Lapierre <email address hidden> Thu, 26 May 2016 17:24:11 -0400

Changed in ipmitool (Ubuntu Xenial):
status: Fix Committed → Fix Released
Revision history for this message
Chris J Arges (arges) wrote : Update Released

The verification of the Stable Release Update for ipmitool has completed successfully and the package has now been released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.