Unable to remove first auth method via institution edit
Bug #1595364 reported by
Robert Lyon
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Mahara |
Fix Released
|
Medium
|
Robert Lyon | ||
15.10 |
Fix Released
|
Medium
|
Unassigned | ||
16.04 |
Fix Released
|
Medium
|
Unassigned | ||
16.10 |
Fix Released
|
Medium
|
Robert Lyon |
Bug Description
There is a bug in the code that stops one from removing the first option from auth methods for an institution
This is due to the way we are using jQuery.remove()
Get the console error:
TypeError: elem is null
while ((child = elem.firstChild)) {
Due to: instances.remove(i)
when i = 1 or above it removes the row relating to the count before rebuilding the rows but when i = 0 it removes all the rows and so nothing to rebuild
Will fix this up so it actually removes the row relating to the id
Changed in mahara: | |
milestone: | none → 16.10.0 |
Changed in mahara: | |
milestone: | 16.10.0 → none |
Changed in mahara: | |
status: | Fix Committed → Fix Released |
To post a comment you must log in.
Patch for "master" branch: https:/ /reviews. mahara. org/6612