errinjct tool error while running EEH tests (powerpc-utils)
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| powerpc-utils (Ubuntu) |
Fix Released
|
Medium
|
Adam Conrad | ||
| Xenial |
Fix Released
|
Medium
|
Steve Langasek | ||
Bug Description
[SRU Justification]
The errinjct tool cannot run EEH tests on certain systems. This is a relatively low priority hardware enablement SRU (low priority because the tool in question is a test tool only).
[Test case]
1. On a Shiner-T or Grand Canyon system, run the command: sudo errinjct eeh -v -f 6 -s net/enp1s0d0 -a 0x82100000 -m 0x0000FFFFFF800000
2. Verify that this returns an error.
3. Enable xenial-proposed, and upgrade powerpc-utils.
4. Rerun the errinjct command. Verify that it now succeeds.
[Regression potential]
Minimal; this is a test tool only so any regressions will be low impact, and the upstream changes that have been cherry-picked are reasonably limited in scope.
== Comment: #0 - Manvanthara B. Puttashankar - 2016-06-29 01:40:42 ==
---Problem Description---
errinjct tool error while running EEH tests (powerpc-utils)
---uname output---
Linux ltciofvtr-
Machine Type = s822l
---Steps to Reproduce---
errinjct tool needs to pick two patch to address the below error
errinjct eeh -v -f 6 -s net/eth1 -a 0xde000000 -m 0x0000FFFFFF800000
Injecting an ioa-bus-error with the following data:
BUS ADDR: de000000
ADDR MASK: ffffff800000
CONFIG ADDR: 900000
PHB UNIT_ID: 800000020000135
FUNCTION: 6
Store to PCI Memory Address Space - inject an Adress Parity Error
errinjct: Could not open RTAS error injection facility
errinjct: librtas returned an unknown error code (-50331649) for function ioa-bus-error
Parent bug: Bug 121866 : EEH via errinjct tool fails with librtas error in Ubuntu 16.04 (Shiner-T & Grand Canyon)
errinjct issues will be solved with multiple patches 1 librtas + 2 errijnct.
Based on suggestion from developer in Bug 121866 reporting this specific issue to powerpc-utils package , two patch needs to be picked by canonical.
Note: have verified the powerpc-utils for 16.04.01 , the patch hasn't gone into yet.
upstream patch fix link: https:/
Userspace tool common name: errinjct
The userspace tool has the following bit modes: ppc64le
Userspace rpm: powerpc-utils
== Comment: #1 - Manvanthara B. Puttashankar <email address hidden> - 2016-06-29 01:48:02 ==
commits to be picked up
commit 386a07c4dc6c09d
Author: Nathan Fontenot <email address hidden>
Date: Tue May 24 16:32:39 2016 -0400
errinjct: Correct read_file() error checking
When reading files from syfs the file length returned from a stat()
call does not always match the actual length of the file. The read_file()
routine should be checking for an error return from the read() call
instead of checking that the amount read matches the file length returned
from a stat() call.
Signed-off-by: Nathan Fontenot <email address hidden>
commit 42b83884bfb51c0
Author: Nathan Fontenot <email address hidden>
Date: Tue May 24 16:31:37 2016 -0400
errinjct: Recognize -5 return from rtas
Update the errinjct command to recognize the rturn code of -5 from
rtas indicating that PCI error injection is not enabled.
Signed-off-by: Nathan Fontenot <email address hidden>
commit ab848a8d5cc4c4b
Author: Nathan Fontenot <email address hidden>
Date: Tue May 24 16:30:33 2016 -0400
errinjct: Correct config_addr parsing
A recent patch (commit id: ccc9c72cec2a4) to move the errinjct function to
using a common read_file() routine did not correctly update the
get_
proper config address.
Signed-off-by: Nathan Fontenot <email address hidden>
| tags: | added: architecture-ppc64le bugnameltc-143197 severity-critical targetmilestone-inin--- |
| Changed in ubuntu: | |
| assignee: | nobody → Taco Screen team (taco-screen-team) |
| affects: | ubuntu → powerpc-utils (Ubuntu) |
| Steve Langasek (vorlon) wrote | #1 |
| Changed in powerpc-utils (Ubuntu): | |
| assignee: | Taco Screen team (taco-screen-team) → Adam Conrad (adconrad) |
| importance: | Undecided → Medium |
| status: | New → Triaged |
| bugproxy (bugproxy) wrote Comment bridged from LTC Bugzilla | #2 |
| bugproxy (bugproxy) wrote | #3 |
| Adam Conrad (adconrad) wrote | #4 |
| Adam Conrad (adconrad) wrote | #5 |
| Changed in powerpc-utils (Ubuntu): | |
| status: | Triaged → Fix Released |
| bugproxy (bugproxy) wrote | #6 |
| Steve Langasek (vorlon) wrote Re: [Bug 1597365] Comment bridged from LTC Bugzilla | #7 |
| bugproxy (bugproxy) wrote Comment bridged from LTC Bugzilla | #8 |
| bugproxy (bugproxy) wrote | #9 |
| tags: |
added: targetmilestone-inin16042 removed: targetmilestone-inin--- |
| bugproxy (bugproxy) wrote | #10 |
| bugproxy (bugproxy) wrote | #11 |
| description: | updated |
| Changed in powerpc-utils (Ubuntu Xenial): | |
| importance: | Undecided → Medium |
| status: | New → In Progress |
| assignee: | nobody → Steve Langasek (vorlon) |
| Brian Murray (brian-murray) wrote Please test proposed package | #12 |
| Changed in powerpc-utils (Ubuntu Xenial): | |
| status: | In Progress → Fix Committed |
| tags: | added: verification-needed |
| tags: |
added: verification-done removed: verification-needed |
| Brian Murray (brian-murray) wrote | #13 |
| tags: |
added: verification-needed removed: verification-done |
| Steve Langasek (vorlon) wrote | #14 |
| Breno Leitão (breno-leitao) wrote | #15 |
| Launchpad Janitor (janitor) wrote | #16 |
| Changed in powerpc-utils (Ubuntu Xenial): | |
| status: | Fix Committed → Fix Released |
Triaging as 'medium', not the critical indicated in the bug tags. This is a test utility whose failure has no runtime impact on the system.