Group shortname should be unique across the entier site not just per institution

Bug #1600126 reported by Ghada El-Zoghbi
10
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Mahara
Fix Released
High
Unassigned
16.10
Fix Released
High
Unassigned

Bug Description

Mahara: master
OS: Linux
Browser: Firefox
DB: Postgres

With the new functionality to update shortname for manually created groups (i.e. institution = No institution), we should ensure that the shortname is unique across all institutions.

We've had a situation where the users created a group manually. Then tried to updated it through the csv upload - for their default institution. They get an error that the group does not exist.

It's very confusing for the users.

We should update the unique index in the db to be only on the shortname column instead of shortname + institution.

Changed in mahara:
status: New → Confirmed
importance: Undecided → High
milestone: none → 16.10.0
Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "master" branch: https://reviews.mahara.org/7128

Robert Lyon (robertl-9)
Changed in mahara:
status: Confirmed → In Progress
Robert Lyon (robertl-9)
Changed in mahara:
milestone: 16.10.0 → 16.10.1
Robert Lyon (robertl-9)
Changed in mahara:
milestone: 16.10.1 → 17.04.0
Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/7128
Committed: https://git.mahara.org/mahara/mahara/commit/711f4f0efe68bd1e8cc5aec44a01068f22f453f5
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit 711f4f0efe68bd1e8cc5aec44a01068f22f453f5
Author: Robert Lyon <email address hidden>
Date: Mon Oct 17 12:16:44 2016 +1300

Bug 1600126: Using shortname as identifier of group

Rather than shortname/institution pair

Need to fix up how mysqli checks for index when table name
is reserved word

behatnotneeded - existing test should be ok

Change-Id: I62e776a5497671f9455929a21d279f76cf3f4345
Signed-off-by: Robert Lyon <email address hidden>

Robert Lyon (robertl-9)
Changed in mahara:
status: In Progress → Fix Committed
Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "16.10_STABLE" branch: https://reviews.mahara.org/7318

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/7318
Committed: https://git.mahara.org/mahara/mahara/commit/0330c04866fbe2c7e6e1faae2894797cd08ddf44
Submitter: Robert Lyon (<email address hidden>)
Branch: 16.10_STABLE

commit 0330c04866fbe2c7e6e1faae2894797cd08ddf44
Author: Robert Lyon <email address hidden>
Date: Mon Oct 17 12:16:44 2016 +1300

Bug 1600126: Using shortname as identifier of group

Rather than shortname/institution pair

Need to fix up how mysqli checks for index when table name
is reserved word

behatnotneeded - existing test should be ok

Change-Id: I62e776a5497671f9455929a21d279f76cf3f4345
Signed-off-by: Robert Lyon <email address hidden>

Robert Lyon (robertl-9)
Changed in mahara:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.