Mahara

ClamAV quarantine directory should not be a language string

Bug #1607564 reported by Aaron Wells
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Fix Released
Low
Unassigned
Mahara 16.10.0

Bug Description

While looking through Mahara's ClamAV code, I noticed that the name of the directory it tries to store infected files in, is controlled by a translatable language string:

    $quarantinedir = get_config('dataroot') . get_string('quarantinedirname');

This is not a good idea, because it means that the location of these files will vary depending on what language packs are installed and what the current user's language setting is! Instead, it should be a hard-coded string or a config setting.

Tags: clamav
Aaron Wells (u-aaronw)
Changed in mahara:
assignee: nobody → Aaron Wells (u-aaronw)
Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "master" branch: https://reviews.mahara.org/6757

Revision history for this message
Mahara Bot (dev-mahara) wrote :

Patch for "master" branch: https://reviews.mahara.org/6831

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/6757
Committed: https://git.mahara.org/mahara/mahara/commit/00563fc20dbb7ad7b6e96d52943d11b347861b62
Submitter: Son Nguyen (<email address hidden>)
Branch: master

commit 00563fc20dbb7ad7b6e96d52943d11b347861b62
Author: Aaron Wells <email address hidden>
Date: Fri Jul 29 12:03:11 2016 +1200

Bug 1607564: system paths shouldn't be based on a lang string

behatnotneeded: IOU a behat test for clamav

Change-Id: I43a65b7be7490bbcb13fa8885ca119c130856a98

Son Nguyen (ngson2000)
Changed in mahara:
status: In Progress → Fix Committed
Robert Lyon (robertl-9)
Changed in mahara:
status: Fix Committed → Fix Released
Revision history for this message
Mahara Bot (dev-mahara) wrote :

Reviewed: https://reviews.mahara.org/6831
Committed: https://git.mahara.org/mahara/mahara/commit/6dd7339782eef8267cb3f0e30fff16fe211862ba
Submitter: Aaron Wells (<email address hidden>)
Branch: master

commit 6dd7339782eef8267cb3f0e30fff16fe211862ba
Author: Robert Lyon <email address hidden>
Date: Fri Aug 12 12:29:18 2016 +1200

Bug 1607564: Remove not needed quarantine dirs

The old ones based on lang strings

behatnotneeded - can't test dataroot

Change-Id: I08963fd73f2d2102c9c34535593e8afb50b6104b
Signed-off-by: Robert Lyon <email address hidden>

Robert Lyon (robertl-9)
Changed in mahara:
status: Fix Released → Fix Committed
Kristina Hoeppner (kris-hoeppner)
Changed in mahara:
assignee: Aaron Wells (u-aaronw) → nobody
Kristina Hoeppner (kris-hoeppner)
Changed in mahara:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.