Mahara

ADODB error when edit page layout

Bug #1619036 reported by Son Nguyen
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Fix Released
High
Unassigned
Mahara 17.04.0
16.10
Fix Released
High
Unassigned
Mahara 16.10.1

Bug Description

Version: master (16.10)

I got the following error when editing a page layout

[WAR] b0 (lib/adodb/adodb.inc.php:3496) Undefined offset: 0
Call stack (most recent first):
log_message("Undefined offset: 0", 8, true, true, "/var/www/html/mahara/master/htdocs/lib/adodb/adodb...", 3496) at /var/www/html/mahara/master/htdocs/lib/errors.php:513
error(8, "Undefined offset: 0", "/var/www/html/mahara/master/htdocs/lib/adodb/adodb...", 3496, array(size 7)) at /var/www/html/mahara/master/htdocs/lib/adodb/adodb.inc.php:3496
ADORecordSet->GetAssoc(true) at /var/www/html/mahara/master/htdocs/lib/dml.php:562
recordset_to_assoc(object(ADORecordSet_postgres8)) at /var/www/html/mahara/master/htdocs/lib/dml.php:644
get_records_select_assoc("view_layout", "layoutmenuorder > 0 AND iscustom = 0", array(size 0), "layoutmenuorder", "id, id") at /var/www/html/mahara/master/htdocs/view/layout.php:54

This happened after we upgraded ADODB to 5.20.5

Tags: regression
Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "master" branch: https://reviews.mahara.org/6907

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/6907
Committed: https://git.mahara.org/mahara/mahara/commit/606317195f8f3a8cdf9bc448c537b8c3708d75d7
Submitter: Son Nguyen (<email address hidden>)
Branch: master

commit 606317195f8f3a8cdf9bc448c537b8c3708d75d7
Author: Son Nguyen <email address hidden>
Date: Thu Sep 1 08:38:35 2016 +1200

Bug 1619036: Fix a bug when determine if an array is associative

Use the original code from ADODB 5.20.5

behatnotneeded

Change-Id: Id6d1d365ed2db783884172ca430488d5fcdcc1d9

Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "master" branch: https://reviews.mahara.org/6911

Kristina Hoeppner (kris-hoeppner)
Changed in mahara:
milestone: none → 16.10.0
Robert Lyon (robertl-9)
Changed in mahara:
milestone: 16.10.0 → 16.10.1
Robert Lyon (robertl-9)
Changed in mahara:
milestone: 16.10.1 → 17.04.0
Robert Lyon (robertl-9)
Changed in mahara:
status: In Progress → Fix Committed
Kristina Hoeppner (kris-hoeppner)
Changed in mahara:
assignee: Son Nguyen (ngson2000) → nobody
Robert Lyon (robertl-9)
Changed in mahara:
status: Fix Committed → Fix Released
Revision history for this message
Mahara Bot (dev-mahara) wrote :

Patch for "master" branch: https://reviews.mahara.org/11231

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/11231
Committed: https://git.mahara.org/mahara/mahara/commit/982b87a2dc83ba39fc2f87f06c508e7c7547432e
Submitter: Cecilia Vela Gurovic (<email address hidden>)
Branch: master

commit 982b87a2dc83ba39fc2f87f06c508e7c7547432e
Author: Son Nguyen <email address hidden>
Date: Thu Sep 1 08:38:35 2016 +1200

Bug 1890213: determine if array is associative

Bug 1619036: Fix a bug when determine if an array is associative

Use the original code from ADODB 5.20.5

behatnotneeded

Change-Id: Iffbdda6dd150cfe6c7fe428b1fa4661563faa9bb

Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "master" branch: https://reviews.mahara.org/11574

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/11574
Committed: https://git.mahara.org/mahara/mahara/commit/e37e9f6da048d3adccd5c3a6b5f74de6bff837d8
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit e37e9f6da048d3adccd5c3a6b5f74de6bff837d8
Author: Son Nguyen <email address hidden>
Date: Thu Sep 1 08:38:35 2016 +1200

Bug 1619036: Fix a bug when determine if an array is associative

Use the original code from ADODB 5.20.5

behatnotneeded

Change-Id: Ie9b80e5283146406443e8613ee5ca987fbaf815f

Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "master" branch: https://reviews.mahara.org/11744

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.