timezone parser in qt-5.5 breaks KDE clock

Bug #1622089 reported by Max
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
qtbase-opensource-src (Ubuntu)
Fix Released
Undecided
Timo Jyrinki
Xenial
Fix Released
Undecided
Timo Jyrinki

Bug Description

[ Impact ]

People in certain timezones have buggy time conversions in all Qt apps.

[ Test Case ]

See bug report.

[ Regression Potential ]

Should be low, in upstream LTS release and includes unit tests during build time.

--- original bug report ---

For a set of timezones in tzdata-2016*
Qt parser produces wrong result in
Qt versions earlier than 5.6.

In kubuntu-16.04 xenial xerus the most annoying
issue is broken digital clock plasmoid on the default KDE panel
if system timezone is set to e.g. Asia/Novosibirsk.
All Qt programs that attempts to convert time to non-default
timezone are affected as well in xenial and earlier ubuntu released
including ubuntu-14.04 LTS trusty.

I consider the bug is nasty enough for updating Qt in LTS ubuntu
releases.

The upstream bug is https://bugreports.qt.io/browse/QTBUG-53071
"QTimeZone mishandles tzdata 2016b and later in Russia, Kazakhstan".
The direct link to the patch that fixes the problem is
https://codereview.qt-project.org/gitweb?p=qt/qtbase.git;a=patch;h=e9041c7fc1052167f1ec2df0ea9623059e55d00f

I have rebuilt qtbase-opensource-src-5.5.1+dfsg (-16ubuntu7.1)
from sources with the patch applied and the bug has gone away.

A bit more details.

I faced the problem with Kubuntu 16.04.1, x86_64.
Asia/Novosibirsk has UTC+07:00 offset last a couple of months
but KDE clock shows a time that has offset of 14 hours from the actual wall time,
so it is rather unusable.
Command line tool "date" reports correct local time.
KDE digital clock works correctly in e.g. Asia/Krasnoyarsk timezone.
It as a workaround if time transition history does not matter.

Some other timezones affected by the bug (tzdata-2106f)
file europe:
Europe/Astrakhan
Europe/Kirov
Europe/Ulyanovsk
Asia/Barnaul
Asia/Novosibirsk
Asia/Tomsk
Asia/Novokuznetsk
file asia:
Asia/Almaty
Asia/Qyzylorda
Asia/Aqtobe
Asia/Aqtau
Asia/Oral

A simple program to demonstrate the problem:

#include <QDebug>
#include <QTimeZone>
#include <QDateTime>

int main() {
        QTimeZone tz = QTimeZone(QTimeZone::systemTimeZoneId());
        QDateTime current = QDateTime::currentDateTime();
        qDebug() << "current offset" << tz.offsetFromUtc(current);
        return 0;
}

It reports 0 for incorrectly parsed timezones.

The only thing that bothers me is that I had to disable tests
when was rebuilding libqt5core5a_5.5.1+dfsg-16ubuntu7.1_amd64.deb
using dpg-buildpackage. Otherwise I got error with cmake
in tests/auto/cmake/. Cmake was unable to find qt libraries
in the build tree.

Revision history for this message
Timo Jyrinki (timo-jyrinki) wrote :

Sounds like a good candidate for stable release upgrade to 16.04 LTS. Thank you for the bug report!

It will take some time as it will first need to be landed to 16.10 (the patch is in Qt 5.6.2, 16.10 has 5.6.1), and then the SRU process (https://wiki.ubuntu.com/StableReleaseUpdates) also takes some time.

https://codereview.qt-project.org/#/c/157499/

Changed in qtbase-opensource-src (Ubuntu):
status: New → Confirmed
Changed in qtbase-opensource-src (Ubuntu Xenial):
status: New → Confirmed
Changed in qtbase-opensource-src (Ubuntu):
assignee: nobody → Timo Jyrinki (timo-jyrinki)
Changed in qtbase-opensource-src (Ubuntu Xenial):
assignee: nobody → Timo Jyrinki (timo-jyrinki)
description: updated
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package qtbase-opensource-src - 5.6.1+dfsg-3ubuntu4~6

---------------
qtbase-opensource-src (5.6.1+dfsg-3ubuntu4~6) yakkety; urgency=medium

  [ Timo Jyrinki ]
  * debian/patches/Make-QDBusConnectionPrivate-relaySignal-be-called-in.patch:
    - Antoher DBus fix needed for telephony-service (LP: #1620945)
  * debian/patches/Fix-gcc-Wsuggest-override-warning-on-Q_OBJECT.patch
    debian/patches/Fix-the-GCC-version-supporting-Wsuggest-override.patch:
    - Fix GCC -Wsuggest-override warning on Q_OBJECT (LP: #1619483)
  * debian/patches/Fix-parsing-of-tzfile-5-POSIX-rule-zone-names-with-b.patch:
    - Fix parsing of rule zone names for certain time zones (LP: #1622089)
  * debian/patches/Avoid-artifacts-when-hiding-or-closing-a-QOpenGLWidg.patch
    debian/patches/QtWidgets-Send-show-hide-event-to-children-on-restor.patch:
    - Fix event sending to children, hurting Oxide-Qt use on desktop
      (LP: #1613670)
  * Disable QStaticText tests for now (QTBUG-55653)

 -- Timo Jyrinki <email address hidden> Mon, 12 Sep 2016 05:42:31 +0000

Changed in qtbase-opensource-src (Ubuntu):
status: Confirmed → Fix Released
Revision history for this message
Martin Pitt (pitti) wrote : Please test proposed package

Hello Max, or anyone else affected,

Accepted qtbase-opensource-src into xenial-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/qtbase-opensource-src/5.5.1+dfsg-16ubuntu7.2 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-needed to verification-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

Changed in qtbase-opensource-src (Ubuntu Xenial):
status: Confirmed → Fix Committed
tags: added: verification-needed
tags: added: kubuntul xenia
removed: xenial
tags: added: kubuntu
removed: kubuntul
tags: added: xenial
removed: xenia
Revision history for this message
Max (m-gorodok) wrote :

With libqt5core5a 5.5.1+dfsg-16ubuntu7.2 I have no problem for the Asia/Novosibirsk timezone.

Sorry for delay. I faced another bug that I did not noticed just after upgrade to 16.04.
Now I see that missing cities such as Europe/Astrakhan or Asia/Barnaul in digital clock
settings are unrelated to Qt version. The behavior is the same for 5.5.1+dfsg-16ubuntu7.1 and
for 5.5.1+dfsg-16ubuntu7.2.

Thank you for backporting of the fix.

$ LANG=C apt-cache policy libqt5core5a
libqt5core5a:
  Installed: 5.5.1+dfsg-16ubuntu7.2
  Candidate: 5.5.1+dfsg-16ubuntu7.2
  Version table:
 *** 5.5.1+dfsg-16ubuntu7.2 500
        500 http://ru.archive.ubuntu.com/ubuntu xenial-proposed/main amd64 Packages
        100 /var/lib/dpkg/status
     5.5.1+dfsg-16ubuntu7.1 500
        500 http://ru.archive.ubuntu.com/ubuntu xenial-updates/main amd64 Packages
     5.5.1+dfsg-16ubuntu7 500
        500 http://ru.archive.ubuntu.com/ubuntu xenial/main amd64 Packages

tags: added: verification-done
removed: verification-needed
Revision history for this message
Flames_in_Paradise (ellisistfroh-deactivatedaccount) wrote :

@ Max: The new tzdata (2016h) brought some names of timezones in the plsma-digitalclock ... Ubuntu's changelog is not exactely complete :-(. Further reading:

https://mm.icann.org/pipermail/tz-announce/2016-October/000042.html

Thanks for the bugreporting & testing.

Revision history for this message
Brian Murray (brian-murray) wrote : Update Released

The verification of the Stable Release Update for qtbase-opensource-src has completed successfully and the package has now been released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package qtbase-opensource-src - 5.5.1+dfsg-16ubuntu7.2

---------------
qtbase-opensource-src (5.5.1+dfsg-16ubuntu7.2) xenial; urgency=medium

  * debian/patches/Fix-parsing-of-tzfile-5-POSIX-rule-zone-names-with-b.patch:
    - Backport a timezone conversion fix from Qt 5.6.2 (LP: #1622089)

 -- Timo Jyrinki <email address hidden> Mon, 12 Sep 2016 05:49:32 +0000

Changed in qtbase-opensource-src (Ubuntu Xenial):
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.