[SRU] AttributeError: 'Requirement' object has no attribute 'project_name'

Yakkety has pip 8.1.2, so devel series is ok, this just affects Xenial

Attaching debdiff for xenial

Updated patch to address louis' feedback (renamed patch to give a more meaningful name, add dep3 headers)

Hello Felipe, or anyone else affected,

Accepted python-pip into xenial-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/python-pip/8.1.1-2ubuntu0.3 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-needed to verification-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

Tested with python requests and an upgrade. Both with root and without, and both worked.

It worked here too. Testing evidence can be found at http://pastebin.ubuntu.com/23244256/

This is currently blocked by autopkgtest regressions in python-pip and python-virtualenv - see http://people.canonical.com/~ubuntu-archive/pending-sru.html

They look unrelated so I've requested retests for those in amd64 to see if that clears it.

On Tue, 04 Oct 2016 16:20:17 -0000
Robie Basak <email address hidden> wrote:

> This is currently blocked by autopkgtest regressions in python-pip and
> python-virtualenv - see http://people.canonical.com/~ubuntu-archive
> /pending-sru.html
>
> They look unrelated so I've requested retests for those in amd64 to
> see if that clears it.

Indeed, the error is related to gcc wasn't installed.

    x86_64-linux-gnu-gcc -pthread -DNDEBUG -g -fwrapv -O2 -Wall -Wstrict-prototypes -g -fstack-protector-strong -Wformat -Werror=format-security -Wdate-time -D_FORTIFY_SOURCE=2 -fPIC -I/usr/include/python3.5m -I/tmp/autopkgtest.JkXi5S/autopkgtest_tmp/p3b/include/python3.5m -c src/public.c -o build/temp.linux-x86_64-3.5/src/public.o
    unable to execute 'x86_64-linux-gnu-gcc': No such file or directory
    error: command 'x86_64-linux-gnu-gcc' failed with exit status 1

Running autopkgtests for python-pip 8.1.1-2ubuntu0.2 (the one currently -updates) shows the same problems in my local machine.

$ adt-run python-pip -U --apt-pocket=proposed --- qemu adt-xenial-amd64-cloud.img
...
adt-run [14:00:00]: test pip3-editable.sh: [-----------------------
Obtaining file:///tmp/autopkgtest.E3hCry/autopkgtest_tmp/stupid
Command "python setup.py egg_info" failed with error code 1 in /tmp/autopkgtest.E3hCry/autopkgtest_tmp/stupid/
    Complete output from command python setup.py egg_info:
    Traceback (most recent call last):
      File "<string>", line 1, in <module>
    ImportError: No module named 'setuptools'

    ----------------------------------------
adt-run [14:00:01]: test pip3-editable.sh: -----------------------]
adt-run [14:00:02]: test pip3-editable.sh: - - - - - - - - - - results - - - - - - - - - -
pip3-editable.sh FAIL non-zero exit status 1
adt-run [14:00:02]: test pip3-editable.sh: - - - - - - - - - - stderr - - - - - - - - - -
Command "python setup.py egg_info" failed with error code 1 in /tmp/autopkgtest.E3hCry/autopkgtest_tmp/stupid/
adt-run [14:00:03]: @@@@@@@@@@@@@@@@@@@@ summary
pip2-root.sh FAIL stderr: Command "python setup.py egg_info" failed with error code 1 in /tmp/pip-build-HXzoDE/world/
pip3-root.sh FAIL stderr: Command "python setup.py egg_info" failed with error code 1 in /tmp/pip-build-35cwmvo8/world/
pip2-user.sh FAIL stderr: Command "python setup.py egg_info" failed with error code 1 in /tmp/pip-build-QFrA_G/world/
pip3-user.sh FAIL stderr: Command "python setup.py egg_info" failed with error code 1 in /tmp/pip-build-lsx6jrsp/world/
pip3-editable.sh FAIL non-zero exit status 1
qemu-system-x86_64: terminating on signal 15 from pid 27975

full log at http://pastebin.ubuntu.com/23285399/

These are my findings:

1) debian/tests/*.sh scripts install a python package called 'world'[0], a new version of that package was uploaded in August 24th (version 4.0), this new version requires python >=3.4[1], so d/t/pip2-*.sh need to install world==3.1
2) pip tries to build a wheel during the installation of world using "python setup.py bdist_wheel", bdist_wheel is provided by python{,3}-wheel, which it is NOT a dependency of python{,3}-pip, it's in the "Recommends" section, so debian/tests/control needs to include "Restrictions: needs-recommends".

Having made the changes previously described I could run autopkgtest without errors:

autopkgtest [17:39:08]: test pip3-editable.sh: -----------------------]
autopkgtest [17:39:08]: test pip3-editable.sh: - - - - - - - - - - results - - - - - - - - - -
pip3-editable.sh PASS
autopkgtest [17:39:09]: @@@@@@@@@@@@@@@@@@@@ summary
pip2-root.sh PASS
pip3-root.sh PASS
pip2-user.sh PASS
pip3-user.sh PASS
pip3-editable.sh PASS

I'm attaching a new version of the patch that fixes these problems.

[0] https://pypi.python.org/pypi/world/
[1] require_python(0x30400f0)

Attaching debdiff for yakkety

Thanks Felipe! So this needs a new upload. Subscribing ~ubuntu-sponsors, and marking verification-failed as the current version in proposed should not go any further.

Note that since 8.1.1-2ubuntu0.3 has been in proposed, that version number is now taken. A new upload will need 8.1.1-2ubuntu0.4.

Refreshed xenial patch (using 0.4), and added Y/Z patches.

I have unsubscribed ubuntu-sponsors : I am taking care of the uploads

This bug was fixed in the package python-pip - 8.1.2-2ubuntu1

---------------
python-pip (8.1.2-2ubuntu1) zesty; urgency=medium

  * d/tests:
    - control: Add needs-recommends restriction. (LP: #1626258)
    - pip2-*.sh: Install world 3.1, it's the latest version compatible
      with python2.

 -- Felipe Reyes <email address hidden> Tue, 25 Oct 2016 13:00:27 +0200

I will fix this in Debian and syncpackage it back to Zesty. Thanks for the fix.

Hello Felipe, or anyone else affected,

Accepted python-pip into yakkety-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/python-pip/8.1.2-2ubuntu0.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed.Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-needed to verification-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

Hello Felipe, or anyone else affected,

Accepted python-pip into xenial-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/python-pip/8.1.1-2ubuntu0.4 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed.Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-needed to verification-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

Test case for xenial passes -> http://pastebin.ubuntu.com/23457302/
Test case for yakkety passes -> http://pastebin.ubuntu.com/23457392/

The verification of the Stable Release Update for python-pip has completed successfully and the package has now been released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

This bug was fixed in the package python-pip - 8.1.2-2ubuntu0.1

---------------
python-pip (8.1.2-2ubuntu0.1) yakkety; urgency=medium

  * d/tests:
    - control: Add needs-recommends restriction. (LP: #1626258)
    - pip2-*.sh: Install world 3.1, it's the latest version compatible
      with python2.

 -- Felipe Reyes <email address hidden> Wed, 09 Nov 2016 15:02:34 +0100

The python-virtualenv test regression is bug 1626201, thus unrelated to this update. Releasing SRU.

This bug was fixed in the package python-pip - 8.1.1-2ubuntu0.4

---------------
python-pip (8.1.1-2ubuntu0.4) xenial; urgency=medium

  * d/patches/lp1626258.patch: Fix AttibuteError when accessing
    Requirement.project_name instead of Requirement.name. (LP: #1626258)
  * d/tests:
    - control: Add needs-recommends restriction.
    - pip2-*.sh: Install world 3.1, it's the latest version compatible
      with python2.

 -- Felipe Reyes <email address hidden> Wed, 21 Sep 2016 17:43:32 -0300